* [PR PATCH] snapcast: update to 0.23.0
@ 2021-01-15 9:18 amak79
2021-01-15 18:04 ` [PR REVIEW] " ahesford
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: amak79 @ 2021-01-15 9:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
There is a new pull request by amak79 against master on the void-packages repository
https://github.com/amak79/void-packages snapcast
https://github.com/void-linux/void-packages/pull/27943
snapcast: update to 0.23.0
A patch file from https://github.com/void-linux/void-packages/pull/27943.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snapcast-27943.patch --]
[-- Type: text/x-diff, Size: 1684 bytes --]
From 4ecd4428138183295227fb27eef96df97b1ea4b1 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Thu, 14 Jan 2021 18:46:35 +1100
Subject: [PATCH] snapcast: update to 0.23.0
---
srcpkgs/snapcast/template | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/snapcast/template b/srcpkgs/snapcast/template
index 8a1381d4b87..391ea3bc5ce 100644
--- a/srcpkgs/snapcast/template
+++ b/srcpkgs/snapcast/template
@@ -1,21 +1,23 @@
# Template file for 'snapcast'
pkgname=snapcast
-version=0.22.0
+version=0.23.0
revision=1
build_style=cmake
-configure_args="-DBUILD_WITH_TREMOR=OFF -DBUILD_WITH_AVAHI=$(vopt_if avahi ON OFF)
- -DCMAKE_INSTALL_SYSCONFDIR=/etc"
+configure_args="-DCMAKE_INSTALL_SYSCONFDIR=/etc -DBUILD_WITH_TREMOR=OFF
+ -DBUILD_WITH_AVAHI=$(vopt_if avahi ON OFF)
+ -DBUILD_WITH_PULSE=$(vopt_if pulseaudio ON OFF)"
hostmakedepends="pkg-config"
makedepends="alsa-lib-devel boost-devel expat-devel libflac-devel libsoxr-devel
- libvorbis-devel opus-devel $(vopt_if avahi avahi-libs-devel)"
+ libvorbis-devel opus-devel $(vopt_if avahi avahi-libs-devel)
+ $(vopt_if pulseaudio pulseaudio-devel)"
short_desc="Synchronous multi-room audio player"
maintainer="amak <amak.git@outlook.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/badaix/snapcast"
distfiles="https://github.com/badaix/snapcast/archive/v${version}.tar.gz"
-checksum=b5156f346c32557bc1347c81fd5071fd4a32be61adc582e63323c11b105c9ff6
+checksum=70efdeea60021f493f77ba1f3d00784911463cad11c6df214ecb19d74899b611
-build_options="avahi"
+build_options="avahi pulseaudio"
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
makedepends+=" libatomic-devel"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] snapcast: update to 0.23.0
2021-01-15 9:18 [PR PATCH] snapcast: update to 0.23.0 amak79
@ 2021-01-15 18:04 ` ahesford
2021-01-15 23:57 ` [PR PATCH] [Updated] " amak79
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2021-01-15 18:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/27943#discussion_r558479573
Comment:
Does enabling pulse disable alsa? I wonder whether the `pulseaudio` option ought to be enabled by default if it doesn't break anything. For that matter, if `avahi` enables client and server automatic discovery, it might be worth enabling by default.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] snapcast: update to 0.23.0
2021-01-15 9:18 [PR PATCH] snapcast: update to 0.23.0 amak79
2021-01-15 18:04 ` [PR REVIEW] " ahesford
@ 2021-01-15 23:57 ` amak79
2021-01-16 0:09 ` [PR REVIEW] " amak79
2021-01-16 14:16 ` [PR PATCH] [Merged]: " ahesford
3 siblings, 0 replies; 5+ messages in thread
From: amak79 @ 2021-01-15 23:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
There is an updated pull request by amak79 against master on the void-packages repository
https://github.com/amak79/void-packages snapcast
https://github.com/void-linux/void-packages/pull/27943
snapcast: update to 0.23.0
A patch file from https://github.com/void-linux/void-packages/pull/27943.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snapcast-27943.patch --]
[-- Type: text/x-diff, Size: 1727 bytes --]
From 5d2e8ee21e9756683faba7cb54f8a2904926269a Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Thu, 14 Jan 2021 18:46:35 +1100
Subject: [PATCH] snapcast: update to 0.23.0
---
srcpkgs/snapcast/template | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/snapcast/template b/srcpkgs/snapcast/template
index 8a1381d4b87..d169582b17f 100644
--- a/srcpkgs/snapcast/template
+++ b/srcpkgs/snapcast/template
@@ -1,21 +1,24 @@
# Template file for 'snapcast'
pkgname=snapcast
-version=0.22.0
+version=0.23.0
revision=1
build_style=cmake
-configure_args="-DBUILD_WITH_TREMOR=OFF -DBUILD_WITH_AVAHI=$(vopt_if avahi ON OFF)
- -DCMAKE_INSTALL_SYSCONFDIR=/etc"
+configure_args="-DCMAKE_INSTALL_SYSCONFDIR=/etc -DBUILD_WITH_TREMOR=OFF
+ -DBUILD_WITH_AVAHI=$(vopt_if avahi ON OFF)
+ -DBUILD_WITH_PULSE=$(vopt_if pulseaudio ON OFF)"
hostmakedepends="pkg-config"
makedepends="alsa-lib-devel boost-devel expat-devel libflac-devel libsoxr-devel
- libvorbis-devel opus-devel $(vopt_if avahi avahi-libs-devel)"
+ libvorbis-devel opus-devel $(vopt_if avahi avahi-libs-devel)
+ $(vopt_if pulseaudio pulseaudio-devel)"
short_desc="Synchronous multi-room audio player"
maintainer="amak <amak.git@outlook.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/badaix/snapcast"
distfiles="https://github.com/badaix/snapcast/archive/v${version}.tar.gz"
-checksum=b5156f346c32557bc1347c81fd5071fd4a32be61adc582e63323c11b105c9ff6
+checksum=70efdeea60021f493f77ba1f3d00784911463cad11c6df214ecb19d74899b611
-build_options="avahi"
+build_options="avahi pulseaudio"
+build_options_default="avahi pulseaudio"
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
makedepends+=" libatomic-devel"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] snapcast: update to 0.23.0
2021-01-15 9:18 [PR PATCH] snapcast: update to 0.23.0 amak79
2021-01-15 18:04 ` [PR REVIEW] " ahesford
2021-01-15 23:57 ` [PR PATCH] [Updated] " amak79
@ 2021-01-16 0:09 ` amak79
2021-01-16 14:16 ` [PR PATCH] [Merged]: " ahesford
3 siblings, 0 replies; 5+ messages in thread
From: amak79 @ 2021-01-16 0:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New review comment by amak79 on void-packages repository
https://github.com/void-linux/void-packages/pull/27943#discussion_r558698311
Comment:
I've now enabled both options. Enabling `pulseaudio` shouldn't break `alsa`. The Snapcast client has a `player` option to configure which backend to use. The default is `alsa`.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: snapcast: update to 0.23.0
2021-01-15 9:18 [PR PATCH] snapcast: update to 0.23.0 amak79
` (2 preceding siblings ...)
2021-01-16 0:09 ` [PR REVIEW] " amak79
@ 2021-01-16 14:16 ` ahesford
3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2021-01-16 14:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
There's a merged pull request on the void-packages repository
snapcast: update to 0.23.0
https://github.com/void-linux/void-packages/pull/27943
Description:
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-16 14:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 9:18 [PR PATCH] snapcast: update to 0.23.0 amak79
2021-01-15 18:04 ` [PR REVIEW] " ahesford
2021-01-15 23:57 ` [PR PATCH] [Updated] " amak79
2021-01-16 0:09 ` [PR REVIEW] " amak79
2021-01-16 14:16 ` [PR PATCH] [Merged]: " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).