[PR PATCH] librsvg: fix cross

[PR PATCH] librsvg: fix cross

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 3131 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages librsvg
https://github.com/void-linux/void-packages/pull/28230

librsvg: fix cross
<!-- Mark items with [x] where applicable -->

Currently the package seems to fail to cross compile, I do not know why the `--host` was added to conf args in the first place.
```
configure: WARNING: unrecognized options: --with-libtool-sysroot
checking for a BSD-compatible install... /builddir/.xbps-librsvg/wrappers/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether UID '1000' is supported by ustar format... yes
checking whether GID '1000' is supported by ustar format... yes
checking how to create a ustar tar archive... none
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... yes
checking for a sed that does not truncate output... /usr/bin/sed
checking whether NLS is requested... yes
checking for msgfmt... no
checking for gmsgfmt... :
checking for xgettext... no
checking for msgmerge... no
checking whether make supports the include directive... yes (GNU style)
checking for gcc... aarch64-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... configure: error: in `/builddir/librsvg-2.48.8':
configure: error: cannot run C compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details
```


#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
- [x] I have not tested this yet

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [x] aarch64
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/28230.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-librsvg-28230.patch --]
[-- Type: text/x-diff, Size: 766 bytes --]

From 69593574ab08bcead4248a824b7158b17ab29420 Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Mon, 25 Jan 2021 23:18:12 +0100
Subject: [PATCH] librsvg: fix cross

---
 srcpkgs/librsvg/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/librsvg/template b/srcpkgs/librsvg/template
index f8398b9d5ef..9b7e1ccc8f8 100644
--- a/srcpkgs/librsvg/template
+++ b/srcpkgs/librsvg/template
@@ -5,7 +5,7 @@ version=2.48.8
 revision=1
 build_style=gnu-configure
 build_helper="gir"
-configure_args="--disable-static --host=${XBPS_TARGET_TRIPLET}
+configure_args="--disable-static
  $(vopt_enable gir introspection) $(vopt_enable vala)"
 hostmakedepends="cargo pkg-config python glib-devel
  gdk-pixbuf-devel $(vopt_if vala vala)"

Re: librsvg: fix cross

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/28230#issuecomment-767440892

Comment:
Oops, I didn't see your PR and did 9e9a2c5 .
There are more packages which have `--host=` in configure_args. They will probably also fail to cross build.

Re: librsvg: fix cross

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/28230#issuecomment-767440892

Comment:
Oops, I didn't see your PR and did 9e9a2c5 .
There are more packages which have `--host=` in configure_args. They will probably also fail to cross build.
I am rebuilding all for the `armv7l` target and will certainly find more.

Re: librsvg: fix cross

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/28230#issuecomment-767446170

Comment:
Fixed.

Re: [PR PATCH] [Closed]: librsvg: fix cross

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 2972 bytes --]

There's a closed pull request on the void-packages repository

librsvg: fix cross
https://github.com/void-linux/void-packages/pull/28230

Description:
<!-- Mark items with [x] where applicable -->

Currently the package seems to fail to cross compile, I do not know why the `--host` was added to conf args in the first place.
```
configure: WARNING: unrecognized options: --with-libtool-sysroot
checking for a BSD-compatible install... /builddir/.xbps-librsvg/wrappers/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether UID '1000' is supported by ustar format... yes
checking whether GID '1000' is supported by ustar format... yes
checking how to create a ustar tar archive... none
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... yes
checking for a sed that does not truncate output... /usr/bin/sed
checking whether NLS is requested... yes
checking for msgfmt... no
checking for gmsgfmt... :
checking for xgettext... no
checking for msgmerge... no
checking whether make supports the include directive... yes (GNU style)
checking for gcc... aarch64-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... configure: error: in `/builddir/librsvg-2.48.8':
configure: error: cannot run C compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details
```


#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
- [x] I have not tested this yet

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [x] aarch64
  - [ ] armv7l
  - [ ] armv6l-musl