[PR PATCH] python3-chromecast: update to 8.0.0.

[PR PATCH] python3-chromecast: update to 8.0.0.

[uw2021]

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

There is a new pull request by uw2021 against master on the void-packages repository

https://github.com/uw2021/void-packages python3-chromecast-update
https://github.com/void-linux/void-packages/pull/28357

python3-chromecast: update to 8.0.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28357.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-chromecast-update-28357.patch --]
[-- Type: text/x-diff, Size: 1330 bytes --]

From 331346ca1135f645b7f0fb421d3b7a88038acb8e Mon Sep 17 00:00:00 2001
From: Ulf <ulf@voidlinux.home>
Date: Sun, 31 Jan 2021 13:34:53 +0000
Subject: [PATCH] python3-chromecast: update to 8.0.0.

---
 srcpkgs/python3-chromecast/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-chromecast/template b/srcpkgs/python3-chromecast/template
index c018f118050..9af147b12ba 100644
--- a/srcpkgs/python3-chromecast/template
+++ b/srcpkgs/python3-chromecast/template
@@ -1,17 +1,17 @@
 # Template file for 'python3-chromecast'
 pkgname=python3-chromecast
-version=7.7.2
+version=8.0.0
 revision=1
 wrksrc="pychromecast-${version}"
 build_style=python3-module
-hostmakedepends="python3-setuptools"
+hostmakedepends="python3-setuptools python3-wheel python3-pip"
 depends="python3-protobuf python3-zeroconf python3-casttube"
 short_desc="Python3 library to communicate with Google Chromecast"
 maintainer="Ulf <void@uw.anonaddy.com>"
 license="MIT"
 homepage="https://github.com/home-assistant-libs/pychromecast"
 distfiles="https://github.com/home-assistant-libs/pychromecast/archive/${version}.tar.gz"
-checksum=98aef480168163c26405c16e69458829d7ec62ac9129c0d9c8f2e86a3f83a10e
+checksum=b3bbb0e96ece7dbdb301434865c33360c38ccd013c32e5c2fa629e471e6891c5
 
 post_install() {
 	vlicense LICENSE

Re: python3-chromecast: update to 8.0.0.

[uw2021]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by uw2021 on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770384365

Comment:
Just to explain the extra dependencies, it initially complained of what I assumed were missing dependencies (python3-pip and python3-wheel). Adding these allowed it to compile and install fine.

Re: [PR REVIEW] python3-chromecast: update to 8.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#discussion_r567436222

Comment:
No, this is not how you fix the package. You need to add things from https://github.com/home-assistant-libs/pychromecast/blob/master/requirements.txt (they are in depends) to hostmakedepends.

Also add https://github.com/home-assistant-libs/pychromecast/blob/master/requirements-test.txt to checkdepends, if we have packages for all of them.

Re: [PR PATCH] [Updated] python3-chromecast: update to 8.0.0.

[uw2021]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

There is an updated pull request by uw2021 against master on the void-packages repository

https://github.com/uw2021/void-packages python3-chromecast-update
https://github.com/void-linux/void-packages/pull/28357

python3-chromecast: update to 8.0.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28357.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-chromecast-update-28357.patch --]
[-- Type: text/x-diff, Size: 1408 bytes --]

From 01e76b163e7f3fb95a16de7093147489121d6b2e Mon Sep 17 00:00:00 2001
From: Ulf <ulf@voidlinux.home>
Date: Sun, 31 Jan 2021 13:34:53 +0000
Subject: [PATCH] python3-chromecast: update to 8.0.0.

---
 srcpkgs/python3-chromecast/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-chromecast/template b/srcpkgs/python3-chromecast/template
index c018f118050..8e274036181 100644
--- a/srcpkgs/python3-chromecast/template
+++ b/srcpkgs/python3-chromecast/template
@@ -1,17 +1,18 @@
 # Template file for 'python3-chromecast'
 pkgname=python3-chromecast
-version=7.7.2
+version=8.0.0
 revision=1
 wrksrc="pychromecast-${version}"
 build_style=python3-module
-hostmakedepends="python3-setuptools"
+hostmakedepends="python3-setuptools python3-protobuf python3-zeroconf python3-casttube"
 depends="python3-protobuf python3-zeroconf python3-casttube"
+checkdepends="python3-flake8 python3-pylint black"
 short_desc="Python3 library to communicate with Google Chromecast"
 maintainer="Ulf <void@uw.anonaddy.com>"
 license="MIT"
 homepage="https://github.com/home-assistant-libs/pychromecast"
 distfiles="https://github.com/home-assistant-libs/pychromecast/archive/${version}.tar.gz"
-checksum=98aef480168163c26405c16e69458829d7ec62ac9129c0d9c8f2e86a3f83a10e
+checksum=b3bbb0e96ece7dbdb301434865c33360c38ccd013c32e5c2fa629e471e6891c5
 
 post_install() {
 	vlicense LICENSE

Re: [PR REVIEW] python3-chromecast: update to 8.0.0.

[uw2021]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

New review comment by uw2021 on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#discussion_r567438229

Comment:
> No, this is not how you fix the package. You need to add things from https://github.com/home-assistant-libs/pychromecast/blob/master/requirements.txt (they are in depends) to hostmakedepends.
> 
> Also add https://github.com/home-assistant-libs/pychromecast/blob/master/requirements-test.txt to checkdepends, if we have packages for all of them.

Done. Thank you.

Re: python3-chromecast: update to 8.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770429869

Comment:
Have you tested `mkchromecast` with this?

Re: python3-chromecast: update to 8.0.0.

[uw2021]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New comment by uw2021 on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770432364

Comment:
> Have you tested `mkchromecast` with this?

I've just tested mkchromecast with both 8.0.0 and 7.7.2 and I receive the same error when running mkchromecast in the terminal:

`ImportError: cannot import name 'reboot' from 'pychromecast.dial' (/usr/lib/python3.9/site-packages/pychromecast/dial.py)

Also, when running mkchromecast from the app tray (on both 7.7.2 and 8.0.0) nothing happens. Not sure what's going on here.

Re: python3-chromecast: update to 8.0.0.

[uw2021]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

New comment by uw2021 on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770432364

Comment:
> Have you tested `mkchromecast` with this?

I've just tested mkchromecast with both 8.0.0 and 7.7.2 and I receive the same error when running mkchromecast in the terminal:

`ImportError: cannot import name 'reboot' from 'pychromecast.dial' (/usr/lib/python3.9/site-packages/pychromecast/dial.py)`

Also, when running mkchromecast from the app tray (on both 7.7.2 and 8.0.0) nothing happens. Not sure what's going on here.

Re: python3-chromecast: update to 8.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770432776

Comment:
If it hits an ImportError it won't be able to launch at all, so it makes sense you didn't see anything.

Re: python3-chromecast: update to 8.0.0.

[uw2021]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by uw2021 on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770432988

Comment:
> If it hits an ImportError it won't be able to launch at all, so it makes sense you didn't see anything.

Is that related to my system? Strange it happens on both 7.7.2 and 8.0.0.

Re: python3-chromecast: update to 8.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770433687

Comment:
Hm, we need to backport this PR https://github.com/muammar/mkchromecast/pull/325 , at least. They seem to have made a release for debian, I will try to find the tag being used.

Re: python3-chromecast: update to 8.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770433952

Comment:
Alternatively, do what the debian package is doing and grab a git hash (I don't like it, but it works)

Re: python3-chromecast: update to 8.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770433687

Comment:
Hm, we need to backport this PR https://github.com/muammar/mkchromecast/pull/325 , at least. They seem to have made a release for debian, I will try to find the tag being used. https://github.com/muammar/mkchromecast/issues/348

Re: python3-chromecast: update to 8.0.0.

[uw2021]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

New comment by uw2021 on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770435589

Comment:
> Hm, we need to backport this PR [muammar/mkchromecast#325](https://github.com/muammar/mkchromecast/pull/325) , at least. They seem to have made a release for debian, I will try to find the tag being used. [muammar/mkchromecast#348](https://github.com/muammar/mkchromecast/issues/348)

So if I've got this right, the plan is to try and get a 0.3.9 release, package it, then mkchromecast should work? Is using a git hash a better idea? Not familiar with it  to be honest.

Re: python3-chromecast: update to 8.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28357#issuecomment-770439237

Comment:
Better to use a release, but if upstream is unable to make one we should switch to a hash.

Re: [PR PATCH] [Merged]: python3-chromecast: update to 8.0.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

There's a merged pull request on the void-packages repository

python3-chromecast: update to 8.0.0.
https://github.com/void-linux/void-packages/pull/28357

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->