Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] plymouth: update to 0.9.5.
@ 2021-02-03 17:22 circhioz
  2021-02-04  6:26 ` [PR REVIEW] " ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: circhioz @ 2021-02-03 17:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]

There is a new pull request by circhioz against master on the void-packages repository

https://github.com/circhioz/void-packages plymouth
https://github.com/void-linux/void-packages/pull/28444

plymouth: update to 0.9.5.
`--enable-gdm-transition` was deprecated in 2012. `gettext` is now needed to translate the user visible strings.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28444.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-plymouth-28444.patch --]
[-- Type: text/x-diff, Size: 2421 bytes --]

From 8d3e7c2edeb17b633f7bc332b31870ad3f84cd20 Mon Sep 17 00:00:00 2001
From: Francesco Circhetta <francesco.circhetta@gmail.com>
Date: Thu, 21 Jan 2021 19:58:04 +0100
Subject: [PATCH] plymouth: update to 0.9.5.

---
 common/shlibs             |  8 ++++----
 srcpkgs/plymouth/template | 10 +++++-----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 1523374f949..5d344a34673 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2751,10 +2751,10 @@ libTKXmlXCAF.so.11 oce-0.18_1
 libTKernel.so.11 oce-0.18_1
 libKF5CoreAddons.so.5 kcoreaddons-5.26.0_1
 librpmatch.so.0 musl-rpmatch-1.0_1
-libply.so.4 plymouth-0.9.2_1
-libply-splash-core.so.4 plymouth-0.9.2_1
-libply-splash-graphics.so.4 plymouth-0.9.2_1
-libply-boot-client.so.4 plymouth-0.9.2_1
+libply.so.5 plymouth-0.9.5_1
+libply-splash-core.so.5 plymouth-0.9.5_1
+libply-splash-graphics.so.5 plymouth-0.9.5_1
+libply-boot-client.so.5 plymouth-0.9.5_1
 libmilter.so.1.0.2 libmilter-1.0.2_1
 libopendkim.so.10 opendkim-2.10.3_1
 libtevent.so.0 tevent-0.9.28_1
diff --git a/srcpkgs/plymouth/template b/srcpkgs/plymouth/template
index afb00bfb2a8..17f801fc531 100644
--- a/srcpkgs/plymouth/template
+++ b/srcpkgs/plymouth/template
@@ -1,15 +1,15 @@
 # Template file for 'plymouth'
 pkgname=plymouth
-version=0.9.4
-revision=2
+version=0.9.5
+revision=1
 build_style=gnu-configure
 configure_args="--with-system-root-install=no \
  --without-rhgb-compat-link --enable-systemd-integration=no \
- --enable-gdm-transition $(vopt_enable gtk3 gtk) $(vopt_enable pango) \
+ $(vopt_enable gtk3 gtk) $(vopt_enable pango) \
  --with-logo=/usr/share/void-artwork/void-transparent.png --localstatedir=/ \
  --disable-documentation"
 conf_files="/etc/plymouth/plymouthd.conf"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config gettext"
 makedepends="libdrm-devel libpng-devel void-artwork
  $(vopt_if gtk3 gtk+3-devel) $(vopt_if pango pango-devel)"
 depends="plymouth-data>=0"
@@ -18,7 +18,7 @@ maintainer="William OD <obirik2005@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/Plymouth/"
 distfiles="${FREEDESKTOP_SITE}/plymouth/releases/$pkgname-$version.tar.xz"
-checksum=4a197a4f1a05785d7453dd829b231352fb2d09171bd86c5ffaafbb2dd6791351
+checksum=ecae257f351d098340542a5bc06de029404c24dcee87e6ebb2abd5ef117fce86
 
 build_options="gtk3 pango"
 build_options_default="gtk3 pango"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] plymouth: update to 0.9.5.
  2021-02-03 17:22 [PR PATCH] plymouth: update to 0.9.5 circhioz
@ 2021-02-04  6:26 ` ericonr
  2021-02-04  6:26 ` ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-04  6:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28444#discussion_r569974556

Comment:
outdated option or did it have to be disabled?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] plymouth: update to 0.9.5.
  2021-02-03 17:22 [PR PATCH] plymouth: update to 0.9.5 circhioz
  2021-02-04  6:26 ` [PR REVIEW] " ericonr
@ 2021-02-04  6:26 ` ericonr
  2021-02-04 10:30 ` circhioz
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-04  6:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28444#discussion_r569974742

Comment:
Are these entries necessary at all? We could just clean them up.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] plymouth: update to 0.9.5.
  2021-02-03 17:22 [PR PATCH] plymouth: update to 0.9.5 circhioz
  2021-02-04  6:26 ` [PR REVIEW] " ericonr
  2021-02-04  6:26 ` ericonr
@ 2021-02-04 10:30 ` circhioz
  2021-02-04 10:34 ` circhioz
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: circhioz @ 2021-02-04 10:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by circhioz on void-packages repository

https://github.com/void-linux/void-packages/pull/28444#discussion_r570113884

Comment:
There shouldn't be any piece of software linking against `libply`, I'm fine removing those entries.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] plymouth: update to 0.9.5.
  2021-02-03 17:22 [PR PATCH] plymouth: update to 0.9.5 circhioz
                   ` (2 preceding siblings ...)
  2021-02-04 10:30 ` circhioz
@ 2021-02-04 10:34 ` circhioz
  2021-02-04 10:38 ` [PR PATCH] [Updated] " circhioz
  2021-02-04 13:03 ` [PR PATCH] [Merged]: " ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: circhioz @ 2021-02-04 10:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by circhioz on void-packages repository

https://github.com/void-linux/void-packages/pull/28444#discussion_r570116127

Comment:
Just outdated, it has been removed from the codebase.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] plymouth: update to 0.9.5.
  2021-02-03 17:22 [PR PATCH] plymouth: update to 0.9.5 circhioz
                   ` (3 preceding siblings ...)
  2021-02-04 10:34 ` circhioz
@ 2021-02-04 10:38 ` circhioz
  2021-02-04 13:03 ` [PR PATCH] [Merged]: " ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: circhioz @ 2021-02-04 10:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

There is an updated pull request by circhioz against master on the void-packages repository

https://github.com/circhioz/void-packages plymouth
https://github.com/void-linux/void-packages/pull/28444

plymouth: update to 0.9.5.
`--enable-gdm-transition` was deprecated in 2012. `gettext` is now needed to translate the user visible strings.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28444.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-plymouth-28444.patch --]
[-- Type: text/x-diff, Size: 2256 bytes --]

From a3a54b1bf3f743294614441b72e1fe16a268bc0f Mon Sep 17 00:00:00 2001
From: Francesco Circhetta <francesco.circhetta@gmail.com>
Date: Thu, 21 Jan 2021 19:58:04 +0100
Subject: [PATCH] plymouth: update to 0.9.5.

---
 common/shlibs             |  4 ----
 srcpkgs/plymouth/template | 10 +++++-----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 1523374f949..35263ec4744 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2751,10 +2751,6 @@ libTKXmlXCAF.so.11 oce-0.18_1
 libTKernel.so.11 oce-0.18_1
 libKF5CoreAddons.so.5 kcoreaddons-5.26.0_1
 librpmatch.so.0 musl-rpmatch-1.0_1
-libply.so.4 plymouth-0.9.2_1
-libply-splash-core.so.4 plymouth-0.9.2_1
-libply-splash-graphics.so.4 plymouth-0.9.2_1
-libply-boot-client.so.4 plymouth-0.9.2_1
 libmilter.so.1.0.2 libmilter-1.0.2_1
 libopendkim.so.10 opendkim-2.10.3_1
 libtevent.so.0 tevent-0.9.28_1
diff --git a/srcpkgs/plymouth/template b/srcpkgs/plymouth/template
index afb00bfb2a8..17f801fc531 100644
--- a/srcpkgs/plymouth/template
+++ b/srcpkgs/plymouth/template
@@ -1,15 +1,15 @@
 # Template file for 'plymouth'
 pkgname=plymouth
-version=0.9.4
-revision=2
+version=0.9.5
+revision=1
 build_style=gnu-configure
 configure_args="--with-system-root-install=no \
  --without-rhgb-compat-link --enable-systemd-integration=no \
- --enable-gdm-transition $(vopt_enable gtk3 gtk) $(vopt_enable pango) \
+ $(vopt_enable gtk3 gtk) $(vopt_enable pango) \
  --with-logo=/usr/share/void-artwork/void-transparent.png --localstatedir=/ \
  --disable-documentation"
 conf_files="/etc/plymouth/plymouthd.conf"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config gettext"
 makedepends="libdrm-devel libpng-devel void-artwork
  $(vopt_if gtk3 gtk+3-devel) $(vopt_if pango pango-devel)"
 depends="plymouth-data>=0"
@@ -18,7 +18,7 @@ maintainer="William OD <obirik2005@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.freedesktop.org/wiki/Software/Plymouth/"
 distfiles="${FREEDESKTOP_SITE}/plymouth/releases/$pkgname-$version.tar.xz"
-checksum=4a197a4f1a05785d7453dd829b231352fb2d09171bd86c5ffaafbb2dd6791351
+checksum=ecae257f351d098340542a5bc06de029404c24dcee87e6ebb2abd5ef117fce86
 
 build_options="gtk3 pango"
 build_options_default="gtk3 pango"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: plymouth: update to 0.9.5.
  2021-02-03 17:22 [PR PATCH] plymouth: update to 0.9.5 circhioz
                   ` (4 preceding siblings ...)
  2021-02-04 10:38 ` [PR PATCH] [Updated] " circhioz
@ 2021-02-04 13:03 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-02-04 13:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]

There's a merged pull request on the void-packages repository

plymouth: update to 0.9.5.
https://github.com/void-linux/void-packages/pull/28444

Description:
`--enable-gdm-transition` was deprecated in 2012. `gettext` is now needed to translate the user visible strings.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-02-04 13:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 17:22 [PR PATCH] plymouth: update to 0.9.5 circhioz
2021-02-04  6:26 ` [PR REVIEW] " ericonr
2021-02-04  6:26 ` ericonr
2021-02-04 10:30 ` circhioz
2021-02-04 10:34 ` circhioz
2021-02-04 10:38 ` [PR PATCH] [Updated] " circhioz
2021-02-04 13:03 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).