* [PR PATCH] vboot-utils: Add update check
@ 2021-02-05 8:58 the-maldridge
2021-02-05 9:02 ` [PR PATCH] [Updated] " the-maldridge
` (18 more replies)
0 siblings, 19 replies; 20+ messages in thread
From: the-maldridge @ 2021-02-05 8:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
There is a new pull request by the-maldridge against master on the void-packages repository
https://github.com/the-maldridge/void-packages vboot-update
https://github.com/void-linux/void-packages/pull/28510
vboot-utils: Add update check
Adds an update check that parses the git revision. Also removes the need to keep track of a separate git hash. Resolves complaint surfaced in #28507, but does not actually update the package as I have no time nor resources to test the functionality of this package.
A patch file from https://github.com/void-linux/void-packages/pull/28510.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vboot-update-28510.patch --]
[-- Type: text/x-diff, Size: 1608 bytes --]
From 6e52941cb44579fbc4131e6b4cd0761a5b5abdc7 Mon Sep 17 00:00:00 2001
From: Michael Aldridge <maldridge@VoidLinux.org>
Date: Fri, 5 Feb 2021 00:56:53 -0800
Subject: [PATCH] vboot-utils: Add update check
---
srcpkgs/vboot-utils/template | 5 +----
srcpkgs/vboot-utils/update | 3 +++
2 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 srcpkgs/vboot-utils/update
diff --git a/srcpkgs/vboot-utils/template b/srcpkgs/vboot-utils/template
index 46871f18f25..5723a9b0f94 100644
--- a/srcpkgs/vboot-utils/template
+++ b/srcpkgs/vboot-utils/template
@@ -3,7 +3,6 @@ pkgname=vboot-utils
version=45.7262
revision=13
archs="x86_64* i686* aarch64* arm*"
-_githash=0e8c964915fffb58032bb59bdb31949de718ca90
hostmakedepends="pkg-config git"
makedepends="libressl-devel libuuid-devel liblzma-devel libyaml-devel"
short_desc="Verified boot kernel utilities"
@@ -17,9 +16,7 @@ case "$XBPS_TARGET_MACHINE" in
esac
do_fetch() {
- git clone https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git $pkgname-$version || true
- cd $pkgname-$version
- git checkout $_githash
+ git clone -b release-R${version/./-}.B https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git $pkgname-$version
}
do_build() {
diff --git a/srcpkgs/vboot-utils/update b/srcpkgs/vboot-utils/update
new file mode 100644
index 00000000000..e360ec80b5c
--- /dev/null
+++ b/srcpkgs/vboot-utils/update
@@ -0,0 +1,3 @@
+site="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git/+refs?format=TEXT"
+pattern='refs/heads/release-R\K[\d]+-[\d]+'
+version=${version//./-}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
@ 2021-02-05 9:02 ` the-maldridge
2021-02-05 10:16 ` [PR REVIEW] " Gottox
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: the-maldridge @ 2021-02-05 9:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
There is an updated pull request by the-maldridge against master on the void-packages repository
https://github.com/the-maldridge/void-packages vboot-update
https://github.com/void-linux/void-packages/pull/28510
vboot-utils: Add update check
Adds an update check that parses the git revision. Also removes the need to keep track of a separate git hash. Resolves complaint surfaced in #28507, but does not actually update the package as I have no time nor resources to test the functionality of this package.
A patch file from https://github.com/void-linux/void-packages/pull/28510.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vboot-update-28510.patch --]
[-- Type: text/x-diff, Size: 1832 bytes --]
From 73cf486b4b0c4ca174ea1f6522570e9b4d1e8ca1 Mon Sep 17 00:00:00 2001
From: Michael Aldridge <maldridge@VoidLinux.org>
Date: Fri, 5 Feb 2021 00:56:53 -0800
Subject: [PATCH] vboot-utils: Add update check
---
srcpkgs/vboot-utils/template | 7 ++-----
srcpkgs/vboot-utils/update | 3 +++
2 files changed, 5 insertions(+), 5 deletions(-)
create mode 100644 srcpkgs/vboot-utils/update
diff --git a/srcpkgs/vboot-utils/template b/srcpkgs/vboot-utils/template
index 46871f18f25..aeab9dc8f96 100644
--- a/srcpkgs/vboot-utils/template
+++ b/srcpkgs/vboot-utils/template
@@ -3,12 +3,11 @@ pkgname=vboot-utils
version=45.7262
revision=13
archs="x86_64* i686* aarch64* arm*"
-_githash=0e8c964915fffb58032bb59bdb31949de718ca90
hostmakedepends="pkg-config git"
makedepends="libressl-devel libuuid-devel liblzma-devel libyaml-devel"
short_desc="Verified boot kernel utilities"
maintainer="Enno Boland <gottox@voidlinux.org>"
-license="BSD"
+license="BSD-3-Clause"
homepage="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git"
CFLAGS='-D_GNU_SOURCE -Wno-error -fcommon'
@@ -17,9 +16,7 @@ case "$XBPS_TARGET_MACHINE" in
esac
do_fetch() {
- git clone https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git $pkgname-$version || true
- cd $pkgname-$version
- git checkout $_githash
+ git clone -b release-R${version/./-}.B https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git $pkgname-$version
}
do_build() {
diff --git a/srcpkgs/vboot-utils/update b/srcpkgs/vboot-utils/update
new file mode 100644
index 00000000000..e360ec80b5c
--- /dev/null
+++ b/srcpkgs/vboot-utils/update
@@ -0,0 +1,3 @@
+site="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git/+refs?format=TEXT"
+pattern='refs/heads/release-R\K[\d]+-[\d]+'
+version=${version//./-}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
2021-02-05 9:02 ` [PR PATCH] [Updated] " the-maldridge
@ 2021-02-05 10:16 ` Gottox
2021-02-05 10:17 ` Gottox
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 10:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r570862590
Comment:
The upstream supports tar.gz snapshots from revisions now. We should use this for fetching the binaries instead.
Also I just remembered why I chose to not depend on a named revision, like a tag or a branch. This allows the upstream to change the revisions content without any notice. With a commit hash we have a cryptographic proof of authenticity.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
2021-02-05 9:02 ` [PR PATCH] [Updated] " the-maldridge
2021-02-05 10:16 ` [PR REVIEW] " Gottox
@ 2021-02-05 10:17 ` Gottox
2021-02-05 11:26 ` fosslinux
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 10:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r570862590
Comment:
The upstream supports tar.gz snapshots of revisions now. We should use this for fetching the binaries instead.
Also I just remembered why I chose to not depend on a named revision, like a tag or a branch. This allows the upstream to change the revisions content without any notice. With a commit hash we have a cryptographic proof of authenticity.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (2 preceding siblings ...)
2021-02-05 10:17 ` Gottox
@ 2021-02-05 11:26 ` fosslinux
2021-02-05 11:26 ` fosslinux
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: fosslinux @ 2021-02-05 11:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r570901608
Comment:
I don't think that holds very well, we use tar release tarballs for probably >90% of packages, we don't have any kind of cryptographic proof of authenticity for those.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (3 preceding siblings ...)
2021-02-05 11:26 ` fosslinux
@ 2021-02-05 11:26 ` fosslinux
2021-02-05 13:33 ` ericonr
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: fosslinux @ 2021-02-05 11:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r570901608
Comment:
I don't think that holds very well, we use tar release tarballs for probably >90% of packages, we don't have any kind of cryptographic proof of authenticity for those.
> This allows the upstream to change the revisions content without any notice.
Is very easy with basically every other distribution method, inc. tars..
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (4 preceding siblings ...)
2021-02-05 11:26 ` fosslinux
@ 2021-02-05 13:33 ` ericonr
2021-02-05 16:44 ` Gottox
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-05 13:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r570969498
Comment:
The only defenses against this are:
- contench checksum (doesn't work for all packages)
- checking tarball signature
- comparing contents of the cached tarball with old checksum against new tarball
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (5 preceding siblings ...)
2021-02-05 13:33 ` ericonr
@ 2021-02-05 16:44 ` Gottox
2021-02-05 16:45 ` Gottox
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 16:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r571101731
Comment:
@fosslinux Not true, we check the tar.gz for the right sha256 sum and we hit this issue multiple times where upstream has changed the tars after the release.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (6 preceding siblings ...)
2021-02-05 16:44 ` Gottox
@ 2021-02-05 16:45 ` Gottox
2021-02-05 16:47 ` Gottox
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 16:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r571102540
Comment:
> * comparing contents of the cached tarball with old checksum against new tarball
@ericonr Yea, I remember a few cases where I did exactly that
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (7 preceding siblings ...)
2021-02-05 16:45 ` Gottox
@ 2021-02-05 16:47 ` Gottox
2021-02-05 17:02 ` Gottox
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 16:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r571103917
Comment:
Okay, It's not a proof for authenticity. But we can verify if the content got changed.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (8 preceding siblings ...)
2021-02-05 16:47 ` Gottox
@ 2021-02-05 17:02 ` Gottox
2021-02-05 17:40 ` [PR REVIEW] " ericonr
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 17:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#issuecomment-774159076
Comment:
My suggestion to download tgz instead:
```diff
diff --git a/srcpkgs/vboot-utils/template b/srcpkgs/vboot-utils/template
index aeab9dc8f9..1155e2cd6d 100644
--- a/srcpkgs/vboot-utils/template
+++ b/srcpkgs/vboot-utils/template
@@ -10,15 +10,14 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
license="BSD-3-Clause"
homepage="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git"
CFLAGS='-D_GNU_SOURCE -Wno-error -fcommon'
+distfiles="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git/+archive/refs/heads/release-R${version//./-}.B.tar.gz"
+checksum=c95b86754bf59e7dd7a78953aeea939e367363c7c21a0fbe7cd1456c12e295a9
+create_wrksrc=yes
case "$XBPS_TARGET_MACHINE" in
aarch64*) broken="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/8508/steps/shell_3/logs/stdio" ;;
esac
-do_fetch() {
- git clone -b release-R${version/./-}.B https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git $pkgname-$version
-}
-
do_build() {
local _arch=
sed -i "s/MTD_CHAR_MAJOR/90/" cgpt/cgpt_wrapper.c
```
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (9 preceding siblings ...)
2021-02-05 17:02 ` Gottox
@ 2021-02-05 17:40 ` ericonr
2021-02-05 17:45 ` Gottox
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-02-05 17:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r571138552
Comment:
@Gottox And for the record, I do agree with you on one point here: if we use a commit hash, we can way more easily track down the original tarball, if it isn't available from distfile caches. With just the tag, it's very hard to find the original ref.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (10 preceding siblings ...)
2021-02-05 17:40 ` [PR REVIEW] " ericonr
@ 2021-02-05 17:45 ` Gottox
2021-02-05 22:23 ` fosslinux
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 17:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r571141729
Comment:
yes, that's true.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (11 preceding siblings ...)
2021-02-05 17:45 ` Gottox
@ 2021-02-05 22:23 ` fosslinux
2021-02-05 22:34 ` Gottox
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: fosslinux @ 2021-02-05 22:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#discussion_r571283002
Comment:
Hm, ok, fair, kinda forgot about checksums :P I like your diff below, that looks good to me.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (12 preceding siblings ...)
2021-02-05 22:23 ` fosslinux
@ 2021-02-05 22:34 ` Gottox
2021-02-05 22:40 ` Johnnynator
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 22:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#issuecomment-774324930
Comment:
also git can be removed from `hostmakedepends` when applying the patch.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (13 preceding siblings ...)
2021-02-05 22:34 ` Gottox
@ 2021-02-05 22:40 ` Johnnynator
2021-02-05 22:48 ` Gottox
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Johnnynator @ 2021-02-05 22:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#issuecomment-774327004
Comment:
Did you verify that the tarball download is reproducable? Google likes to create them on the fly with different metadata and therefore it should result in a different checksum everytime. In that case just use the tarball of the file content.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (14 preceding siblings ...)
2021-02-05 22:40 ` Johnnynator
@ 2021-02-05 22:48 ` Gottox
2021-02-06 9:19 ` [PR PATCH] [Updated] " the-maldridge
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: Gottox @ 2021-02-05 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/28510#issuecomment-774329731
Comment:
@Johnnynator they aren't reproducable. thanks for the hint -.-'
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (15 preceding siblings ...)
2021-02-05 22:48 ` Gottox
@ 2021-02-06 9:19 ` the-maldridge
2021-02-06 9:21 ` the-maldridge
2021-02-06 9:33 ` [PR PATCH] [Merged]: " the-maldridge
18 siblings, 0 replies; 20+ messages in thread
From: the-maldridge @ 2021-02-06 9:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
There is an updated pull request by the-maldridge against master on the void-packages repository
https://github.com/the-maldridge/void-packages vboot-update
https://github.com/void-linux/void-packages/pull/28510
vboot-utils: Add update check
Adds an update check that parses the git revision. Also removes the need to keep track of a separate git hash. Resolves complaint surfaced in #28507, but does not actually update the package as I have no time nor resources to test the functionality of this package.
A patch file from https://github.com/void-linux/void-packages/pull/28510.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vboot-update-28510.patch --]
[-- Type: text/x-diff, Size: 1302 bytes --]
From 168ea91b3b5b12f618b22502fe7b6286c94ea5f3 Mon Sep 17 00:00:00 2001
From: Michael Aldridge <maldridge@VoidLinux.org>
Date: Fri, 5 Feb 2021 00:56:53 -0800
Subject: [PATCH] vboot-utils: Add update check
---
srcpkgs/vboot-utils/template | 2 +-
srcpkgs/vboot-utils/update | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/vboot-utils/update
diff --git a/srcpkgs/vboot-utils/template b/srcpkgs/vboot-utils/template
index 46871f18f25..61068975964 100644
--- a/srcpkgs/vboot-utils/template
+++ b/srcpkgs/vboot-utils/template
@@ -8,7 +8,7 @@ hostmakedepends="pkg-config git"
makedepends="libressl-devel libuuid-devel liblzma-devel libyaml-devel"
short_desc="Verified boot kernel utilities"
maintainer="Enno Boland <gottox@voidlinux.org>"
-license="BSD"
+license="BSD-3-Clause"
homepage="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git"
CFLAGS='-D_GNU_SOURCE -Wno-error -fcommon'
diff --git a/srcpkgs/vboot-utils/update b/srcpkgs/vboot-utils/update
new file mode 100644
index 00000000000..e360ec80b5c
--- /dev/null
+++ b/srcpkgs/vboot-utils/update
@@ -0,0 +1,3 @@
+site="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git/+refs?format=TEXT"
+pattern='refs/heads/release-R\K[\d]+-[\d]+'
+version=${version//./-}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (16 preceding siblings ...)
2021-02-06 9:19 ` [PR PATCH] [Updated] " the-maldridge
@ 2021-02-06 9:21 ` the-maldridge
2021-02-06 9:33 ` [PR PATCH] [Merged]: " the-maldridge
18 siblings, 0 replies; 20+ messages in thread
From: the-maldridge @ 2021-02-06 9:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
There is an updated pull request by the-maldridge against master on the void-packages repository
https://github.com/the-maldridge/void-packages vboot-update
https://github.com/void-linux/void-packages/pull/28510
vboot-utils: Add update check
Adds an update check that parses the git revision. Also removes the need to keep track of a separate git hash. Resolves complaint surfaced in #28507, but does not actually update the package as I have no time nor resources to test the functionality of this package.
A patch file from https://github.com/void-linux/void-packages/pull/28510.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vboot-update-28510.patch --]
[-- Type: text/x-diff, Size: 1302 bytes --]
From 2b6e95ac2cb5410ea4a0c756669e1e70e4eb9ccd Mon Sep 17 00:00:00 2001
From: Michael Aldridge <maldridge@VoidLinux.org>
Date: Fri, 5 Feb 2021 00:56:53 -0800
Subject: [PATCH] vboot-utils: Add update check
---
srcpkgs/vboot-utils/template | 2 +-
srcpkgs/vboot-utils/update | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/vboot-utils/update
diff --git a/srcpkgs/vboot-utils/template b/srcpkgs/vboot-utils/template
index 46871f18f25..61068975964 100644
--- a/srcpkgs/vboot-utils/template
+++ b/srcpkgs/vboot-utils/template
@@ -8,7 +8,7 @@ hostmakedepends="pkg-config git"
makedepends="libressl-devel libuuid-devel liblzma-devel libyaml-devel"
short_desc="Verified boot kernel utilities"
maintainer="Enno Boland <gottox@voidlinux.org>"
-license="BSD"
+license="BSD-3-Clause"
homepage="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git"
CFLAGS='-D_GNU_SOURCE -Wno-error -fcommon'
diff --git a/srcpkgs/vboot-utils/update b/srcpkgs/vboot-utils/update
new file mode 100644
index 00000000000..e360ec80b5c
--- /dev/null
+++ b/srcpkgs/vboot-utils/update
@@ -0,0 +1,3 @@
+site="https://chromium.googlesource.com/chromiumos/platform/vboot_reference.git/+refs?format=TEXT"
+pattern='refs/heads/release-R\K[\d]+-[\d]+'
+version=${version//./-}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Merged]: vboot-utils: Add update check
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
` (17 preceding siblings ...)
2021-02-06 9:21 ` the-maldridge
@ 2021-02-06 9:33 ` the-maldridge
18 siblings, 0 replies; 20+ messages in thread
From: the-maldridge @ 2021-02-06 9:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
There's a merged pull request on the void-packages repository
vboot-utils: Add update check
https://github.com/void-linux/void-packages/pull/28510
Description:
Adds an update check that parses the git revision. Also removes the need to keep track of a separate git hash. Resolves complaint surfaced in #28507, but does not actually update the package as I have no time nor resources to test the functionality of this package.
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2021-02-06 9:33 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 8:58 [PR PATCH] vboot-utils: Add update check the-maldridge
2021-02-05 9:02 ` [PR PATCH] [Updated] " the-maldridge
2021-02-05 10:16 ` [PR REVIEW] " Gottox
2021-02-05 10:17 ` Gottox
2021-02-05 11:26 ` fosslinux
2021-02-05 11:26 ` fosslinux
2021-02-05 13:33 ` ericonr
2021-02-05 16:44 ` Gottox
2021-02-05 16:45 ` Gottox
2021-02-05 16:47 ` Gottox
2021-02-05 17:02 ` Gottox
2021-02-05 17:40 ` [PR REVIEW] " ericonr
2021-02-05 17:45 ` Gottox
2021-02-05 22:23 ` fosslinux
2021-02-05 22:34 ` Gottox
2021-02-05 22:40 ` Johnnynator
2021-02-05 22:48 ` Gottox
2021-02-06 9:19 ` [PR PATCH] [Updated] " the-maldridge
2021-02-06 9:21 ` the-maldridge
2021-02-06 9:33 ` [PR PATCH] [Merged]: " the-maldridge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).