[ISSUE] firefox: firefox-wayland script doesn't set env variable correctly

[ISSUE] firefox: firefox-wayland script doesn't set env variable correctly

[666666t]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

New issue by 666666t on void-packages repository

https://github.com/void-linux/void-packages/issues/28715

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

- Package: firefox-85.0.1_1

### Expected behavior
- `firefox-wayland` command script is meant to set the `MOZ_ENABLE_WAYLAND=1` variable when calling firefox, to run as a native wayland program rather than under XWayland.

### Actual behavior
- Script does not specify the variable, instead containing the string `MOZ_ENABLE_WAYLAND=`, resulting in firefox still running under XWayland unless script is manually modified. 

### Steps to reproduce the behavior

`xbps-install -S firefox`
`firefox-wayland`

Re: firefox: firefox-wayland script doesn't set env variable correctly

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/issues/28715#issuecomment-778589436

Comment:
iirc it used to work, maybe the behavior changed

Re: firefox: firefox-wayland script doesn't set env variable correctly

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/issues/28715#issuecomment-778589436

Comment:
iirc it used to work, maybe the behavior changed. But yes, now only `MOZ_ENABLE_WAYLAND=1` works.

Re: firefox: firefox-wayland script doesn't set env variable correctly

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/28715#issuecomment-778625024

Comment:
It used to work, yeah. Feel free to open a PR, but I don't think it's worth rebuilding firefox for it... So probably best to just leave the change there so it's picked up next update / revbump.

Re: firefox: firefox-wayland script doesn't set env variable correctly

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/28715#issuecomment-787120064

Comment:
Will be fixed in #29097

Re: [ISSUE] [CLOSED] firefox: firefox-wayland script doesn't set env variable correctly

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Closed issue by 666666t on void-packages repository

https://github.com/void-linux/void-packages/issues/28715

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

- Package: firefox-85.0.1_1

### Expected behavior
- [`firefox-wayland`](https://github.com/void-linux/void-packages/blob/master/srcpkgs/firefox/files/firefox-wayland) command script is (presumably) meant to set the `MOZ_ENABLE_WAYLAND=1` variable when calling firefox, to run as a native wayland program rather than under XWayland.

### Actual behavior
- Script does not specify the variable, instead containing the string `MOZ_ENABLE_WAYLAND=`, resulting in firefox still running under XWayland unless script is manually modified. 

### Steps to reproduce the behavior

`xbps-install -S firefox`
`firefox-wayland`

Re: firefox: firefox-wayland script doesn't set env variable correctly

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/issues/28715#issuecomment-787150622

Comment:
it has beed argued about some time ago to even drop that wrapper script and let wayland users deal with their env on their own

Re: firefox: firefox-wayland script doesn't set env variable correctly

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/28715#issuecomment-787150782

Comment:
@Piraty we ended up not adding it to thunderbird for this reason, but now that it's there I think it's okay to keep shipping for firefox...