Github messages for voidlinux
 help / color / mirror / Atom feed
From: tibequadorian <tibequadorian@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] newsboat: update to 2.22.1.
Date: Tue, 16 Feb 2021 23:09:18 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28801@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages newsboat
https://github.com/void-linux/void-packages/pull/28801

newsboat: update to 2.22.1.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Tests fail on CI because they're run as superuser. I ran them locally and it worked fine.
Changed check target to `ci-check` which was introduced in 2.22 to run C++ *and* Rust tests.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-28801.patch --]
[-- Type: text/x-diff, Size: 1505 bytes --]

From bfaf78e1667ea4f5446b7905edaf40ec086636d4 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 11 Jan 2021 12:08:45 +0100
Subject: [PATCH] newsboat: update to 2.22.1.

---
 srcpkgs/newsboat/template | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e0ebdeeea50..930285d6e28 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,11 +1,12 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.21
+version=2.22.1
 revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
 make_install_args="prefix=/usr"
+make_check_target="ci-check"
 hostmakedepends="ruby-asciidoctor pkg-config cargo git gettext"
 makedepends="json-c-devel libcurl-devel libxml2-devel sqlite-devel stfl-devel
  rust-std"
@@ -16,11 +17,13 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
+checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
 
-do_check() {
-	make test
-	(cd test && TERM=$TERM TMPDIR=/dev/shm ./test)
+# tests fail when run by superuser
+make_check=extended
+
+post_patch() {
+	vsed -i Makefile -e "s|\./test|TERM=$TERM TMPDIR=/dev/shm \./test|g"
 }
 
 post_install() {

             reply	other threads:[~2021-02-16 22:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 22:09 tibequadorian [this message]
2021-02-16 22:13 ` [PR REVIEW] " ericonr
2021-02-16 22:24 ` tibequadorian
2021-02-16 22:35 ` ericonr
2021-02-16 22:36 ` [PR PATCH] [Updated] " tibequadorian
2021-02-17 14:49 ` ericonr
2021-02-17 19:46 ` Minoru
2021-02-17 19:49 ` [PR REVIEW] " Minoru
2021-02-17 20:17 ` ericonr
2021-02-17 23:23 ` [PR PATCH] [Updated] " tibequadorian
2021-02-17 23:29 ` tibequadorian
2021-02-17 23:29 ` tibequadorian
2021-02-18  1:06 ` ericonr
2021-02-18  1:06 ` ericonr
2021-02-18  1:10 ` [PR PATCH] [Updated] " tibequadorian
2021-02-18  1:10 ` tibequadorian
2021-02-18  1:14 ` tibequadorian
2021-02-18  1:16 ` tibequadorian
2021-02-18  1:17 ` tibequadorian
2021-02-18  2:51 ` [PR PATCH] [Merged]: " ericonr
  -- strict thread matches above, loose matches on Subject: below --
2021-01-13 20:57 [PR PATCH] " subsonik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28801@inbox.vuxu.org \
    --to=tibequadorian@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).