From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: newsboat: update to 2.22.1.
Date: Wed, 17 Feb 2021 21:17:07 +0100 [thread overview]
Message-ID: <20210217201707.1p53K1m75oJOML5UzO9SPygFFe_j10DpAjcfzfwPHOc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28801@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28801#issuecomment-780826083
Comment:
I prefer
```
diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index e1a4429a62..7960b5d411 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -22,8 +22,8 @@ checksum=8920f41cc53776b67c0e85ad1696b0967f6ac248f3b8913d977942c15d75e690
# tests fail when run by superuser
make_check=extended
-post_patch() {
- vsed -i Makefile -e "s|\./test|TERM=$TERM \./test|g"
+pre_check() {
+ export TERM=xterm
}
post_install() {
```
instead of `vsed`. Also add a comment about the tests failing on musl with a link to the issue.
next prev parent reply other threads:[~2021-02-17 20:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 22:09 [PR PATCH] " tibequadorian
2021-02-16 22:13 ` [PR REVIEW] " ericonr
2021-02-16 22:24 ` tibequadorian
2021-02-16 22:35 ` ericonr
2021-02-16 22:36 ` [PR PATCH] [Updated] " tibequadorian
2021-02-17 14:49 ` ericonr
2021-02-17 19:46 ` Minoru
2021-02-17 19:49 ` [PR REVIEW] " Minoru
2021-02-17 20:17 ` ericonr [this message]
2021-02-17 23:23 ` [PR PATCH] [Updated] " tibequadorian
2021-02-17 23:29 ` tibequadorian
2021-02-17 23:29 ` tibequadorian
2021-02-18 1:06 ` ericonr
2021-02-18 1:06 ` ericonr
2021-02-18 1:10 ` [PR PATCH] [Updated] " tibequadorian
2021-02-18 1:10 ` tibequadorian
2021-02-18 1:14 ` tibequadorian
2021-02-18 1:16 ` tibequadorian
2021-02-18 1:17 ` tibequadorian
2021-02-18 2:51 ` [PR PATCH] [Merged]: " ericonr
-- strict thread matches above, loose matches on Subject: below --
2021-01-13 20:57 [PR PATCH] " subsonik
2021-01-13 21:28 ` Minoru
2021-01-13 22:01 ` subsonik
2021-01-20 0:19 ` ericonr
2021-01-20 2:03 ` tibequadorian
2021-01-20 2:03 ` tibequadorian
2021-01-20 2:04 ` tibequadorian
2021-01-20 2:06 ` tibequadorian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217201707.1p53K1m75oJOML5UzO9SPygFFe_j10DpAjcfzfwPHOc@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).