[PR PATCH] detox: update to 1.4.0.

[PR PATCH] detox: update to 1.4.0.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

There is a new pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages detox140
https://github.com/void-linux/void-packages/pull/28889

detox: update to 1.4.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28889.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-detox140-28889.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From 0dc26300412c40626502c487635caa1b3ae0c3a9 Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Fri, 19 Feb 2021 21:04:06 +0100
Subject: [PATCH] detox: update to 1.4.0.

---
 srcpkgs/detox/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/detox/template b/srcpkgs/detox/template
index 6d02ea19904..1599e658866 100644
--- a/srcpkgs/detox/template
+++ b/srcpkgs/detox/template
@@ -1,6 +1,6 @@
 # Template file for 'detox'
 pkgname=detox
-version=1.3.3
+version=1.4.0
 revision=1
 build_style=gnu-configure
 configure_args="--sysconfdir=/etc/detox"
@@ -11,7 +11,7 @@ maintainer="Martin Födinger <foedinger.martin@autistici.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/dharple/detox"
 distfiles="https://github.com/dharple/detox/archive/v${version}.tar.gz"
-checksum=d57b6b8909046e66e2d992c126aba59c350d8aebfae55937397ef0b88abb4ae0
+checksum=9d201e4bf135e708e39bf4f46cfb2b8ce4ac6ceed54a2d87d30cca48b78af2a8
 
 pre_configure() {
 	autoreconf --install

Re: detox: update to 1.4.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28889#issuecomment-782504603

Comment:
This looks ok, but we have a patch for supposed "invalid memory access" which I really think should be sent upstream...

Re: detox: update to 1.4.0.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by UsernameRandomlyGenerated on void-packages repository

https://github.com/void-linux/void-packages/pull/28889#issuecomment-782596539

Comment:
Yeah, without the patch it segfaults when you throw more than 10 files at once, I created an issue about it on github and mentioned the patch.

Re: [PR PATCH] [Updated] detox: update to 1.4.0.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages detox140
https://github.com/void-linux/void-packages/pull/28889

detox: update to 1.4.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28889.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-detox140-28889.patch --]
[-- Type: text/x-diff, Size: 2213 bytes --]

From def688287704c0e945fd3269bce12353cbed996f Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Fri, 19 Feb 2021 21:04:06 +0100
Subject: [PATCH] detox: update to 1.4.1.

---
 ...etox-1.2.0.fix-invalid-memory-access.patch | 23 -------------------
 srcpkgs/detox/template                        |  4 ++--
 2 files changed, 2 insertions(+), 25 deletions(-)
 delete mode 100644 srcpkgs/detox/patches/detox-1.2.0.fix-invalid-memory-access.patch

diff --git a/srcpkgs/detox/patches/detox-1.2.0.fix-invalid-memory-access.patch b/srcpkgs/detox/patches/detox-1.2.0.fix-invalid-memory-access.patch
deleted file mode 100644
index df6f7f8a82f..00000000000
--- a/srcpkgs/detox/patches/detox-1.2.0.fix-invalid-memory-access.patch
+++ /dev/null
@@ -1,23 +0,0 @@
---- src/parse_options.c.dt
-+++ src/parse_options.c
-@@ -178,15 +178,17 @@ struct detox_options *parse_options_geto
- 	main_options->files = malloc(sizeof(char *) * 10);
- 
- 	i = 0;
--	max = 0;
-+	max = 10;
- 
- 	if (optind < argc) {
- 		while (optind < argc) {
--			main_options->files[i++] = strdup(argv[optind]);
--			if (i > max) {
-+                        /* not enough space for the next file and
-+                           possible ending NULL -> realloc */
-+			if (i + 2 > max) {
- 				main_options->files = realloc(main_options->files, sizeof(char *) * (10 + max));
- 				max += 10;
- 			}
-+			main_options->files[i++] = strdup(argv[optind]);
- 
- 			optind++;
- 		}
diff --git a/srcpkgs/detox/template b/srcpkgs/detox/template
index 6d02ea19904..dd21cdc3627 100644
--- a/srcpkgs/detox/template
+++ b/srcpkgs/detox/template
@@ -1,6 +1,6 @@
 # Template file for 'detox'
 pkgname=detox
-version=1.3.3
+version=1.4.1
 revision=1
 build_style=gnu-configure
 configure_args="--sysconfdir=/etc/detox"
@@ -11,7 +11,7 @@ maintainer="Martin Födinger <foedinger.martin@autistici.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/dharple/detox"
 distfiles="https://github.com/dharple/detox/archive/v${version}.tar.gz"
-checksum=d57b6b8909046e66e2d992c126aba59c350d8aebfae55937397ef0b88abb4ae0
+checksum=fd71aa31abc82b1ec8b7ce996cd70062939e9c165b106f395beced3706c5ea17
 
 pre_configure() {
 	autoreconf --install

Re: detox: update to 1.4.1.

[UsernameRandomlyGenerated]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by UsernameRandomlyGenerated on void-packages repository

https://github.com/void-linux/void-packages/pull/28889#issuecomment-782732939

Comment:
I repushed 1.4.1 in which the bug is fixed.

Re: [PR PATCH] [Merged]: detox: update to 1.4.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]

There's a merged pull request on the void-packages repository

detox: update to 1.4.1.
https://github.com/void-linux/void-packages/pull/28889

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->