* [PR PATCH] Fix typo pupper -> puppet
@ 2021-02-23 20:30 cryptarch
2021-02-23 20:34 ` the-maldridge
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: cryptarch @ 2021-02-23 20:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]
There is a new pull request by cryptarch against master on the void-packages repository
https://github.com/cryptarch/void-packages master
https://github.com/void-linux/void-packages/pull/29011
Fix typo pupper -> puppet
The current runit file for the puppetmaster service asserts a misnamed group, resulting in an error. This pull request fixes the issue.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [X ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29011.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29011.patch --]
[-- Type: text/x-diff, Size: 686 bytes --]
From 2ee65818afe51ce72579f82406cb0959367a0da3 Mon Sep 17 00:00:00 2001
From: cryptarch <timothy.rice@unimelb.edu.au>
Date: Wed, 24 Feb 2021 07:26:49 +1100
Subject: [PATCH] Fix typo pupper -> puppet
---
srcpkgs/puppet/files/puppetmaster/run | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/puppet/files/puppetmaster/run b/srcpkgs/puppet/files/puppetmaster/run
index ca850d28ca0..3bfb340ab5b 100644
--- a/srcpkgs/puppet/files/puppetmaster/run
+++ b/srcpkgs/puppet/files/puppetmaster/run
@@ -1,4 +1,4 @@
#!/bin/sh
set -e
-install -d -m0755 -o puppet -g pupper /run/puppet
+install -d -m0755 -o puppet -g puppet /run/puppet
exec puppet master --no-daemonize
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Fix typo pupper -> puppet
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
@ 2021-02-23 20:34 ` the-maldridge
2021-02-23 20:39 ` [PR PATCH] [Updated] " cryptarch
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: the-maldridge @ 2021-02-23 20:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/29011#issuecomment-784492982
Comment:
You also need to bump the revision number so the package will be rebuilt.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] Fix typo pupper -> puppet
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
2021-02-23 20:34 ` the-maldridge
@ 2021-02-23 20:39 ` cryptarch
2021-02-23 20:45 ` the-maldridge
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cryptarch @ 2021-02-23 20:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
There is an updated pull request by cryptarch against master on the void-packages repository
https://github.com/cryptarch/void-packages master
https://github.com/void-linux/void-packages/pull/29011
Fix typo pupper -> puppet
The current runit file for the puppetmaster service asserts a misnamed group, resulting in an error. This pull request fixes the issue.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [X ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29011.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-29011.patch --]
[-- Type: text/x-diff, Size: 1338 bytes --]
From 2ee65818afe51ce72579f82406cb0959367a0da3 Mon Sep 17 00:00:00 2001
From: cryptarch <timothy.rice@unimelb.edu.au>
Date: Wed, 24 Feb 2021 07:26:49 +1100
Subject: [PATCH 1/2] Fix typo pupper -> puppet
---
srcpkgs/puppet/files/puppetmaster/run | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/puppet/files/puppetmaster/run b/srcpkgs/puppet/files/puppetmaster/run
index ca850d28ca0..3bfb340ab5b 100644
--- a/srcpkgs/puppet/files/puppetmaster/run
+++ b/srcpkgs/puppet/files/puppetmaster/run
@@ -1,4 +1,4 @@
#!/bin/sh
set -e
-install -d -m0755 -o puppet -g pupper /run/puppet
+install -d -m0755 -o puppet -g puppet /run/puppet
exec puppet master --no-daemonize
From 983152bf961fc45ae8a563114b8d423b4046ccb9 Mon Sep 17 00:00:00 2001
From: cryptarch <timothy.rice@unimelb.edu.au>
Date: Wed, 24 Feb 2021 07:39:17 +1100
Subject: [PATCH 2/2] Bump revision number
---
srcpkgs/puppet/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/puppet/template b/srcpkgs/puppet/template
index 1ef964745cf..d59c43a5f06 100644
--- a/srcpkgs/puppet/template
+++ b/srcpkgs/puppet/template
@@ -1,7 +1,7 @@
# Template file for 'puppet'
pkgname=puppet
version=6.16.0
-revision=2
+revision=3
build_style=ruby-module
hostmakedepends="ruby facter-devel hiera which"
makedepends="facter-devel"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Fix typo pupper -> puppet
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
2021-02-23 20:34 ` the-maldridge
2021-02-23 20:39 ` [PR PATCH] [Updated] " cryptarch
@ 2021-02-23 20:45 ` the-maldridge
2021-02-23 20:53 ` cryptarch
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: the-maldridge @ 2021-02-23 20:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/29011#issuecomment-784499683
Comment:
Looks good. Just need to squash and match your commit to [the standard format](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes).
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Fix typo pupper -> puppet
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
` (2 preceding siblings ...)
2021-02-23 20:45 ` the-maldridge
@ 2021-02-23 20:53 ` cryptarch
2021-02-23 20:55 ` the-maldridge
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cryptarch @ 2021-02-23 20:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
New comment by cryptarch on void-packages repository
https://github.com/void-linux/void-packages/pull/29011#issuecomment-784504813
Comment:
@the-maldridge Thanks. Maybe I should start the PR from scratch? Doesn't look like GitHub can automatically squash. Sorry for the hassle, I should have checked the contributing file before rushing in.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Fix typo pupper -> puppet
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
` (3 preceding siblings ...)
2021-02-23 20:53 ` cryptarch
@ 2021-02-23 20:55 ` the-maldridge
2021-02-23 20:55 ` cryptarch
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: the-maldridge @ 2021-02-23 20:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/29011#issuecomment-784505504
Comment:
I can squash and rewrite in the merge if you're okay with that. It may change authorship information.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Fix typo pupper -> puppet
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
` (4 preceding siblings ...)
2021-02-23 20:55 ` the-maldridge
@ 2021-02-23 20:55 ` cryptarch
2021-02-23 20:58 ` the-maldridge
2021-02-23 20:58 ` [PR PATCH] [Closed]: " the-maldridge
7 siblings, 0 replies; 9+ messages in thread
From: cryptarch @ 2021-02-23 20:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 161 bytes --]
New comment by cryptarch on void-packages repository
https://github.com/void-linux/void-packages/pull/29011#issuecomment-784505763
Comment:
Yeah, go for it :)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Fix typo pupper -> puppet
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
` (5 preceding siblings ...)
2021-02-23 20:55 ` cryptarch
@ 2021-02-23 20:58 ` the-maldridge
2021-02-23 20:58 ` [PR PATCH] [Closed]: " the-maldridge
7 siblings, 0 replies; 9+ messages in thread
From: the-maldridge @ 2021-02-23 20:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/29011#issuecomment-784508350
Comment:
merged as 878f72c87d
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Closed]: Fix typo pupper -> puppet
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
` (6 preceding siblings ...)
2021-02-23 20:58 ` the-maldridge
@ 2021-02-23 20:58 ` the-maldridge
7 siblings, 0 replies; 9+ messages in thread
From: the-maldridge @ 2021-02-23 20:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]
There's a closed pull request on the void-packages repository
Fix typo pupper -> puppet
https://github.com/void-linux/void-packages/pull/29011
Description:
The current runit file for the puppetmaster service asserts a misnamed group, resulting in an error. This pull request fixes the issue.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [X ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-02-23 20:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 20:30 [PR PATCH] Fix typo pupper -> puppet cryptarch
2021-02-23 20:34 ` the-maldridge
2021-02-23 20:39 ` [PR PATCH] [Updated] " cryptarch
2021-02-23 20:45 ` the-maldridge
2021-02-23 20:53 ` cryptarch
2021-02-23 20:55 ` the-maldridge
2021-02-23 20:55 ` cryptarch
2021-02-23 20:58 ` the-maldridge
2021-02-23 20:58 ` [PR PATCH] [Closed]: " the-maldridge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).