Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] owncloudclient: fix #29107
@ 2021-02-28 20:45 gt7-void
  2021-02-28 20:47 ` ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: gt7-void @ 2021-02-28 20:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

There is a new pull request by gt7-void against master on the void-packages repository

https://github.com/gt7-void/void-packages owncloudclient
https://github.com/void-linux/void-packages/pull/29136

owncloudclient: fix #29107
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29136.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-owncloudclient-29136.patch --]
[-- Type: text/x-diff, Size: 1127 bytes --]

From b3bf483efe818604fc0d68a80d88c783a99f2ea2 Mon Sep 17 00:00:00 2001
From: gt7-void <gt7@mail.com>
Date: Sun, 28 Feb 2021 17:32:27 -0300
Subject: [PATCH] owncloudclient: fix #29107

---
 srcpkgs/owncloudclient/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/owncloudclient/template b/srcpkgs/owncloudclient/template
index 50e6a6de420..a4f847a28fb 100644
--- a/srcpkgs/owncloudclient/template
+++ b/srcpkgs/owncloudclient/template
@@ -1,7 +1,7 @@
 # Template file for 'owncloudclient'
 pkgname=owncloudclient
 version=2.7.1
-revision=1
+revision=2
 wrksrc=client-${version}
 build_style=cmake
 configure_args="-Wno-dev -DNO_SHIBBOLETH=TRUE"
@@ -9,7 +9,7 @@ hostmakedepends="pkg-config extra-cmake-modules"
 makedepends="qtkeychain-qt5-devel sqlite-devel qt5-declarative-devel
  qt5-tools-devel qt5-plugin-odbc qt5-plugin-tds qt5-plugin-pgsql qt5-plugin-mysql
  qt5-plugin-sqlite"
-depends="qt5-plugin-sqlite"
+depends="qt5-plugin-sqlite qt5-svg"
 conf_files="/etc/ownCloud/sync-exclude.lst"
 short_desc="Connect to ownCloud servers"
 maintainer="Nathan Owens <ndowens@artixlinux.org>"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: owncloudclient: fix #29107
  2021-02-28 20:45 [PR PATCH] owncloudclient: fix #29107 gt7-void
@ 2021-02-28 20:47 ` ericonr
  2021-02-28 21:07 ` [PR PATCH] [Updated] " gt7-void
  2021-03-08  3:46 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-02-28 20:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29136#issuecomment-787520270

Comment:
Please explain the issue in the commit message, otherwise looking at git history depends on going back to GitHub issues.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] owncloudclient: fix #29107
  2021-02-28 20:45 [PR PATCH] owncloudclient: fix #29107 gt7-void
  2021-02-28 20:47 ` ericonr
@ 2021-02-28 21:07 ` gt7-void
  2021-03-08  3:46 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: gt7-void @ 2021-02-28 21:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is an updated pull request by gt7-void against master on the void-packages repository

https://github.com/gt7-void/void-packages owncloudclient
https://github.com/void-linux/void-packages/pull/29136

owncloudclient: fix #29107
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29136.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-owncloudclient-29136.patch --]
[-- Type: text/x-diff, Size: 1244 bytes --]

From 9ad5a185115928eb3b0c0b229f9af3e88fa64c75 Mon Sep 17 00:00:00 2001
From: gt7-void <gt7@mail.com>
Date: Sun, 28 Feb 2021 17:32:27 -0300
Subject: [PATCH] owncloudclient: fix #29107

Make it depend on `qt5-svg`, since it's not implied by shlib-requires.
When not installed, icons won't be displayed.
---
 srcpkgs/owncloudclient/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/owncloudclient/template b/srcpkgs/owncloudclient/template
index 50e6a6de420..a4f847a28fb 100644
--- a/srcpkgs/owncloudclient/template
+++ b/srcpkgs/owncloudclient/template
@@ -1,7 +1,7 @@
 # Template file for 'owncloudclient'
 pkgname=owncloudclient
 version=2.7.1
-revision=1
+revision=2
 wrksrc=client-${version}
 build_style=cmake
 configure_args="-Wno-dev -DNO_SHIBBOLETH=TRUE"
@@ -9,7 +9,7 @@ hostmakedepends="pkg-config extra-cmake-modules"
 makedepends="qtkeychain-qt5-devel sqlite-devel qt5-declarative-devel
  qt5-tools-devel qt5-plugin-odbc qt5-plugin-tds qt5-plugin-pgsql qt5-plugin-mysql
  qt5-plugin-sqlite"
-depends="qt5-plugin-sqlite"
+depends="qt5-plugin-sqlite qt5-svg"
 conf_files="/etc/ownCloud/sync-exclude.lst"
 short_desc="Connect to ownCloud servers"
 maintainer="Nathan Owens <ndowens@artixlinux.org>"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: owncloudclient: fix #29107
  2021-02-28 20:45 [PR PATCH] owncloudclient: fix #29107 gt7-void
  2021-02-28 20:47 ` ericonr
  2021-02-28 21:07 ` [PR PATCH] [Updated] " gt7-void
@ 2021-03-08  3:46 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-03-08  3:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

There's a merged pull request on the void-packages repository

owncloudclient: fix #29107
https://github.com/void-linux/void-packages/pull/29136

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-08  3:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-28 20:45 [PR PATCH] owncloudclient: fix #29107 gt7-void
2021-02-28 20:47 ` ericonr
2021-02-28 21:07 ` [PR PATCH] [Updated] " gt7-void
2021-03-08  3:46 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).