Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] spotify-qt: update to 3.5.
@ 2021-03-12 21:57 abenson
  2021-03-14 22:19 ` [PR PATCH] [Merged]: " abenson
  0 siblings, 1 reply; 2+ messages in thread
From: abenson @ 2021-03-12 21:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

There is a new pull request by abenson against master on the void-packages repository

https://github.com/abenson/void-packages spotqt_3.5
https://github.com/void-linux/void-packages/pull/29423

spotify-qt: update to 3.5.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29423.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotqt_3.5-29423.patch --]
[-- Type: text/x-diff, Size: 2261 bytes --]

From 5c84f6a6c63eda2f4114493c4b635c72ff1ead33 Mon Sep 17 00:00:00 2001
From: Andrew Benson <abenson@gmail.com>
Date: Fri, 12 Mar 2021 14:55:51 -0700
Subject: [PATCH] spotify-qt: update to 3.5.

---
 .../patches/fix-darkmode-toggle.patch         | 26 -------------------
 srcpkgs/spotify-qt/template                   |  4 +--
 2 files changed, 2 insertions(+), 28 deletions(-)
 delete mode 100644 srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch

diff --git a/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch b/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
deleted file mode 100644
index dd63a2d4a45..00000000000
--- a/srcpkgs/spotify-qt/patches/fix-darkmode-toggle.patch
+++ /dev/null
@@ -1,26 +0,0 @@
-https://github.com/kraxarn/spotify-qt/commit/fe916f8976cca3983030e24d02d65e62893ad88d.patch
-
-From fe916f8976cca3983030e24d02d65e62893ad88d Mon Sep 17 00:00:00 2001
-From: kraxarn <me@kraxarn.com>
-Date: Sun, 7 Feb 2021 22:02:21 +0100
-Subject: [PATCH] Fix crash when toggling dark theme
-
----
- src/settingspage/interfacepage.cpp | 4 +++-
- 1 file changed, 3 insertions(+), 1 deletion(-)
-
-diff --git src/settingspage/interfacepage.cpp src/settingspage/interfacepage.cpp
-index d809730..be16455 100644
---- src/settingspage/interfacepage.cpp
-+++ src/settingspage/interfacepage.cpp
-@@ -215,7 +215,9 @@ void InterfacePage::darkThemeToggle(bool checked)
- 	if (checked)
- 	{
- 		itfStyle->setCurrentText("Fusion");
--		itfIcFallback->setChecked(true);
-+
-+		if (itfIcFallback != nullptr)
-+			itfIcFallback->setChecked(true);
- 	}
- 	else
- 	{
diff --git a/srcpkgs/spotify-qt/template b/srcpkgs/spotify-qt/template
index ce964a0b71a..a2aa3922674 100644
--- a/srcpkgs/spotify-qt/template
+++ b/srcpkgs/spotify-qt/template
@@ -1,6 +1,6 @@
 # Template file for 'spotify-qt'
 pkgname=spotify-qt
-version=3.4
+version=3.5
 revision=1
 build_style=cmake
 hostmakedepends="pkg-config qt5-devel"
@@ -10,4 +10,4 @@ maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/kraxarn/spotify-qt"
 distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=ceae5dec3aa31a3fbf6754a2c481dfc1b32b9f5e131007ec176f64a87a6e516e
+checksum=b8c4827a6c3e012b897f0a87ef2cc6e04b2d97f14bc505d19ebd439464094b4e

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: spotify-qt: update to 3.5.
  2021-03-12 21:57 [PR PATCH] spotify-qt: update to 3.5 abenson
@ 2021-03-14 22:19 ` abenson
  0 siblings, 0 replies; 2+ messages in thread
From: abenson @ 2021-03-14 22:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

There's a merged pull request on the void-packages repository

spotify-qt: update to 3.5.
https://github.com/void-linux/void-packages/pull/29423

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-14 22:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 21:57 [PR PATCH] spotify-qt: update to 3.5 abenson
2021-03-14 22:19 ` [PR PATCH] [Merged]: " abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).