* Re: [PR REVIEW] Fix: create /etc/target{,/backup} dirs
2021-03-15 15:01 [PR PATCH] Fix: create /etc/target{,/backup} dirs jirib
@ 2021-03-15 15:03 ` ericonr
2021-03-15 15:09 ` [PR PATCH] [Updated] " jirib
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-03-15 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29487#discussion_r594415898
Comment:
This should be indented with spaces.
Commit message should be `targetcli-fb: create /etc/target...`
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Updated] Fix: create /etc/target{,/backup} dirs
2021-03-15 15:01 [PR PATCH] Fix: create /etc/target{,/backup} dirs jirib
2021-03-15 15:03 ` [PR REVIEW] " ericonr
@ 2021-03-15 15:09 ` jirib
2021-03-15 15:09 ` [PR REVIEW] " jirib
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jirib @ 2021-03-15 15:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
There is an updated pull request by jirib against master on the void-packages repository
https://github.com/jirib/void-packages targetcli-fb
https://github.com/void-linux/void-packages/pull/29487
Fix: create /etc/target{,/backup} dirs
Solves #29486.
A patch file from https://github.com/void-linux/void-packages/pull/29487.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-targetcli-fb-29487.patch --]
[-- Type: text/x-diff, Size: 1127 bytes --]
From 9f2cba40130202dc8937d39e8454a6c0d532b1c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ji=C5=99=C3=AD=20B=C4=9Blka?= <jirib79@gmail.com>
Date: Mon, 15 Mar 2021 16:00:22 +0100
Subject: [PATCH] targetcli-fb: create /etc/target{,/backup} dirs
---
srcpkgs/targetcli-fb/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/targetcli-fb/template b/srcpkgs/targetcli-fb/template
index 70ff44b77c15..a979383fd7df 100644
--- a/srcpkgs/targetcli-fb/template
+++ b/srcpkgs/targetcli-fb/template
@@ -1,7 +1,7 @@
# Template file for 'targetcli-fb'
pkgname=targetcli-fb
version=2.1.51
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="configshell-fb python3-six rtslib-fb python3-parsing python3-gobject"
@@ -12,3 +12,6 @@ license="Apache-2.0"
homepage="https://github.com/open-iscsi/targetcli-fb"
distfiles="https://github.com/open-iscsi/targetcli-fb/archive/v${version}.tar.gz"
checksum=7ebf340705b6fb407aadc437202074ca490116ef811e3b0b7306d57d6c065366
+make_dirs="
+ /etc/target 0755 root root
+ /etc/target/backup 0755 root root"
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR REVIEW] Fix: create /etc/target{,/backup} dirs
2021-03-15 15:01 [PR PATCH] Fix: create /etc/target{,/backup} dirs jirib
2021-03-15 15:03 ` [PR REVIEW] " ericonr
2021-03-15 15:09 ` [PR PATCH] [Updated] " jirib
@ 2021-03-15 15:09 ` jirib
2021-03-15 15:17 ` jirib
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jirib @ 2021-03-15 15:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
New review comment by jirib on void-packages repository
https://github.com/void-linux/void-packages/pull/29487#discussion_r594421025
Comment:
Thx.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR REVIEW] Fix: create /etc/target{,/backup} dirs
2021-03-15 15:01 [PR PATCH] Fix: create /etc/target{,/backup} dirs jirib
` (2 preceding siblings ...)
2021-03-15 15:09 ` [PR REVIEW] " jirib
@ 2021-03-15 15:17 ` jirib
2021-03-15 15:18 ` [PR PATCH] [Updated] " jirib
2021-03-15 16:44 ` [PR PATCH] [Merged]: " ericonr
5 siblings, 0 replies; 7+ messages in thread
From: jirib @ 2021-03-15 15:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
New review comment by jirib on void-packages repository
https://github.com/void-linux/void-packages/pull/29487#discussion_r594427271
Comment:
> This should be indented with spaces.
>
> Commit message should be `targetcli-fb: create /etc/target...`
Oh, it just failed because it has to be indent with tags.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Updated] Fix: create /etc/target{,/backup} dirs
2021-03-15 15:01 [PR PATCH] Fix: create /etc/target{,/backup} dirs jirib
` (3 preceding siblings ...)
2021-03-15 15:17 ` jirib
@ 2021-03-15 15:18 ` jirib
2021-03-15 16:44 ` [PR PATCH] [Merged]: " ericonr
5 siblings, 0 replies; 7+ messages in thread
From: jirib @ 2021-03-15 15:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
There is an updated pull request by jirib against master on the void-packages repository
https://github.com/jirib/void-packages targetcli-fb
https://github.com/void-linux/void-packages/pull/29487
Fix: create /etc/target{,/backup} dirs
Solves #29486.
A patch file from https://github.com/void-linux/void-packages/pull/29487.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-targetcli-fb-29487.patch --]
[-- Type: text/x-diff, Size: 1113 bytes --]
From 074f44062d3990d780c852d020c5b646b0256a0d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ji=C5=99=C3=AD=20B=C4=9Blka?= <jirib79@gmail.com>
Date: Mon, 15 Mar 2021 16:00:22 +0100
Subject: [PATCH] targetcli-fb: create /etc/target{,/backup} dirs
---
srcpkgs/targetcli-fb/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/targetcli-fb/template b/srcpkgs/targetcli-fb/template
index 70ff44b77c15..3212f96f7e3f 100644
--- a/srcpkgs/targetcli-fb/template
+++ b/srcpkgs/targetcli-fb/template
@@ -1,7 +1,7 @@
# Template file for 'targetcli-fb'
pkgname=targetcli-fb
version=2.1.51
-revision=2
+revision=3
build_style=python3-module
hostmakedepends="python3-setuptools"
depends="configshell-fb python3-six rtslib-fb python3-parsing python3-gobject"
@@ -12,3 +12,6 @@ license="Apache-2.0"
homepage="https://github.com/open-iscsi/targetcli-fb"
distfiles="https://github.com/open-iscsi/targetcli-fb/archive/v${version}.tar.gz"
checksum=7ebf340705b6fb407aadc437202074ca490116ef811e3b0b7306d57d6c065366
+make_dirs="
+ /etc/target 0755 root root
+ /etc/target/backup 0755 root root"
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Merged]: Fix: create /etc/target{,/backup} dirs
2021-03-15 15:01 [PR PATCH] Fix: create /etc/target{,/backup} dirs jirib
` (4 preceding siblings ...)
2021-03-15 15:18 ` [PR PATCH] [Updated] " jirib
@ 2021-03-15 16:44 ` ericonr
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-03-15 16:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
There's a merged pull request on the void-packages repository
Fix: create /etc/target{,/backup} dirs
https://github.com/void-linux/void-packages/pull/29487
Description:
Solves #29486.
^ permalink raw reply [flat|nested] 7+ messages in thread