Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] binfmt-support: fix license, fix build
@ 2021-03-28  8:26 heliocat
  2021-03-28 16:00 ` ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: heliocat @ 2021-03-28  8:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

There is a new pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages binfmt-support
https://github.com/void-linux/void-packages/pull/29802

binfmt-support: fix license, fix build
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/29802.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-binfmt-support-29802.patch --]
[-- Type: text/x-diff, Size: 1242 bytes --]

From 95118a7b57378e552a402e79a46b31c10dbcde96 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Sun, 28 Mar 2021 01:23:07 -0700
Subject: [PATCH] binfmt-support: fix license, fix build

---
 srcpkgs/binfmt-support/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/binfmt-support/template b/srcpkgs/binfmt-support/template
index 4208b1969b05..878c506ea20e 100644
--- a/srcpkgs/binfmt-support/template
+++ b/srcpkgs/binfmt-support/template
@@ -1,13 +1,13 @@
 # Template file for 'binfmt-support'
 pkgname=binfmt-support
 version=2.2.1
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="pkg-config"
 makedepends="libpipeline-devel"
 short_desc="Register interpreters for various binary formats"
 maintainer="Andrea Brancaleoni <abc@pompel.me>"
-license="GPL-3"
+license="GPL-2.0-or-later"
 homepage="http://packages.debian.org/en/sid/binfmt-support"
 distfiles="${DEBIAN_SITE}/main/b/binfmt-support/binfmt-support_$version.orig.tar.gz"
 checksum=9c9da3306501a834663ccd14023fc8d29bd08a34df74585e11f97735ea1fb31d
@@ -15,5 +15,6 @@ make_dirs="/var/lib/binfmts 0755 root root"
 
 post_install() {
 	rm -r ${DESTDIR}/etc/init
+	rm -r ${DESTDIR}/lib
 	vsv binfmt-support
 }

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binfmt-support: fix license, fix build
  2021-03-28  8:26 [PR PATCH] binfmt-support: fix license, fix build heliocat
@ 2021-03-28 16:00 ` ericonr
  2021-03-28 16:29 ` heliocat
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-03-28 16:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29802#issuecomment-808916566

Comment:
Can you fix the commit message? It seems you removed the build fixes.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binfmt-support: fix license, fix build
  2021-03-28  8:26 [PR PATCH] binfmt-support: fix license, fix build heliocat
  2021-03-28 16:00 ` ericonr
@ 2021-03-28 16:29 ` heliocat
  2021-04-04 23:17 ` ericonr
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: heliocat @ 2021-03-28 16:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/29802#issuecomment-808920605

Comment:
@the-maldridge and I chatted about that in IRC. xbps-src in void-packages fails and CI passes without an explicit rm of ${DESTDIR}/lib, but xbps-src passes and CI fails if you explicitly remove it. I could change things to rm -rf instead to satisfy both sides but I don't like the non-determinism.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binfmt-support: fix license, fix build
  2021-03-28  8:26 [PR PATCH] binfmt-support: fix license, fix build heliocat
  2021-03-28 16:00 ` ericonr
  2021-03-28 16:29 ` heliocat
@ 2021-04-04 23:17 ` ericonr
  2021-04-07 19:20 ` [PR PATCH] [Updated] " heliocat
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-04-04 23:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29802#issuecomment-813114745

Comment:
I will try to investigate this later.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] binfmt-support: fix license, fix build
  2021-03-28  8:26 [PR PATCH] binfmt-support: fix license, fix build heliocat
                   ` (2 preceding siblings ...)
  2021-04-04 23:17 ` ericonr
@ 2021-04-07 19:20 ` heliocat
  2021-04-07 19:20 ` heliocat
  2021-04-07 19:24 ` [PR PATCH] [Closed]: " ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: heliocat @ 2021-04-07 19:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

There is an updated pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages binfmt-support
https://github.com/void-linux/void-packages/pull/29802

binfmt-support: fix license, fix build
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/29802.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-binfmt-support-29802.patch --]
[-- Type: text/x-diff, Size: 1084 bytes --]

From 250a2fcdfaa95a610256989e19e2cf43eb0f902a Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Sun, 28 Mar 2021 01:23:07 -0700
Subject: [PATCH] binfmt-support: fix license, fix build

---
 srcpkgs/binfmt-support/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/binfmt-support/template b/srcpkgs/binfmt-support/template
index 4208b1969b05..252d05051cd3 100644
--- a/srcpkgs/binfmt-support/template
+++ b/srcpkgs/binfmt-support/template
@@ -1,13 +1,13 @@
 # Template file for 'binfmt-support'
 pkgname=binfmt-support
 version=2.2.1
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="pkg-config"
 makedepends="libpipeline-devel"
 short_desc="Register interpreters for various binary formats"
 maintainer="Andrea Brancaleoni <abc@pompel.me>"
-license="GPL-3"
+license="GPL-2.0-or-later"
 homepage="http://packages.debian.org/en/sid/binfmt-support"
 distfiles="${DEBIAN_SITE}/main/b/binfmt-support/binfmt-support_$version.orig.tar.gz"
 checksum=9c9da3306501a834663ccd14023fc8d29bd08a34df74585e11f97735ea1fb31d

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: binfmt-support: fix license, fix build
  2021-03-28  8:26 [PR PATCH] binfmt-support: fix license, fix build heliocat
                   ` (3 preceding siblings ...)
  2021-04-07 19:20 ` [PR PATCH] [Updated] " heliocat
@ 2021-04-07 19:20 ` heliocat
  2021-04-07 19:24 ` [PR PATCH] [Closed]: " ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: heliocat @ 2021-04-07 19:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/29802#issuecomment-815164416

Comment:
Broken stuff in my masterdir causing all the failures.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: binfmt-support: fix license, fix build
  2021-03-28  8:26 [PR PATCH] binfmt-support: fix license, fix build heliocat
                   ` (4 preceding siblings ...)
  2021-04-07 19:20 ` heliocat
@ 2021-04-07 19:24 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-04-07 19:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

There's a closed pull request on the void-packages repository

binfmt-support: fix license, fix build
https://github.com/void-linux/void-packages/pull/29802

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-04-07 19:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-28  8:26 [PR PATCH] binfmt-support: fix license, fix build heliocat
2021-03-28 16:00 ` ericonr
2021-03-28 16:29 ` heliocat
2021-04-04 23:17 ` ericonr
2021-04-07 19:20 ` [PR PATCH] [Updated] " heliocat
2021-04-07 19:20 ` heliocat
2021-04-07 19:24 ` [PR PATCH] [Closed]: " ericonr

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git