[PR PATCH] firebird3: fix license

[PR PATCH] firebird3: fix license

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

There is a new pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages firebird3
https://github.com/void-linux/void-packages/pull/29899

firebird3: fix license
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/29899.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firebird3-29899.patch --]
[-- Type: text/x-diff, Size: 1521 bytes --]

From 298494ee1ec453eb1a07219ad3bbb5a1f43e94e9 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Wed, 31 Mar 2021 00:50:09 -0700
Subject: [PATCH] firebird3: fix license

---
 srcpkgs/firebird3/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/firebird3/template b/srcpkgs/firebird3/template
index df02ac1379c7..ef6e90070429 100644
--- a/srcpkgs/firebird3/template
+++ b/srcpkgs/firebird3/template
@@ -1,7 +1,7 @@
 # Template file for 'firebird3'
 pkgname=firebird3
 version=3.0.6.33328
-revision=1
+revision=2
 _build=0
 _uver=${version//./_}
 wrksrc="Firebird-${version}-${_build}"
@@ -31,7 +31,7 @@ makedepends="boost-devel libedit-devel icu-devel ncurses-devel libatomic_ops-dev
  libtommath-devel zlib-devel"
 short_desc="Relational database offering many ANSI SQL standard features (V3)"
 maintainer="Jürgen Buchmüller <pullmoll@t-online.de>"
-license="custom"
+license="custom:IDPL"
 homepage="https://www.firebirdsql.org/en/start/"
 distfiles="https://github.com/FirebirdSQL/firebird/releases/download/R${_uver%_*}/Firebird-${version}-${_build}.tar.bz2"
 checksum=34c1d2a29bbaf288e682cd1b5f8083f2baf73f351062245ace0bee35a3f7d35f
@@ -89,7 +89,7 @@ pre_configure() {
 	# do not change ownership to root:root and
 	# do not change permissions to read-only
 	find -iname "*.sh.in" -exec sed -i "{}" \
-		-e 's;"`whoami`";"root";' \
+		-e 's;"$(whoami)";"root";' \
 		-e 's;chown root:root;#&;' \
 		-e 's;chown -R;#&;' \
 		-e 's;chmod 0444;chmod 0644;' \

Re: [PR REVIEW] firebird3: fix license

[sgn]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29899#discussion_r604818025

Comment:
You may want to set to Orphaned.

Re: [PR REVIEW] firebird3: fix license

[sgn]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29899#discussion_r604818491

Comment:
Nope, the backtick is correct, we're trying to replace the execution with `root`, you may want to write a patch instead.

Re: firebird3: fix license

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/29899#issuecomment-811262501

Comment:
I'm going to close this PR for now. That sed changes 43 files and while extracting the whoami part into a patch would touch fewer things this should probably be handled outside of a linting cleanup. Also, I don't want to be the person to orphan Jürgen's stuff, it doesn't feel right (and with the work that this package will take to clean up will probably collide with another cleanup set).

Re: [PR PATCH] [Closed]: firebird3: fix license

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]

There's a closed pull request on the void-packages repository

firebird3: fix license
https://github.com/void-linux/void-packages/pull/29899

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl