Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] kubernetes-helm: update to 3.5.3
@ 2021-04-11 22:55 ScOut3R
  2021-04-12 13:35 ` [PR REVIEW] " ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: ScOut3R @ 2021-04-11 22:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

There is a new pull request by ScOut3R against master on the void-packages repository

https://github.com/ScOut3R/void-packages helm
https://github.com/void-linux/void-packages/pull/30171

kubernetes-helm: update to 3.5.3


A patch file from https://github.com/void-linux/void-packages/pull/30171.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-helm-30171.patch --]
[-- Type: text/x-diff, Size: 2279 bytes --]

From 8bbf8d74d7d9c3f5c964d66889e2179ee91928b8 Mon Sep 17 00:00:00 2001
From: Mate GABRI <mate.gabri@playhq.com>
Date: Mon, 12 Apr 2021 08:54:55 +1000
Subject: [PATCH] kubernetes-helm: update to 3.5.3

---
 srcpkgs/kubernetes-helm/template | 23 +++++------------------
 1 file changed, 5 insertions(+), 18 deletions(-)

diff --git a/srcpkgs/kubernetes-helm/template b/srcpkgs/kubernetes-helm/template
index 42f8d1bd443c..b5c1b398bf27 100644
--- a/srcpkgs/kubernetes-helm/template
+++ b/srcpkgs/kubernetes-helm/template
@@ -1,7 +1,7 @@
 # Template file for 'kubernetes-helm'
 pkgname=kubernetes-helm
-version=3.3.1
-revision=1
+version=3.5.3
+revision=2
 wrksrc="helm-${version}"
 hostmakedepends="go make git mercurial tar"
 short_desc="Kubernetes Package Manager"
@@ -9,7 +9,7 @@ maintainer="Kyle Nusbaum <knusbaum+void@sdf.org>"
 license="Apache-2.0"
 homepage="https://helm.sh/"
 distfiles="https://github.com/helm/helm/archive/v${version}.tar.gz"
-checksum=7a0ca710683d264bfa79eeed61f1dfd90db2cc755cbc1d1e9ccbb43ec55917b6
+checksum=bd3e2488011e0a73650e810cf540fcfcfcb828ff1480cc2c5a1e50934cad9d82
 conflicts="helm"
 nopie=true
 
@@ -35,23 +35,10 @@ do_extract() {
 		helm-${version}
 }
 
-pre_build() {
-	export GOPATH="$(pwd)/golib"
-
-	## The current version of glide in the repository has
-	## a bug that prevents building, so pull the current
-	## version from git.
-	CC=/bin/gcc go get github.com/Masterminds/glide
-	CC=/bin/gcc go get github.com/mitchellh/gox
-	CC=/bin/gcc go install github.com/Masterminds/glide
-	CC=/bin/gcc go install github.com/mitchellh/gox
-	PATH="$PATH:$(pwd)/golib/bin/"
-	export PATH
-}
-
 do_build() {
 	cd golib/src/k8s.io/helm
-	make build-cross TARGETS="linux/${_go_target_arch} linux/${_go_host_arch}" APP="..." LDFLAGS="-X k8s.io/helm/pkg/version.Version=v${version} -X k8s.io/helm/pkg/version.BuildMetadata="
+	go mod tidy # can be removed with 3.6.0; see https://github.com/helm/helm/issues/9479
+	make build-cross TARGETS="linux/${_go_target_arch} linux/${_go_host_arch}" APP="..." LDFLAGS="-X helm.sh/helm/v3/internal/version.version=v${version} -X helm.sh/helm/v3/internal/version.metadata="
 
 	_dist/linux-${_go_host_arch}/helm completion bash > completion.bash
 	_dist/linux-${_go_host_arch}/helm completion zsh > completion.zsh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] kubernetes-helm: update to 3.5.3
  2021-04-11 22:55 [PR PATCH] kubernetes-helm: update to 3.5.3 ScOut3R
@ 2021-04-12 13:35 ` ericonr
  2021-04-12 21:52 ` ScOut3R
  2021-04-14 12:24 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-04-12 13:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30171#discussion_r611634487

Comment:
Did they completely stop needing glide? Or does the build system now build it?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] kubernetes-helm: update to 3.5.3
  2021-04-11 22:55 [PR PATCH] kubernetes-helm: update to 3.5.3 ScOut3R
  2021-04-12 13:35 ` [PR REVIEW] " ericonr
@ 2021-04-12 21:52 ` ScOut3R
  2021-04-14 12:24 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ScOut3R @ 2021-04-12 21:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by ScOut3R on void-packages repository

https://github.com/void-linux/void-packages/pull/30171#discussion_r611978831

Comment:
Yes, glide seems to have gone from the dependencies. I have built the package and been using it locally and it is working fine.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: kubernetes-helm: update to 3.5.3
  2021-04-11 22:55 [PR PATCH] kubernetes-helm: update to 3.5.3 ScOut3R
  2021-04-12 13:35 ` [PR REVIEW] " ericonr
  2021-04-12 21:52 ` ScOut3R
@ 2021-04-14 12:24 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-04-14 12:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

There's a merged pull request on the void-packages repository

kubernetes-helm: update to 3.5.3
https://github.com/void-linux/void-packages/pull/30171

Description:


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-14 12:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-11 22:55 [PR PATCH] kubernetes-helm: update to 3.5.3 ScOut3R
2021-04-12 13:35 ` [PR REVIEW] " ericonr
2021-04-12 21:52 ` ScOut3R
2021-04-14 12:24 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).