From: AluminumTank <AluminumTank@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] nginx: configure with --with-compat for dynamic module support
Date: Fri, 16 Apr 2021 03:58:06 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30256@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]
There is a new pull request by AluminumTank against master on the void-packages repository
https://github.com/AluminumTank/void-packages nginx-with-compat
https://github.com/void-linux/void-packages/pull/30256
nginx: configure with --with-compat for dynamic module support
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [X] armv7l
- [ ] armv6l-musl
This change is required for dynamic modules to work, as mentioned in [this tutorial](https://www.nginx.com/blog/compiling-dynamic-modules-nginx-plus/):
"`--with-compat` ... creates a standard build environment supported by both NGINX Open Source and NGINX Plus."
A patch file from https://github.com/void-linux/void-packages/pull/30256.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nginx-with-compat-30256.patch --]
[-- Type: text/x-diff, Size: 937 bytes --]
From 5295ecb29f2cf5c99ed2fdf598ddf34bda1c5fa7 Mon Sep 17 00:00:00 2001
From: AluminumTank <joel@beckmeyer.us>
Date: Thu, 15 Apr 2021 21:30:58 -0400
Subject: [PATCH] nginx: configure with --with-compat for dynamic module
support
---
srcpkgs/nginx/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/nginx/template b/srcpkgs/nginx/template
index 76d52cb3f221..6d4063daee6f 100644
--- a/srcpkgs/nginx/template
+++ b/srcpkgs/nginx/template
@@ -1,7 +1,7 @@
# Template file for 'nginx'
pkgname=nginx
version=1.18.0
-revision=4
+revision=5
build_style=gnu-makefile
hostmakedepends="openssl-devel pcre-devel $(vopt_if geoip geoip-devel)"
makedepends="${hostmakedepends}"
@@ -55,6 +55,7 @@ do_configure() {
./configure --prefix=${cfgdir} \
--conf-path=${cfgdir}/nginx.conf \
+ --with-compat \
--sbin-path=/usr/bin/nginx \
--pid-path=/run/nginx.pid \
--lock-path=/var/lock/nginx.lock \
next reply other threads:[~2021-04-16 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 1:58 AluminumTank [this message]
2021-07-08 11:10 ` SunRed
2021-08-11 20:41 ` [PR PATCH] [Updated] " paper42
2021-08-11 20:44 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30256@inbox.vuxu.org \
--to=aluminumtank@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).