[PR PATCH] nginx: configure with --with-compat for dynamic module support

[PR PATCH] nginx: configure with --with-compat for dynamic module support

[AluminumTank]

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

There is a new pull request by AluminumTank against master on the void-packages repository

https://github.com/AluminumTank/void-packages nginx-with-compat
https://github.com/void-linux/void-packages/pull/30256

nginx: configure with --with-compat for dynamic module support
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [X] armv7l
  - [ ] armv6l-musl

This change is required for dynamic modules to work, as mentioned in [this tutorial](https://www.nginx.com/blog/compiling-dynamic-modules-nginx-plus/):
"`--with-compat` ... creates a standard build environment supported by both NGINX Open Source and NGINX Plus."

A patch file from https://github.com/void-linux/void-packages/pull/30256.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nginx-with-compat-30256.patch --]
[-- Type: text/x-diff, Size: 937 bytes --]

From 5295ecb29f2cf5c99ed2fdf598ddf34bda1c5fa7 Mon Sep 17 00:00:00 2001
From: AluminumTank <joel@beckmeyer.us>
Date: Thu, 15 Apr 2021 21:30:58 -0400
Subject: [PATCH] nginx: configure with --with-compat for dynamic module
 support

---
 srcpkgs/nginx/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nginx/template b/srcpkgs/nginx/template
index 76d52cb3f221..6d4063daee6f 100644
--- a/srcpkgs/nginx/template
+++ b/srcpkgs/nginx/template
@@ -1,7 +1,7 @@
 # Template file for 'nginx'
 pkgname=nginx
 version=1.18.0
-revision=4
+revision=5
 build_style=gnu-makefile
 hostmakedepends="openssl-devel pcre-devel $(vopt_if geoip geoip-devel)"
 makedepends="${hostmakedepends}"
@@ -55,6 +55,7 @@ do_configure() {
 
 	./configure --prefix=${cfgdir} \
 		--conf-path=${cfgdir}/nginx.conf \
+		--with-compat \
 		--sbin-path=/usr/bin/nginx \
 		--pid-path=/run/nginx.pid \
 		--lock-path=/var/lock/nginx.lock \

Re: nginx: configure with --with-compat for dynamic module support

[SunRed]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

New comment by SunRed on void-packages repository

https://github.com/void-linux/void-packages/pull/30256#issuecomment-876349210

Comment:
Will this ever be merged? Same as with https://github.com/void-linux/void-packages/pull/30257.
This makes void much more useful for a simple web server without having to recompile the packages with this patch.

Re: [PR PATCH] [Updated] nginx: configure with --with-compat for dynamic module support

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/AluminumTank/void-packages nginx-with-compat
https://github.com/void-linux/void-packages/pull/30256

nginx: configure with --with-compat for dynamic module support
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [X] armv7l
  - [ ] armv6l-musl
-->

This change is required for dynamic modules to work, as mentioned in [this tutorial](https://www.nginx.com/blog/compiling-dynamic-modules-nginx-plus/):
"`--with-compat` ... creates a standard build environment supported by both NGINX Open Source and NGINX Plus."

A patch file from https://github.com/void-linux/void-packages/pull/30256.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nginx-with-compat-30256.patch --]
[-- Type: text/x-diff, Size: 918 bytes --]

From bae85875e3b9052b9acf464412ef24575340d9c2 Mon Sep 17 00:00:00 2001
From: AluminumTank <joel@beckmeyer.us>
Date: Thu, 15 Apr 2021 21:30:58 -0400
Subject: [PATCH] nginx: configure with dynamic module support

---
 srcpkgs/nginx/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nginx/template b/srcpkgs/nginx/template
index cd0b19da95c6..73b460d23e53 100644
--- a/srcpkgs/nginx/template
+++ b/srcpkgs/nginx/template
@@ -1,7 +1,7 @@
 # Template file for 'nginx'
 pkgname=nginx
 version=1.18.0
-revision=5
+revision=6
 build_style=gnu-makefile
 hostmakedepends="openssl-devel pcre-devel $(vopt_if geoip geoip-devel)"
 makedepends="${hostmakedepends}"
@@ -55,6 +55,7 @@ do_configure() {
 
 	./configure --prefix=${cfgdir} \
 		--conf-path=${cfgdir}/nginx.conf \
+		--with-compat \
 		--sbin-path=/usr/bin/nginx \
 		--pid-path=/run/nginx.pid \
 		--lock-path=/var/lock/nginx.lock \

Re: [PR PATCH] [Merged]: nginx: configure with --with-compat for dynamic module support

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]

There's a merged pull request on the void-packages repository

nginx: configure with --with-compat for dynamic module support
https://github.com/void-linux/void-packages/pull/30256

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [X] armv7l
  - [ ] armv6l-musl
-->

This change is required for dynamic modules to work, as mentioned in [this tutorial](https://www.nginx.com/blog/compiling-dynamic-modules-nginx-plus/):
"`--with-compat` ... creates a standard build environment supported by both NGINX Open Source and NGINX Plus."