Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] tor: double MAX_OPEN_FILES yet again.
@ 2021-05-09  7:27 steinex
  2021-05-09 20:31 ` [PR PATCH] [Merged]: " ericonr
  0 siblings, 1 reply; 2+ messages in thread
From: steinex @ 2021-05-09  7:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]

There is a new pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages tor
https://github.com/void-linux/void-packages/pull/30759

tor: double MAX_OPEN_FILES yet again.
@ericonr As said on IRC, you were actually right about setting MAX_OPEN_FILES higher. I just again run into the fd limit and the high CPU usage I mentioned was because of io wait of tor waiting to get free fds. So let's double it just again, it's cheap as you said and should be fine now even with high bandwidth scenarios.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30759.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tor-30759.patch --]
[-- Type: text/x-diff, Size: 1007 bytes --]

From d41268449e51f3d4f3878ffdbeeaa20a8d4261d0 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Sat, 8 May 2021 16:26:41 +0200
Subject: [PATCH] tor: double MAX_OPEN_FILES yet again.

---
 srcpkgs/tor/files/tor/run | 2 +-
 srcpkgs/tor/template      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tor/files/tor/run b/srcpkgs/tor/files/tor/run
index d0d402d25f5a..389850ff0342 100755
--- a/srcpkgs/tor/files/tor/run
+++ b/srcpkgs/tor/files/tor/run
@@ -1,4 +1,4 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
-ulimit -n ${MAX_OPEN_FILES:-8192}
+ulimit -n ${MAX_OPEN_FILES:-16384}
 exec tor ${OPTS:=--quiet} --runasdaemon 0 2>&1
diff --git a/srcpkgs/tor/template b/srcpkgs/tor/template
index cef10708f390..ef6d68483a56 100644
--- a/srcpkgs/tor/template
+++ b/srcpkgs/tor/template
@@ -1,7 +1,7 @@
 # Template file for 'tor'
 pkgname=tor
 version=0.4.5.6
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="--enable-zstd"
 hostmakedepends="pkg-config"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: tor: double MAX_OPEN_FILES yet again.
  2021-05-09  7:27 [PR PATCH] tor: double MAX_OPEN_FILES yet again steinex
@ 2021-05-09 20:31 ` ericonr
  0 siblings, 0 replies; 2+ messages in thread
From: ericonr @ 2021-05-09 20:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

There's a merged pull request on the void-packages repository

tor: double MAX_OPEN_FILES yet again.
https://github.com/void-linux/void-packages/pull/30759

Description:
@ericonr As said on IRC, you were actually right about setting MAX_OPEN_FILES higher. I just again run into the fd limit and the high CPU usage I mentioned was because of io wait of tor waiting to get free fds. So let's double it just again, it's cheap as you said and should be fine now even with high bandwidth scenarios.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-09 20:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-09  7:27 [PR PATCH] tor: double MAX_OPEN_FILES yet again steinex
2021-05-09 20:31 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).