* [PR PATCH] musl: add 0 large file patch
@ 2021-05-10 8:43 dkwo
2021-05-10 11:20 ` [PR PATCH] [Updated] [wip] " dkwo
` (19 more replies)
0 siblings, 20 replies; 21+ messages in thread
From: dkwo @ 2021-05-10 8:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
There is a new pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages musl-ff
https://github.com/void-linux/void-packages/pull/30777
musl: add 0 large file patch
- musl:add patch for 0 largefile on x86_64
- musl: revbump
This would allow e.g. building firefox so that it is usable with musl 1.2.2
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/30777.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-musl-ff-30777.patch --]
[-- Type: text/x-diff, Size: 1710 bytes --]
From f5453b636930b1aa6402d935253d48fdc22826a7 Mon Sep 17 00:00:00 2001
From: Nicolo <nicolo@gmail.com>
Date: Mon, 10 May 2021 10:40:24 +0200
Subject: [PATCH 1/2] musl:add patch for 0 largefile on x86_64
---
.../patches/fix_missing_O_LARGEFILE_values.patch | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
diff --git a/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch b/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
new file mode 100644
index 000000000000..bde0c4e91d28
--- /dev/null
+++ b/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
@@ -0,0 +1,16 @@
+taken from git.musl-libc.org/cgit/musl/commit/?id=b8b729bd22c28c9116c2fce65dce207a35299c26
+
+arch/x86_64/bits/fcntl.h
+arch/x86_64/bits/fcntl.h
+index 1b88ad39..08627f81 100644
+--- a/arch/x86_64/bits/fcntl.h
++++ b/arch/x86_64/bits/fcntl.h
+@@ -13,7 +13,7 @@
+
+ #define O_ASYNC 020000
+ #define O_DIRECT 040000
+-#define O_LARGEFILE 0
++#define O_LARGEFILE 0100000
+ #define O_NOATIME 01000000
+ #define O_PATH 010000000
+ #define O_TMPFILE 020200000
From b866042438d9d53d7ea0e1e849dfb12cefa0e624 Mon Sep 17 00:00:00 2001
From: Nicolo <nicolo@gmail.com>
Date: Mon, 10 May 2021 10:40:47 +0200
Subject: [PATCH 2/2] musl: revbump
---
srcpkgs/musl/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/musl/template b/srcpkgs/musl/template
index 5ba5425709b0..337a3082faa9 100644
--- a/srcpkgs/musl/template
+++ b/srcpkgs/musl/template
@@ -2,7 +2,7 @@
pkgname=musl
reverts="1.2.0_1"
version=1.1.24
-revision=6
+revision=7
archs="*-musl"
bootstrap=yes
build_style=gnu-configure
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR PATCH] [Updated] [wip] musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
@ 2021-05-10 11:20 ` dkwo
2021-05-10 11:21 ` dkwo
` (18 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-10 11:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages musl-ff
https://github.com/void-linux/void-packages/pull/30777
[wip] musl: add 0 large file patch
- musl: add patch for 0 largefile
- musl: revbump
This would allow e.g. building firefox so that it is usable with musl 1.2.2
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/30777.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-musl-ff-30777.patch --]
[-- Type: text/x-diff, Size: 3120 bytes --]
From 02f478a0007e052a9266c74a46521c70096ea4e1 Mon Sep 17 00:00:00 2001
From: Nicolo <nicolopiazzalunga@gmail.com>
Date: Mon, 10 May 2021 13:17:33 +0200
Subject: [PATCH 1/2] musl: revbump
---
srcpkgs/musl/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/musl/template b/srcpkgs/musl/template
index 5ba5425709b0..337a3082faa9 100644
--- a/srcpkgs/musl/template
+++ b/srcpkgs/musl/template
@@ -2,7 +2,7 @@
pkgname=musl
reverts="1.2.0_1"
version=1.1.24
-revision=6
+revision=7
archs="*-musl"
bootstrap=yes
build_style=gnu-configure
From 248af3b77aeebc0cd92cca7c72b357309ee47b49 Mon Sep 17 00:00:00 2001
From: Nicolo <nicolopiazzalunga@gmail.com>
Date: Mon, 10 May 2021 13:19:33 +0200
Subject: [PATCH 2/2] musl: add 0 large file patch
---
.../fix_missing_O_LARGEFILE_values.patch | 54 +++++++++++++++++++
1 file changed, 54 insertions(+)
create mode 100644 srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
diff --git a/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch b/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
new file mode 100644
index 000000000000..e9a27fd8cb66
--- /dev/null
+++ b/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
@@ -0,0 +1,54 @@
+prior to commit 685e40bb09f5f24a2af54ea09c97328808f76990, x86_64 was
+correctly passing O_LARGEFILE to SYS_open; it was removed (defined to
+0 in the public header, and changed to use the public definition) as
+part of that change, probably out of a mistaken belief that it's not
+needed.
+
+however, on a mixed system with 32-bit and 64-bit binaries, it's
+important that all files be opened with O_LARGEFILE, even if the
+opening process is 64-bit, in case a descriptor is passed to a 32-bit
+process. otherwise, attempts to access past 2GB in the 32-bit process
+could produce EOVERFLOW.
+
+most 64-bit archs added later got this right alread, except for
+mips64. x32 was also affected. there are now fixed.
+
+diff --git a/arch/mips64/bits/fcntl.h b/arch/mips64/bits/fcntl.h
+index 3bcec15e..5da1eef8 100644
+--- arch/mips64/bits/fcntl.h
++++ arch/mips64/bits/fcntl.h
+@@ -13,7 +13,7 @@
+
+ #define O_ASYNC 010000
+ #define O_DIRECT 0100000
+-#define O_LARGEFILE 0
++#define O_LARGEFILE 020000
+ #define O_NOATIME 01000000
+ #define O_PATH 010000000
+ #define O_TMPFILE 020200000
+diff --git a/arch/x32/bits/fcntl.h b/arch/x32/bits/fcntl.h
+index 1b88ad39..08627f81 100644
+--- arch/x32/bits/fcntl.h
++++ arch/x32/bits/fcntl.h
+@@ -13,7 +13,7 @@
+
+ #define O_ASYNC 020000
+ #define O_DIRECT 040000
+-#define O_LARGEFILE 0
++#define O_LARGEFILE 0100000
+ #define O_NOATIME 01000000
+ #define O_PATH 010000000
+ #define O_TMPFILE 020200000
+diff --git a/arch/x86_64/bits/fcntl.h b/arch/x86_64/bits/fcntl.h
+index 1b88ad39..08627f81 100644
+--- arch/x86_64/bits/fcntl.h
++++ arch/x86_64/bits/fcntl.h
+@@ -13,7 +13,7 @@
+
+ #define O_ASYNC 020000
+ #define O_DIRECT 040000
+-#define O_LARGEFILE 0
++#define O_LARGEFILE 0100000
+ #define O_NOATIME 01000000
+ #define O_PATH 010000000
+ #define O_TMPFILE 020200000
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [wip] musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
2021-05-10 11:20 ` [PR PATCH] [Updated] [wip] " dkwo
@ 2021-05-10 11:21 ` dkwo
2021-05-10 13:30 ` [PR REVIEW] " ericonr
` (17 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-10 11:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-836574109
Comment:
@ericonr If you find it ok, perhaps this could be merged before the ff update.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR REVIEW] musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
2021-05-10 11:20 ` [PR PATCH] [Updated] [wip] " dkwo
2021-05-10 11:21 ` dkwo
@ 2021-05-10 13:30 ` ericonr
2021-05-10 14:09 ` ericonr
` (16 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-05-10 13:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#discussion_r629357355
Comment:
Please also include the commit hash from upstream.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (2 preceding siblings ...)
2021-05-10 13:30 ` [PR REVIEW] " ericonr
@ 2021-05-10 14:09 ` ericonr
2021-05-10 15:09 ` [PR PATCH] [Updated] " dkwo
` (15 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-05-10 14:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-836747994
Comment:
Hmm, we'd have to check if this breaks chromium or the other mozilla packages as well...
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR PATCH] [Updated] musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (3 preceding siblings ...)
2021-05-10 14:09 ` ericonr
@ 2021-05-10 15:09 ` dkwo
2021-05-10 15:10 ` [PR REVIEW] " dkwo
` (14 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-10 15:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages musl-ff
https://github.com/void-linux/void-packages/pull/30777
musl: add 0 large file patch
- musl: add patch for 0 largefile
- musl: revbump
This would allow e.g. building firefox so that it is usable with musl 1.2.2
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Builds fine on x86_64-musl.
A patch file from https://github.com/void-linux/void-packages/pull/30777.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-musl-ff-30777.patch --]
[-- Type: text/x-diff, Size: 3376 bytes --]
From af257058e055c2dc31a39ee4a5b318472cc7da54 Mon Sep 17 00:00:00 2001
From: Nicolo <nicolopiazzalunga@gmail.com>
Date: Mon, 10 May 2021 17:08:31 +0200
Subject: [PATCH] musl: backport O_LARGE fix
musl 1.2.2 started defining O_LARGEFILE to an actual value for x86_64, which breaks the firefox seccomp filter when built with older musl headers. backporting this change and building firefox with it allows one to use a local more up to date musl version with firefox from repos
---
.../fix_missing_O_LARGEFILE_values.patch | 58 +++++++++++++++++++
srcpkgs/musl/template | 2 +-
2 files changed, 59 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
diff --git a/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch b/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
new file mode 100644
index 000000000000..34d2ab176af8
--- /dev/null
+++ b/srcpkgs/musl/patches/fix_missing_O_LARGEFILE_values.patch
@@ -0,0 +1,58 @@
+author Rich Felker <dalias@aerifal.cx> 2020-09-03 17:37:11 -0400
+committer Rich Felker <dalias@aerifal.cx> 2020-09-03 17:37:11 -0400
+commit b8b729bd22c28c9116c2fce65dce207a35299c26
+
+prior to commit 685e40bb09f5f24a2af54ea09c97328808f76990, x86_64 was
+correctly passing O_LARGEFILE to SYS_open; it was removed (defined to
+0 in the public header, and changed to use the public definition) as
+part of that change, probably out of a mistaken belief that it's not
+needed.
+
+however, on a mixed system with 32-bit and 64-bit binaries, it's
+important that all files be opened with O_LARGEFILE, even if the
+opening process is 64-bit, in case a descriptor is passed to a 32-bit
+process. otherwise, attempts to access past 2GB in the 32-bit process
+could produce EOVERFLOW.
+
+most 64-bit archs added later got this right alread, except for
+mips64. x32 was also affected. there are now fixed.
+
+diff --git a/arch/mips64/bits/fcntl.h b/arch/mips64/bits/fcntl.h
+index 3bcec15e..5da1eef8 100644
+--- arch/mips64/bits/fcntl.h
++++ arch/mips64/bits/fcntl.h
+@@ -13,7 +13,7 @@
+
+ #define O_ASYNC 010000
+ #define O_DIRECT 0100000
+-#define O_LARGEFILE 0
++#define O_LARGEFILE 020000
+ #define O_NOATIME 01000000
+ #define O_PATH 010000000
+ #define O_TMPFILE 020200000
+diff --git a/arch/x32/bits/fcntl.h b/arch/x32/bits/fcntl.h
+index 1b88ad39..08627f81 100644
+--- arch/x32/bits/fcntl.h
++++ arch/x32/bits/fcntl.h
+@@ -13,7 +13,7 @@
+
+ #define O_ASYNC 020000
+ #define O_DIRECT 040000
+-#define O_LARGEFILE 0
++#define O_LARGEFILE 0100000
+ #define O_NOATIME 01000000
+ #define O_PATH 010000000
+ #define O_TMPFILE 020200000
+diff --git a/arch/x86_64/bits/fcntl.h b/arch/x86_64/bits/fcntl.h
+index 1b88ad39..08627f81 100644
+--- arch/x86_64/bits/fcntl.h
++++ arch/x86_64/bits/fcntl.h
+@@ -13,7 +13,7 @@
+
+ #define O_ASYNC 020000
+ #define O_DIRECT 040000
+-#define O_LARGEFILE 0
++#define O_LARGEFILE 0100000
+ #define O_NOATIME 01000000
+ #define O_PATH 010000000
+ #define O_TMPFILE 020200000
diff --git a/srcpkgs/musl/template b/srcpkgs/musl/template
index 5ba5425709b0..337a3082faa9 100644
--- a/srcpkgs/musl/template
+++ b/srcpkgs/musl/template
@@ -2,7 +2,7 @@
pkgname=musl
reverts="1.2.0_1"
version=1.1.24
-revision=6
+revision=7
archs="*-musl"
bootstrap=yes
build_style=gnu-configure
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR REVIEW] musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (4 preceding siblings ...)
2021-05-10 15:09 ` [PR PATCH] [Updated] " dkwo
@ 2021-05-10 15:10 ` dkwo
2021-05-10 15:11 ` dkwo
` (13 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-10 15:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New review comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#discussion_r629444246
Comment:
should be fixed now
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (5 preceding siblings ...)
2021-05-10 15:10 ` [PR REVIEW] " dkwo
@ 2021-05-10 15:11 ` dkwo
2021-05-10 15:14 ` dkwo
` (12 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-10 15:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-836819892
Comment:
> Hmm, we'd have to check if this breaks chromium or the other mozilla packages as well...
Do you mean building or using them?
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (6 preceding siblings ...)
2021-05-10 15:11 ` dkwo
@ 2021-05-10 15:14 ` dkwo
2021-05-10 15:16 ` ericonr
` (11 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-10 15:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-836819892
Comment:
> Hmm, we'd have to check if this breaks chromium or the other mozilla packages as well...
Do you mean building or using them?
(As far as using, they seem to work fine with the musl patch.)
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (7 preceding siblings ...)
2021-05-10 15:14 ` dkwo
@ 2021-05-10 15:16 ` ericonr
2021-05-10 15:25 ` dkwo
` (10 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-05-10 15:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-836825553
Comment:
Yeah, using. Because the thing is, by backporting this musl change, we are introducing the issue with musl 1.2.2 to our musl package. So anything that needed to be rebuilt because of musl 1.2.2 in other distros also needs to rebuilt if we merge this in.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (8 preceding siblings ...)
2021-05-10 15:16 ` ericonr
@ 2021-05-10 15:25 ` dkwo
2021-05-12 20:52 ` ericonr
` (9 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-10 15:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-836836703
Comment:
I briefly checked chromium and thunderbird, and they seem to work fine.
(Obviously, firefox is broken instead.)
Can you think of something else to check?
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (9 preceding siblings ...)
2021-05-10 15:25 ` dkwo
@ 2021-05-12 20:52 ` ericonr
2021-05-13 11:35 ` dkwo
` (8 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-05-12 20:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840089127
Comment:
Firefox-esr and Thunderbird, at least.
In the opposite direction, I made: https://github.com/ericonr/void-packages/tree/musl-1.2.0
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (10 preceding siblings ...)
2021-05-12 20:52 ` ericonr
@ 2021-05-13 11:35 ` dkwo
2021-05-13 12:04 ` dkwo
` (7 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-13 11:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840499466
Comment:
Your idea is probably smarter.
Thunderbird does not need a revbump thouhg.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (11 preceding siblings ...)
2021-05-13 11:35 ` dkwo
@ 2021-05-13 12:04 ` dkwo
2021-05-13 13:51 ` ericonr
` (6 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-13 12:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840511994
Comment:
I'm a bit confused: if I build your solution, I still get crash in `firefox` sandbox with syscal 16, as mentioned in #29632
What am I doing wrong?
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (12 preceding siblings ...)
2021-05-13 12:04 ` dkwo
@ 2021-05-13 13:51 ` ericonr
2021-05-13 14:20 ` dkwo
` (5 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-05-13 13:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840575422
Comment:
Are you using firefox from repos or from when you built with this patch? There's a chance it's broken when built with the patch but running without it.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (13 preceding siblings ...)
2021-05-13 13:51 ` ericonr
@ 2021-05-13 14:20 ` dkwo
2021-05-13 14:28 ` dkwo
` (4 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-13 14:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840594430
Comment:
I'm using firefox from the repos.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (14 preceding siblings ...)
2021-05-13 14:20 ` dkwo
@ 2021-05-13 14:28 ` dkwo
2021-05-13 14:31 ` dkwo
` (3 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-13 14:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840599351
Comment:
Edit: sorry, my bad, I had to delete previous `musl` build, now it works as expected.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (15 preceding siblings ...)
2021-05-13 14:28 ` dkwo
@ 2021-05-13 14:31 ` dkwo
2021-05-13 14:31 ` [PR PATCH] [Closed]: " dkwo
` (2 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-13 14:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840601425
Comment:
I think your solution is better, so let's close this.
Thank you.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR PATCH] [Closed]: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (16 preceding siblings ...)
2021-05-13 14:31 ` dkwo
@ 2021-05-13 14:31 ` dkwo
2021-05-13 14:34 ` ericonr
2021-05-13 14:42 ` dkwo
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-13 14:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
There's a closed pull request on the void-packages repository
musl: add 0 large file patch
https://github.com/void-linux/void-packages/pull/30777
Description:
- musl: add patch for 0 largefile
- musl: revbump
This would allow e.g. building firefox so that it is usable with musl 1.2.2
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
Builds fine on x86_64-musl.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (17 preceding siblings ...)
2021-05-13 14:31 ` [PR PATCH] [Closed]: " dkwo
@ 2021-05-13 14:34 ` ericonr
2021-05-13 14:42 ` dkwo
19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-05-13 14:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840603182
Comment:
You can build with `-f` to overwrite the existing package build ;)
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: musl: add 0 large file patch
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
` (18 preceding siblings ...)
2021-05-13 14:34 ` ericonr
@ 2021-05-13 14:42 ` dkwo
19 siblings, 0 replies; 21+ messages in thread
From: dkwo @ 2021-05-13 14:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/30777#issuecomment-840608273
Comment:
Good to know, thanks!
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2021-05-13 14:42 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 8:43 [PR PATCH] musl: add 0 large file patch dkwo
2021-05-10 11:20 ` [PR PATCH] [Updated] [wip] " dkwo
2021-05-10 11:21 ` dkwo
2021-05-10 13:30 ` [PR REVIEW] " ericonr
2021-05-10 14:09 ` ericonr
2021-05-10 15:09 ` [PR PATCH] [Updated] " dkwo
2021-05-10 15:10 ` [PR REVIEW] " dkwo
2021-05-10 15:11 ` dkwo
2021-05-10 15:14 ` dkwo
2021-05-10 15:16 ` ericonr
2021-05-10 15:25 ` dkwo
2021-05-12 20:52 ` ericonr
2021-05-13 11:35 ` dkwo
2021-05-13 12:04 ` dkwo
2021-05-13 13:51 ` ericonr
2021-05-13 14:20 ` dkwo
2021-05-13 14:28 ` dkwo
2021-05-13 14:31 ` dkwo
2021-05-13 14:31 ` [PR PATCH] [Closed]: " dkwo
2021-05-13 14:34 ` ericonr
2021-05-13 14:42 ` dkwo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).