Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] font-iosevka: add Aile and Etoile version
@ 2021-05-13 13:02 kozachynskyi
  2021-05-13 18:22 ` FollieHiyuki
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: kozachynskyi @ 2021-05-13 13:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

There is a new pull request by kozachynskyi against master on the void-packages repository

https://github.com/kozachynskyi/void-packages master
https://github.com/void-linux/void-packages/pull/30830

font-iosevka: add Aile and Etoile version
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30830.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-30830.patch --]
[-- Type: text/x-diff, Size: 1885 bytes --]

From ef0729704470a23797a821229905a5008fc46893 Mon Sep 17 00:00:00 2001
From: Volodymyr Kozachynskyi <vovakozach@gmail.com>
Date: Thu, 13 May 2021 14:57:17 +0200
Subject: [PATCH] font-iosevka: add Aile and Etoile version

---
 srcpkgs/font-iosevka/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/font-iosevka/template b/srcpkgs/font-iosevka/template
index 1155320af055..84494ee0b64f 100644
--- a/srcpkgs/font-iosevka/template
+++ b/srcpkgs/font-iosevka/template
@@ -1,7 +1,7 @@
 # Template file for 'font-iosevka'
 pkgname=font-iosevka
 version=6.1.3
-revision=1
+revision=2
 create_wrksrc=yes
 depends="font-util"
 short_desc="Slender monospace sans-serif and slab-serif typeface"
@@ -10,10 +10,14 @@ license="OFL-1.1"
 homepage="https://typeof.net/Iosevka/"
 distfiles="https://raw.githubusercontent.com/be5invis/Iosevka/v${version}/LICENSE.md>LICENSE.txt
  https://github.com/be5invis/Iosevka/releases/download/v${version}/super-ttc-iosevka-${version}.zip
- https://github.com/be5invis/Iosevka/releases/download/v${version}/super-ttc-iosevka-slab-${version}.zip"
+ https://github.com/be5invis/Iosevka/releases/download/v${version}/super-ttc-iosevka-slab-${version}.zip
+ https://github.com/be5invis/Iosevka/releases/download/v${version}/super-ttc-iosevka-aile-${version}.zip
+ https://github.com/be5invis/Iosevka/releases/download/v${version}/super-ttc-iosevka-etoile-${version}.zip"
 checksum="72c3d557ff41d871680652f56afd565ba6834c90eadc45a4ec15410dce1c0c80
  4f2ae801cbcb24adb620d76484653cf5a5e8ebab7836031ab6e9e6a5c9b33529
- 03540b47cbd710c66a34f8e15449a8a0f6cf4065d63b22d7f0a5d092b53a4352"
+ 03540b47cbd710c66a34f8e15449a8a0f6cf4065d63b22d7f0a5d092b53a4352
+ 75780145daa2a66dec7a0fae61b44d97d7ee15f6ef65a79fecea7f5050d66e0f
+ 8e0af6b604b45af5c6d7dcbed22cfb5b48a2ae112e5911fb06c6dc80a622de3b"
 
 font_dirs="/usr/share/fonts/TTF"
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: font-iosevka: add Aile and Etoile version
  2021-05-13 13:02 [PR PATCH] font-iosevka: add Aile and Etoile version kozachynskyi
@ 2021-05-13 18:22 ` FollieHiyuki
  2021-05-13 19:29 ` kozachynskyi
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: FollieHiyuki @ 2021-05-13 18:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30830#issuecomment-840743795

Comment:
Hmm, then we also need to add `iosevka-curly` and `iosevka-curly-slab` for the completeness. At that point the package seems kinda bloated :)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: font-iosevka: add Aile and Etoile version
  2021-05-13 13:02 [PR PATCH] font-iosevka: add Aile and Etoile version kozachynskyi
  2021-05-13 18:22 ` FollieHiyuki
@ 2021-05-13 19:29 ` kozachynskyi
  2021-05-13 19:43 ` FollieHiyuki
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: kozachynskyi @ 2021-05-13 19:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New comment by kozachynskyi on void-packages repository

https://github.com/void-linux/void-packages/pull/30830#issuecomment-840782332

Comment:
@FollieHiyuki That's a good point. I'm not familiar with how void-linux handles such questions about "bloat". Just wanted to open discussion. 

I think one should have all font Family Types provided in one package.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: font-iosevka: add Aile and Etoile version
  2021-05-13 13:02 [PR PATCH] font-iosevka: add Aile and Etoile version kozachynskyi
  2021-05-13 18:22 ` FollieHiyuki
  2021-05-13 19:29 ` kozachynskyi
@ 2021-05-13 19:43 ` FollieHiyuki
  2021-05-13 20:03 ` [PR PATCH] [Closed]: " kozachynskyi
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: FollieHiyuki @ 2021-05-13 19:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30830#issuecomment-840789873

Comment:
![iosevka](https://user-images.githubusercontent.com/67634026/118177671-851ba000-b422-11eb-930c-22c9d6e900ea.png)

I like to have all the variants packaged too since I use them all. The only problem here is that the font is rather heavy with only just the main variants (see picture above), and the updating frequency is quite often (around 2-3 times a month).

It all comes to "is it worth adding all the main variants with the sacrifice of bandwidth".

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: font-iosevka: add Aile and Etoile version
  2021-05-13 13:02 [PR PATCH] font-iosevka: add Aile and Etoile version kozachynskyi
                   ` (2 preceding siblings ...)
  2021-05-13 19:43 ` FollieHiyuki
@ 2021-05-13 20:03 ` kozachynskyi
  2021-05-13 20:03 ` [PR PATCH] [Updated] " kozachynskyi
  2021-05-13 21:16 ` FollieHiyuki
  5 siblings, 0 replies; 7+ messages in thread
From: kozachynskyi @ 2021-05-13 20:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

There's a closed pull request on the void-packages repository

font-iosevka: add Aile and Etoile version
https://github.com/void-linux/void-packages/pull/30830

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] font-iosevka: add Aile and Etoile version
  2021-05-13 13:02 [PR PATCH] font-iosevka: add Aile and Etoile version kozachynskyi
                   ` (3 preceding siblings ...)
  2021-05-13 20:03 ` [PR PATCH] [Closed]: " kozachynskyi
@ 2021-05-13 20:03 ` kozachynskyi
  2021-05-13 21:16 ` FollieHiyuki
  5 siblings, 0 replies; 7+ messages in thread
From: kozachynskyi @ 2021-05-13 20:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by kozachynskyi against master on the void-packages repository

https://github.com/kozachynskyi/void-packages master
https://github.com/void-linux/void-packages/pull/30830

font-iosevka: add Aile and Etoile version
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30830.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-30830.patch --]
[-- Type: text/x-diff, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: font-iosevka: add Aile and Etoile version
  2021-05-13 13:02 [PR PATCH] font-iosevka: add Aile and Etoile version kozachynskyi
                   ` (4 preceding siblings ...)
  2021-05-13 20:03 ` [PR PATCH] [Updated] " kozachynskyi
@ 2021-05-13 21:16 ` FollieHiyuki
  5 siblings, 0 replies; 7+ messages in thread
From: FollieHiyuki @ 2021-05-13 21:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30830#issuecomment-840840094

Comment:
Please leave the PR open. We could hear some opinions from Void maintainers before deciding how we should go with it.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-05-13 21:16 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 13:02 [PR PATCH] font-iosevka: add Aile and Etoile version kozachynskyi
2021-05-13 18:22 ` FollieHiyuki
2021-05-13 19:29 ` kozachynskyi
2021-05-13 19:43 ` FollieHiyuki
2021-05-13 20:03 ` [PR PATCH] [Closed]: " kozachynskyi
2021-05-13 20:03 ` [PR PATCH] [Updated] " kozachynskyi
2021-05-13 21:16 ` FollieHiyuki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).