[PR PATCH] anydesk eula changed

[PR PATCH] anydesk eula changed

[MrFastDie]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

There is a new pull request by MrFastDie against master on the void-packages repository

https://github.com/MrFastDie/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30929

anydesk eula changed
The hash for the anydesk eula changed to 6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5

A patch file from https://github.com/void-linux/void-packages/pull/30929.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30929.patch --]
[-- Type: text/x-diff, Size: 888 bytes --]

From 7fb8e3bf78cb2802b44ca8373c4c15d75e98ef0c Mon Sep 17 00:00:00 2001
From: MrFastDie <43572759+MrFastDie@users.noreply.github.com>
Date: Sun, 16 May 2021 14:03:06 +0200
Subject: [PATCH] anydesk eula changed

---
 srcpkgs/anydesk/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/anydesk/template b/srcpkgs/anydesk/template
index 65f573bcf989..bf63b9d05c47 100644
--- a/srcpkgs/anydesk/template
+++ b/srcpkgs/anydesk/template
@@ -16,7 +16,7 @@ restricted=yes
 distfiles="https://download.anydesk.com/linux/anydesk_$version-1_x86_64.rpm"
 checksum=35772d898afa8cba0f410775fdd7e1e8e7b753130c906db94801895c0ea74754
 
-_eula_digest=f6386c15e187b6eac0ccd2564d3a873ae07d4b46a6b61dda13464caf5d54a319
+_eula_digest=6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5
 
 post_extract() {
 	$XBPS_FETCH_CMD -o eula.html https://anydesk.com/en/terms

Re: anydesk eula changed

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30929#issuecomment-841958576

Comment:
`=> ERROR: EULA changed, new digest: 32e6f0aad35f9df2aca67415460b7faf9adb4a7c9c4e60010bed109034edc61f`

This doesn't seem to be stable anymore? Given that the package is restricted, I would consider removing the EULA entirely.

Re: [PR PATCH] [Updated] anydesk eula changed

[MrFastDie]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

There is an updated pull request by MrFastDie against master on the void-packages repository

https://github.com/MrFastDie/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30929

anydesk eula changed
The hash for the anydesk eula changed to 6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5

A patch file from https://github.com/void-linux/void-packages/pull/30929.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30929.patch --]
[-- Type: text/x-diff, Size: 2002 bytes --]

From 7fb8e3bf78cb2802b44ca8373c4c15d75e98ef0c Mon Sep 17 00:00:00 2001
From: MrFastDie <43572759+MrFastDie@users.noreply.github.com>
Date: Sun, 16 May 2021 14:03:06 +0200
Subject: [PATCH 1/2] anydesk eula changed

---
 srcpkgs/anydesk/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/anydesk/template b/srcpkgs/anydesk/template
index 65f573bcf989..bf63b9d05c47 100644
--- a/srcpkgs/anydesk/template
+++ b/srcpkgs/anydesk/template
@@ -16,7 +16,7 @@ restricted=yes
 distfiles="https://download.anydesk.com/linux/anydesk_$version-1_x86_64.rpm"
 checksum=35772d898afa8cba0f410775fdd7e1e8e7b753130c906db94801895c0ea74754
 
-_eula_digest=f6386c15e187b6eac0ccd2564d3a873ae07d4b46a6b61dda13464caf5d54a319
+_eula_digest=6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5
 
 post_extract() {
 	$XBPS_FETCH_CMD -o eula.html https://anydesk.com/en/terms

From 66ee32e441268e7291d85c0bfa1af0b9145981cb Mon Sep 17 00:00:00 2001
From: MrFastDie <43572759+MrFastDie@users.noreply.github.com>
Date: Mon, 17 May 2021 16:45:54 +0200
Subject: [PATCH 2/2] removed eula check completely as suggested

---
 srcpkgs/anydesk/template | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/srcpkgs/anydesk/template b/srcpkgs/anydesk/template
index bf63b9d05c47..835d2c96e5cd 100644
--- a/srcpkgs/anydesk/template
+++ b/srcpkgs/anydesk/template
@@ -16,17 +16,11 @@ restricted=yes
 distfiles="https://download.anydesk.com/linux/anydesk_$version-1_x86_64.rpm"
 checksum=35772d898afa8cba0f410775fdd7e1e8e7b753130c906db94801895c0ea74754
 
-_eula_digest=6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5
-
 post_extract() {
 	$XBPS_FETCH_CMD -o eula.html https://anydesk.com/en/terms
 	< eula.html w3m -dump -I utf-8 -T text/html |
 	sed -n '/Terms [&] Conditions/,/envelope-p/{/envelope-p/!p}' >eula.txt
 
-	filesum="$($XBPS_DIGEST_CMD eula.txt)"
-	if [ "$filesum" != $_eula_digest ]; then
-		msg_error "EULA changed, new digest: $filesum\n"
-	fi
 }
 
 do_build() {

Re: anydesk eula changed

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30929#issuecomment-842668096

Comment:
The build will now fail in the `vlicense` line.

Re: [PR PATCH] [Updated] anydesk eula changed

[MrFastDie]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

There is an updated pull request by MrFastDie against master on the void-packages repository

https://github.com/MrFastDie/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30929

anydesk eula changed
The hash for the anydesk eula changed to 6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5

A patch file from https://github.com/void-linux/void-packages/pull/30929.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30929.patch --]
[-- Type: text/x-diff, Size: 3033 bytes --]

From 7fb8e3bf78cb2802b44ca8373c4c15d75e98ef0c Mon Sep 17 00:00:00 2001
From: MrFastDie <43572759+MrFastDie@users.noreply.github.com>
Date: Sun, 16 May 2021 14:03:06 +0200
Subject: [PATCH 1/3] anydesk eula changed

---
 srcpkgs/anydesk/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/anydesk/template b/srcpkgs/anydesk/template
index 65f573bcf989..bf63b9d05c47 100644
--- a/srcpkgs/anydesk/template
+++ b/srcpkgs/anydesk/template
@@ -16,7 +16,7 @@ restricted=yes
 distfiles="https://download.anydesk.com/linux/anydesk_$version-1_x86_64.rpm"
 checksum=35772d898afa8cba0f410775fdd7e1e8e7b753130c906db94801895c0ea74754
 
-_eula_digest=f6386c15e187b6eac0ccd2564d3a873ae07d4b46a6b61dda13464caf5d54a319
+_eula_digest=6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5
 
 post_extract() {
 	$XBPS_FETCH_CMD -o eula.html https://anydesk.com/en/terms

From 66ee32e441268e7291d85c0bfa1af0b9145981cb Mon Sep 17 00:00:00 2001
From: MrFastDie <43572759+MrFastDie@users.noreply.github.com>
Date: Mon, 17 May 2021 16:45:54 +0200
Subject: [PATCH 2/3] removed eula check completely as suggested

---
 srcpkgs/anydesk/template | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/srcpkgs/anydesk/template b/srcpkgs/anydesk/template
index bf63b9d05c47..835d2c96e5cd 100644
--- a/srcpkgs/anydesk/template
+++ b/srcpkgs/anydesk/template
@@ -16,17 +16,11 @@ restricted=yes
 distfiles="https://download.anydesk.com/linux/anydesk_$version-1_x86_64.rpm"
 checksum=35772d898afa8cba0f410775fdd7e1e8e7b753130c906db94801895c0ea74754
 
-_eula_digest=6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5
-
 post_extract() {
 	$XBPS_FETCH_CMD -o eula.html https://anydesk.com/en/terms
 	< eula.html w3m -dump -I utf-8 -T text/html |
 	sed -n '/Terms [&] Conditions/,/envelope-p/{/envelope-p/!p}' >eula.txt
 
-	filesum="$($XBPS_DIGEST_CMD eula.txt)"
-	if [ "$filesum" != $_eula_digest ]; then
-		msg_error "EULA changed, new digest: $filesum\n"
-	fi
 }
 
 do_build() {

From 09062ef76b01a451a843dc315dc15f1264ed701f Mon Sep 17 00:00:00 2001
From: MrFastDie <dhackbarth@extr3m.com>
Date: Tue, 18 May 2021 16:23:33 +0200
Subject: [PATCH 3/3] removed eula copy entirely

---
 srcpkgs/anydesk/template | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/srcpkgs/anydesk/template b/srcpkgs/anydesk/template
index 835d2c96e5cd..d782908bebbf 100644
--- a/srcpkgs/anydesk/template
+++ b/srcpkgs/anydesk/template
@@ -16,13 +16,6 @@ restricted=yes
 distfiles="https://download.anydesk.com/linux/anydesk_$version-1_x86_64.rpm"
 checksum=35772d898afa8cba0f410775fdd7e1e8e7b753130c906db94801895c0ea74754
 
-post_extract() {
-	$XBPS_FETCH_CMD -o eula.html https://anydesk.com/en/terms
-	< eula.html w3m -dump -I utf-8 -T text/html |
-	sed -n '/Terms [&] Conditions/,/envelope-p/{/envelope-p/!p}' >eula.txt
-
-}
-
 do_build() {
 	patchelf --remove-needed libpangox-1.0.so.0 usr/bin/anydesk
 }
@@ -30,5 +23,4 @@ do_build() {
 do_install() {
 	vcopy usr/share usr
 	vbin usr/bin/anydesk
-	vlicense eula.txt
 }

Re: anydesk eula changed

[MrFastDie]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

New comment by MrFastDie on void-packages repository

https://github.com/void-linux/void-packages/pull/30929#issuecomment-843217266

Comment:
I tested the run the `./xbps pkg anydesk` finished flawless - also I understand the `vlicense` line as copying the license to the desired folder (and the eula still got downloaded in the `post_install()` ) - But now I removed the postinstall and the vlicense and the project still works. I don't know if we dont want to have the eula or not - but as suggested I got the vlicense out.

Re: anydesk eula changed

[sgn]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/30929#issuecomment-843281311

Comment:
I oppose the decision to remove `vlicense eula`. I don't think playing politic game is safe.

Re: anydesk eula changed

[MrFastDie]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by MrFastDie on void-packages repository

https://github.com/void-linux/void-packages/pull/30929#issuecomment-843313723

Comment:
> I oppose the decision to remove `vlicense eula`. I don't think playing politic game is safe.

So which of the three resolutions do we want to have? 

Re: anydesk eula changed

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30929#issuecomment-843321292

Comment:
My reasoning is that removing the EULA is ok, because it's a restricted package. Since it isn't versioned, it breaks the build regularly, and fetching it without a checksum feels kinda dirty.

Removing the EULA is the simplest solution to keep it in repo.

But if you prefer to keep it in, feel free. Removing the EULA isn't ideal, just a compromise I was ok with.

Re: anydesk eula changed

[sgn]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/30929#issuecomment-843335118

Comment:
https://github.com/void-linux/void-packages/commit/550b51c2d7205cef97cc7113e6914f1ab85985d9

Re: [PR PATCH] [Closed]: anydesk eula changed

[sgn]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

There's a closed pull request on the void-packages repository

anydesk eula changed
https://github.com/void-linux/void-packages/pull/30929

Description:
The hash for the anydesk eula changed to 6e638faec127a59a7f43027d656d124fcb214a02044667b88ec9de7449dd82a5