* [PR PATCH] git-team: update to 1.6.0.
@ 2021-05-16 16:34 steinex
2021-05-17 3:15 ` [PR REVIEW] " ericonr
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: steinex @ 2021-05-16 16:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
There is a new pull request by steinex against master on the void-packages repository
https://github.com/steinex/void-packages git-team
https://github.com/void-linux/void-packages/pull/30936
git-team: update to 1.6.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30936.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-git-team-30936.patch --]
[-- Type: text/x-diff, Size: 1323 bytes --]
From f21dbd59d8c7bc3e94fcd8806515ffc719001685 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Sun, 16 May 2021 18:18:52 +0200
Subject: [PATCH] git-team: update to 1.6.0.
---
srcpkgs/git-team/template | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/git-team/template b/srcpkgs/git-team/template
index e6e2002a7d2c..3a86c11a80f5 100644
--- a/srcpkgs/git-team/template
+++ b/srcpkgs/git-team/template
@@ -1,19 +1,16 @@
# Template file for 'git-team'
pkgname=git-team
-version=1.5.5
+version=1.6.0
revision=1
build_style=go
go_import_path=github.com/hekmekk/git-team
-go_package="${go_import_path}/cmd/git-team ${go_import_path}/cmd/prepare-commit-msg"
short_desc="Manage and enhance git commit messages with co-authors"
maintainer="Frank Steinborn <steinex@nognu.de>"
license="MIT"
homepage="https://github.com/hekmekk/git-team"
distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=bc88552e78ad67327b153cdc5aeb01ddcb5a99579787a68177fae7aa1a20c27b
+checksum=d474d759b81a458519c47059990d12808df28d4b313a69234aaa9574a70da723
post_install() {
vlicense LICENSE
- mv ${DESTDIR}/usr/bin/prepare-commit-msg ${DESTDIR}/usr/bin/prepare-commit-msg-git-team
- vinstall bash_completion/git-team.bash 0644 usr/share/bash-completion/completions git-team
}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] git-team: update to 1.6.0.
2021-05-16 16:34 [PR PATCH] git-team: update to 1.6.0 steinex
@ 2021-05-17 3:15 ` ericonr
2021-05-17 5:41 ` steinex
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-05-17 3:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30936#discussion_r633196994
Comment:
Can you explain these removals in the commit message? (were the files removed? did something change how they work? ...)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] git-team: update to 1.6.0.
2021-05-16 16:34 [PR PATCH] git-team: update to 1.6.0 steinex
2021-05-17 3:15 ` [PR REVIEW] " ericonr
@ 2021-05-17 5:41 ` steinex
2021-05-17 12:33 ` ericonr
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: steinex @ 2021-05-17 5:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
New review comment by steinex on void-packages repository
https://github.com/void-linux/void-packages/pull/30936#discussion_r633234586
Comment:
* The mv isn't necessary anymore, because prepare-commit-msg isn't shipped anymore as a seperate script, instead it get's created on demand in `~/.git-team/hooks` by the main git-team binary.
* The bash completion file indeed is gone, instead there is the `git-team completion` command now which one can use in their bash startup scripts to source completion for git-team.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] git-team: update to 1.6.0.
2021-05-16 16:34 [PR PATCH] git-team: update to 1.6.0 steinex
2021-05-17 3:15 ` [PR REVIEW] " ericonr
2021-05-17 5:41 ` steinex
@ 2021-05-17 12:33 ` ericonr
2021-05-17 12:39 ` [PR PATCH] [Updated] " steinex
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-05-17 12:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30936#discussion_r633489483
Comment:
Can you just copy your comment comment into the commit message, then?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] git-team: update to 1.6.0.
2021-05-16 16:34 [PR PATCH] git-team: update to 1.6.0 steinex
` (2 preceding siblings ...)
2021-05-17 12:33 ` ericonr
@ 2021-05-17 12:39 ` steinex
2021-05-17 12:41 ` [PR REVIEW] " steinex
2021-05-17 13:06 ` [PR PATCH] [Merged]: " ericonr
5 siblings, 0 replies; 7+ messages in thread
From: steinex @ 2021-05-17 12:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]
There is an updated pull request by steinex against master on the void-packages repository
https://github.com/steinex/void-packages git-team
https://github.com/void-linux/void-packages/pull/30936
git-team: update to 1.6.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30936.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-git-team-30936.patch --]
[-- Type: text/x-diff, Size: 1643 bytes --]
From c2c680b2db9deab31915b1f36168c97655d59464 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Sun, 16 May 2021 18:18:52 +0200
Subject: [PATCH] git-team: update to 1.6.0.
- dropped installation of /usr/bin/prepare-commit-message-git-team, it
gets installed on-demand now by the main git-team binary into
~/.git-team/hooks.
- dropped bash completion, one is supposed to source the output of
`git-team completion` into their shell startup scripts now (only bash
is supported for now).
---
srcpkgs/git-team/template | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/git-team/template b/srcpkgs/git-team/template
index e6e2002a7d2c..3a86c11a80f5 100644
--- a/srcpkgs/git-team/template
+++ b/srcpkgs/git-team/template
@@ -1,19 +1,16 @@
# Template file for 'git-team'
pkgname=git-team
-version=1.5.5
+version=1.6.0
revision=1
build_style=go
go_import_path=github.com/hekmekk/git-team
-go_package="${go_import_path}/cmd/git-team ${go_import_path}/cmd/prepare-commit-msg"
short_desc="Manage and enhance git commit messages with co-authors"
maintainer="Frank Steinborn <steinex@nognu.de>"
license="MIT"
homepage="https://github.com/hekmekk/git-team"
distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=bc88552e78ad67327b153cdc5aeb01ddcb5a99579787a68177fae7aa1a20c27b
+checksum=d474d759b81a458519c47059990d12808df28d4b313a69234aaa9574a70da723
post_install() {
vlicense LICENSE
- mv ${DESTDIR}/usr/bin/prepare-commit-msg ${DESTDIR}/usr/bin/prepare-commit-msg-git-team
- vinstall bash_completion/git-team.bash 0644 usr/share/bash-completion/completions git-team
}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] git-team: update to 1.6.0.
2021-05-16 16:34 [PR PATCH] git-team: update to 1.6.0 steinex
` (3 preceding siblings ...)
2021-05-17 12:39 ` [PR PATCH] [Updated] " steinex
@ 2021-05-17 12:41 ` steinex
2021-05-17 13:06 ` [PR PATCH] [Merged]: " ericonr
5 siblings, 0 replies; 7+ messages in thread
From: steinex @ 2021-05-17 12:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New review comment by steinex on void-packages repository
https://github.com/void-linux/void-packages/pull/30936#discussion_r633494647
Comment:
reworded a bit but done.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Merged]: git-team: update to 1.6.0.
2021-05-16 16:34 [PR PATCH] git-team: update to 1.6.0 steinex
` (4 preceding siblings ...)
2021-05-17 12:41 ` [PR REVIEW] " steinex
@ 2021-05-17 13:06 ` ericonr
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-05-17 13:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
There's a merged pull request on the void-packages repository
git-team: update to 1.6.0.
https://github.com/void-linux/void-packages/pull/30936
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-17 13:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-16 16:34 [PR PATCH] git-team: update to 1.6.0 steinex
2021-05-17 3:15 ` [PR REVIEW] " ericonr
2021-05-17 5:41 ` steinex
2021-05-17 12:33 ` ericonr
2021-05-17 12:39 ` [PR PATCH] [Updated] " steinex
2021-05-17 12:41 ` [PR REVIEW] " steinex
2021-05-17 13:06 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).