[PR PATCH] kdeconnect: add qt5-quickcontrols to depends

[PR PATCH] kdeconnect: add qt5-quickcontrols to depends

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

There is a new pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages kdeconnect-hmm
https://github.com/void-linux/void-packages/pull/31305

kdeconnect: add qt5-quickcontrols to depends
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Fixes #31302

I did it for you, @Cnoob41. Is this ok?


A patch file from https://github.com/void-linux/void-packages/pull/31305.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kdeconnect-hmm-31305.patch --]
[-- Type: text/x-diff, Size: 1063 bytes --]

From e386c18a13fd95ec1c0cd9eb91258ee9577e2fe1 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sat, 5 Jun 2021 14:24:18 +0300
Subject: [PATCH] kdeconnect: add qt5-quickcontrols to depends

Fixes #31302
---
 srcpkgs/kdeconnect/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index 0a2d25d877ba..f101dd1b054c 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -9,7 +9,7 @@ hostmakedepends="extra-cmake-modules qt5-host-tools pkg-config
 makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-2.0-or-later"

Re: kdeconnect: add qt5-quickcontrols to depends

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31305#issuecomment-855227781

Comment:
You should also increase the revision by one, so it also gets rebuild for the repo.

Re: [PR PATCH] [Updated] kdeconnect: add qt5-quickcontrols to depends

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 1657 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages kdeconnect-hmm
https://github.com/void-linux/void-packages/pull/31305

kdeconnect: add qt5-quickcontrols to depends
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Fixes #31302

I did it for you, @Cnoob41. Is this ok?


A patch file from https://github.com/void-linux/void-packages/pull/31305.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kdeconnect-hmm-31305.patch --]
[-- Type: text/x-diff, Size: 1297 bytes --]

From c04b2a79edd31c047f1c5894719cc988cec9bf1f Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sat, 5 Jun 2021 14:24:18 +0300
Subject: [PATCH] kdeconnect: add qt5-quickcontrols to depends

Fixes #31302
---
 srcpkgs/kdeconnect/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index 0a2d25d877ba..a9c30160b32a 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -1,7 +1,7 @@
 # Template file for 'kdeconnect'
 pkgname=kdeconnect
 version=21.04.1
-revision=1
+revision=2
 wrksrc="kdeconnect-kde-${version}"
 build_style=cmake
 hostmakedepends="extra-cmake-modules qt5-host-tools pkg-config
@@ -9,7 +9,7 @@ hostmakedepends="extra-cmake-modules qt5-host-tools pkg-config
 makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-2.0-or-later"

Re: kdeconnect: add qt5-quickcontrols to depends

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31305#issuecomment-855228424

Comment:
> You should also increase the revision by one, so it also gets rebuild for the repo.

 Yes I forgot that

Re: kdeconnect: add qt5-quickcontrols to depends

[Cnoob41]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by Cnoob41 on void-packages repository

https://github.com/void-linux/void-packages/pull/31305#issuecomment-855231687

Comment:
Thanks, this should make kdeconnect work.

Re: [PR PATCH] [Merged]: kdeconnect: add qt5-quickcontrols to depends

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

There's a merged pull request on the void-packages repository

kdeconnect: add qt5-quickcontrols to depends
https://github.com/void-linux/void-packages/pull/31305

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Fixes #31302

I did it for you, @Cnoob41. Is this ok?