[PR PATCH] samba: fix nss modules for musl.

[PR PATCH] samba: fix nss modules for musl.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages samba
https://github.com/void-linux/void-packages/pull/31649

samba: fix nss modules for musl.
nss modules from samba, like libnss_winbind, will be used by
musl-nscd-devel, and therefore should use its headers for the
definitions of return values and others.

Without musl-nscd-devel to provide <nss.h>, samba uses a fallback header
that carries completely incompatible return value definitions.

@ahesford 

Another issue with the package is that it's missing `samba-tools`. We have yet to find it,

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31649.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-samba-31649.patch --]
[-- Type: text/x-diff, Size: 1304 bytes --]

From 1dbcf9c1cbda2e21029f641631975998ff06eab2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Fri, 25 Jun 2021 01:15:15 -0300
Subject: [PATCH] samba: fix nss modules for musl.

nss modules from samba, like libnss_winbind, will be used by
musl-nscd-devel, and therefore should use its headers for the
definitions of return values and others.

Without musl-nscd-devel to provide <nss.h>, samba uses a fallback header
that carries completely incompatible return value definitions.
---
 srcpkgs/samba/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/samba/template b/srcpkgs/samba/template
index 90be22e57059..427ff90b5c59 100644
--- a/srcpkgs/samba/template
+++ b/srcpkgs/samba/template
@@ -1,7 +1,7 @@
 # Template file for 'samba'
 pkgname=samba
 version=4.13.4
-revision=1
+revision=2
 build_style=waf3
 build_helper="qemu"
 configure_script="buildtools/bin/waf"
@@ -34,7 +34,7 @@ make_dirs="/etc/samba/private 0750 root root"
 subpackages="smbclient samba-ctdb samba-cups samba-devel samba-libs samba-python3"
 
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
-	makedepends+=" musl-legacy-compat"
+	makedepends+=" musl-legacy-compat musl-nscd-devel"
 else
 	makedepends+=" glusterfs-devel"
 	subpackages+=" samba-glusterfs"

Re: samba: fix nss modules for musl.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/31649#issuecomment-868406884

Comment:
Re: `samba-tool`, I claim I  https://github.com/void-linux/void-packages/pull/27626#issuecomment-753665650 that it only builds when the experimental `--with-ad-dc` option is specified and I didn't want to enable an experimental option. I don't know if the status of this option has changed or its impact on dependencies.

It looks like we are several releases behind. Should we fold this into a version bunp?
 

Re: [PR PATCH] [Closed]: samba: fix nss modules for musl.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]

There's a closed pull request on the void-packages repository

samba: fix nss modules for musl.
https://github.com/void-linux/void-packages/pull/31649

Description:
nss modules from samba, like libnss_winbind, will be used by
musl-nscd-devel, and therefore should use its headers for the
definitions of return values and others.

Without musl-nscd-devel to provide <nss.h>, samba uses a fallback header
that carries completely incompatible return value definitions.

@ahesford 

Another issue with the package is that it's missing `samba-tools`. We have yet to find it,

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: samba: fix nss modules for musl.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31649#issuecomment-868534675

Comment:
What release branch would you like to target? Update inside 4.15 or 4.13?

The Alpine package seems to ship `samba-tool`: https://pkgs.alpinelinux.org/contents?branch=v3.13&name=samba-dc&arch=x86_64&repo=main but I don't see the option you mentioned in https://git.alpinelinux.org/aports/tree/main/samba/APKBUILD?h=3.13-stable

AD DC supposedly requires heimdal, which explains why it's experimental with krb5. Maybe `--with-ads` is the correct option?

Re: samba: fix nss modules for musl.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/31649#issuecomment-868541064

Comment:
I'm looking at 4.14.5 now, we'll see if that turns into more work than I'd like. Alpine builds with vendored heimdal; maybe `--with-ad-dc` is implied in that case. I'm not sure though.

Re: samba: fix nss modules for musl.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31649#issuecomment-869066803

Comment:
Will be included in #31655 

Re: [PR PATCH] [Closed]: samba: fix nss modules for musl.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]

There's a closed pull request on the void-packages repository

samba: fix nss modules for musl.
https://github.com/void-linux/void-packages/pull/31649

Description:
nss modules from samba, like libnss_winbind, will be used by
musl-nscd-devel, and therefore should use its headers for the
definitions of return values and others.

Without musl-nscd-devel to provide <nss.h>, samba uses a fallback header
that carries completely incompatible return value definitions.

@ahesford 

Another issue with the package is that it's missing `samba-tools`. We have yet to find it,

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->