[PR PATCH] grub: compile with -Os

[PR PATCH] grub: compile with -Os

[Ophidiophobia]

[-- Attachment #1: Type: text/plain, Size: 2086 bytes --]

There is a new pull request by Ophidiophobia against master on the void-packages repository

https://github.com/Ophidiophobia/void-packages grub
https://github.com/void-linux/void-packages/pull/31795

grub: compile with -Os
Avoids being stuck at "GRUB loading." when booting through legacy BIOS

I built and configured the image of a new VM and when starting that image with qemu I was stuck very early with "GRUB loading.". Somebody on IRC was having the same problem and provided links which said it was because of how grub is compiled. (see changed template for sources)
I have created the VM image multiple times with and without the change and it always failed without the change and always succeeded with the change.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/31795.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grub-31795.patch --]
[-- Type: text/x-diff, Size: 1262 bytes --]

From ad07bcbb0299dd8057178b3cf86c3c45fc347bcb Mon Sep 17 00:00:00 2001
From: Ophidiophobia <sandstrahl700@gmx.de>
Date: Sun, 4 Jul 2021 19:04:01 +0200
Subject: [PATCH] grub: compile with -Os

Avoids being stuck at "GRUB loading." when booting through legacy BIOS
---
 srcpkgs/grub/template | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/grub/template b/srcpkgs/grub/template
index bf10fc663483..d9680429250b 100644
--- a/srcpkgs/grub/template
+++ b/srcpkgs/grub/template
@@ -1,7 +1,7 @@
 # Template file for 'grub'
 pkgname=grub
 version=2.06
-revision=1
+revision=2
 hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf help2man"
 makedepends="libusb-compat-devel ncurses-devel freetype-devel
  liblzma-devel device-mapper-devel fuse-devel"
@@ -44,6 +44,13 @@ case "$XBPS_TARGET_MACHINE" in
 esac
 
 do_configure() {
+	# workaround for https://savannah.gnu.org/bugs/?60458
+	# some more info: https://www.linuxquestions.org/questions/showthread.php?p=6257712
+	# grub 2.06 reboots immediately when compiled with -O2
+	# only effects legacy BIOS
+	export CFLAGS="${CFLAGS/-O2/-Os}"
+	export CXXFLAGS="${CXXFLAGS/-O2/-Os}"
+
 	unset CC AS LD RANLIB CPP
 	local freestanding_cflags="-fno-stack-protector"
 

Re: grub: compile with -Os

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31795#issuecomment-873659360

Comment:
Thanks for the investigation, I will leave it open for a bit and merge if no one complains.

Re: grub: compile with -Os

[sorathpanzer]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by sorathpanzer on void-packages repository

https://github.com/void-linux/void-packages/pull/31795#issuecomment-873666039

Comment:
I confirm, i had had the same problem in a physical installation in my legacy Bios laptop, after the grub has been updated to this version.

Re: grub: compile with -Os

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31795#issuecomment-873673539

Comment:
Oh so that was the reason why I borked those VMs in https://github.com/void-linux/void-packages/pull/31432#issuecomment-862263597

Thanks for the investigation

Re: [PR PATCH] [Closed]: grub: compile with -Os

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]

There's a closed pull request on the void-packages repository

grub: compile with -Os
https://github.com/void-linux/void-packages/pull/31795

Description:
Avoids being stuck at "GRUB loading." when booting through legacy BIOS

I built and configured the image of a new VM and when starting that image with qemu I was stuck very early with "GRUB loading.". Somebody on IRC was having the same problem and provided links which said it was because of how grub is compiled. (see changed template for sources)
I have created the VM image multiple times with and without the change and it always failed without the change and always succeeded with the change.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Re: grub: compile with -Os

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31795#issuecomment-873683310

Comment:
Fixed the commit message and pushed, thank you very much!

Re: grub: compile with -Os

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31795#issuecomment-873685604

Comment:
(also a typo in the template)