Github messages for voidlinux
 help / color / mirror / Atom feed
From: arp242 <arp242@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Install static libraries for libxcb-devel
Date: Wed, 14 Jul 2021 16:29:21 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31959@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]

There is a new pull request by arp242 against master on the void-packages repository

https://github.com/arp242/void-packages xcb-static
https://github.com/void-linux/void-packages/pull/31959

Install static libraries for libxcb-devel
So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xcb-static-31959.patch --]
[-- Type: text/x-diff, Size: 1402 bytes --]

From 15e241baeda39bc7e8c678d7b77a5d1a64d55aca Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Wed, 14 Jul 2021 22:17:22 +0800
Subject: [PATCH] Install static libraries for libxcb-devel
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changes in commit 9526648, in 2012) 🤔
---
 srcpkgs/libxcb/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/libxcb/template b/srcpkgs/libxcb/template
index 0f8ab5564243..07c61410b955 100644
--- a/srcpkgs/libxcb/template
+++ b/srcpkgs/libxcb/template
@@ -3,7 +3,7 @@ pkgname=libxcb
 version=1.14
 revision=1
 build_style=gnu-configure
-configure_args="--disable-build-docs --disable-static --enable-xinput --enable-xkb"
+configure_args="--disable-build-docs --enable-xinput --enable-xkb"
 hostmakedepends="libtool pkg-config xorg-util-macros xcb-proto"
 makedepends="xcb-proto libXdmcp-devel libXau-devel"
 short_desc="X protocol C-language Binding"
@@ -25,5 +25,6 @@ libxcb-devel_package() {
 		vmove usr/share
 		vmove usr/lib/pkgconfig
 		vmove "usr/lib/*.so"
+		vmove "usr/lib/*.a"
 	}
 }

             reply	other threads:[~2021-07-14 14:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 14:29 arp242 [this message]
2021-07-14 14:30 ` [PR PATCH] [Updated] libxcb-devel: install static libraries arp242
2021-07-14 14:31 ` arp242
2021-07-14 14:48 ` ericonr
2021-07-14 14:49 ` [PR PATCH] [Updated] " arp242
2021-07-14 14:50 ` arp242
2021-07-14 14:50 ` arp242
2021-07-14 14:56 ` ericonr
2021-07-14 15:26 ` [PR PATCH] [Updated] " arp242
2021-07-14 15:27 ` arp242
2021-07-14 15:43 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31959@inbox.vuxu.org \
    --to=arp242@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).