[PR PATCH] Install static libraries for libxcb-devel

[PR PATCH] Install static libraries for libxcb-devel

[arp242]

[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]

There is a new pull request by arp242 against master on the void-packages repository

https://github.com/arp242/void-packages xcb-static
https://github.com/void-linux/void-packages/pull/31959

Install static libraries for libxcb-devel
So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xcb-static-31959.patch --]
[-- Type: text/x-diff, Size: 1402 bytes --]

From 15e241baeda39bc7e8c678d7b77a5d1a64d55aca Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Wed, 14 Jul 2021 22:17:22 +0800
Subject: [PATCH] Install static libraries for libxcb-devel
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changes in commit 9526648, in 2012) 🤔
---
 srcpkgs/libxcb/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/libxcb/template b/srcpkgs/libxcb/template
index 0f8ab5564243..07c61410b955 100644
--- a/srcpkgs/libxcb/template
+++ b/srcpkgs/libxcb/template
@@ -3,7 +3,7 @@ pkgname=libxcb
 version=1.14
 revision=1
 build_style=gnu-configure
-configure_args="--disable-build-docs --disable-static --enable-xinput --enable-xkb"
+configure_args="--disable-build-docs --enable-xinput --enable-xkb"
 hostmakedepends="libtool pkg-config xorg-util-macros xcb-proto"
 makedepends="xcb-proto libXdmcp-devel libXau-devel"
 short_desc="X protocol C-language Binding"
@@ -25,5 +25,6 @@ libxcb-devel_package() {
 		vmove usr/share
 		vmove usr/lib/pkgconfig
 		vmove "usr/lib/*.so"
+		vmove "usr/lib/*.a"
 	}
 }

Re: [PR PATCH] [Updated] libxcb-devel: install static libraries

[arp242]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

There is an updated pull request by arp242 against master on the void-packages repository

https://github.com/arp242/void-packages xcb-static
https://github.com/void-linux/void-packages/pull/31959

libxcb-devel: install static libraries
So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xcb-static-31959.patch --]
[-- Type: text/x-diff, Size: 1399 bytes --]

From 32daf81ede69f7c20b0ab48bffe39f6cbb7babb9 Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Wed, 14 Jul 2021 22:17:22 +0800
Subject: [PATCH] libxcb-devel: install static libraries
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔
---
 srcpkgs/libxcb/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/libxcb/template b/srcpkgs/libxcb/template
index 0f8ab5564243..07c61410b955 100644
--- a/srcpkgs/libxcb/template
+++ b/srcpkgs/libxcb/template
@@ -3,7 +3,7 @@ pkgname=libxcb
 version=1.14
 revision=1
 build_style=gnu-configure
-configure_args="--disable-build-docs --disable-static --enable-xinput --enable-xkb"
+configure_args="--disable-build-docs --enable-xinput --enable-xkb"
 hostmakedepends="libtool pkg-config xorg-util-macros xcb-proto"
 makedepends="xcb-proto libXdmcp-devel libXau-devel"
 short_desc="X protocol C-language Binding"
@@ -25,5 +25,6 @@ libxcb-devel_package() {
 		vmove usr/share
 		vmove usr/lib/pkgconfig
 		vmove "usr/lib/*.so"
+		vmove "usr/lib/*.a"
 	}
 }

Re: [PR PATCH] [Updated] libxcb-devel: install static libraries

[arp242]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

There is an updated pull request by arp242 against master on the void-packages repository

https://github.com/arp242/void-packages xcb-static
https://github.com/void-linux/void-packages/pull/31959

libxcb-devel: install static libraries
So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xcb-static-31959.patch --]
[-- Type: text/x-diff, Size: 1445 bytes --]

From 9eeb15bbd1deda537541e90c2abb11b590fd0fec Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Wed, 14 Jul 2021 22:17:22 +0800
Subject: [PATCH] libxcb-devel: install static libraries
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔
---
 srcpkgs/libxcb/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/libxcb/template b/srcpkgs/libxcb/template
index 0f8ab5564243..73ca6d5aa008 100644
--- a/srcpkgs/libxcb/template
+++ b/srcpkgs/libxcb/template
@@ -1,9 +1,9 @@
 # Template file for 'libxcb'
 pkgname=libxcb
 version=1.14
-revision=1
+revision=2
 build_style=gnu-configure
-configure_args="--disable-build-docs --disable-static --enable-xinput --enable-xkb"
+configure_args="--disable-build-docs --enable-xinput --enable-xkb"
 hostmakedepends="libtool pkg-config xorg-util-macros xcb-proto"
 makedepends="xcb-proto libXdmcp-devel libXau-devel"
 short_desc="X protocol C-language Binding"
@@ -25,5 +25,6 @@ libxcb-devel_package() {
 		vmove usr/share
 		vmove usr/lib/pkgconfig
 		vmove "usr/lib/*.so"
+		vmove "usr/lib/*.a"
 	}
 }

Re: libxcb-devel: install static libraries

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31959#issuecomment-879957966

Comment:
Commit should still be `libxcb:...`

Re: [PR PATCH] [Updated] libxcb-devel: install static libraries

[arp242]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

There is an updated pull request by arp242 against master on the void-packages repository

https://github.com/arp242/void-packages xcb-static
https://github.com/void-linux/void-packages/pull/31959

libxcb-devel: install static libraries
So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xcb-static-31959.patch --]
[-- Type: text/x-diff, Size: 1457 bytes --]

From 688df95b9af029d094e47c4d90080dc666634525 Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Wed, 14 Jul 2021 22:17:22 +0800
Subject: [PATCH] libxcb: install static libraries in -devel package
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔
---
 srcpkgs/libxcb/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/libxcb/template b/srcpkgs/libxcb/template
index 0f8ab5564243..73ca6d5aa008 100644
--- a/srcpkgs/libxcb/template
+++ b/srcpkgs/libxcb/template
@@ -1,9 +1,9 @@
 # Template file for 'libxcb'
 pkgname=libxcb
 version=1.14
-revision=1
+revision=2
 build_style=gnu-configure
-configure_args="--disable-build-docs --disable-static --enable-xinput --enable-xkb"
+configure_args="--disable-build-docs --enable-xinput --enable-xkb"
 hostmakedepends="libtool pkg-config xorg-util-macros xcb-proto"
 makedepends="xcb-proto libXdmcp-devel libXau-devel"
 short_desc="X protocol C-language Binding"
@@ -25,5 +25,6 @@ libxcb-devel_package() {
 		vmove usr/share
 		vmove usr/lib/pkgconfig
 		vmove "usr/lib/*.so"
+		vmove "usr/lib/*.a"
 	}
 }

Re: libxcb-devel: install static libraries

[arp242]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by arp242 on void-packages repository

https://github.com/void-linux/void-packages/pull/31959#issuecomment-879959184

Comment:
Oh yeah, update it.

Re: libxcb-devel: install static libraries

[arp242]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by arp242 on void-packages repository

https://github.com/void-linux/void-packages/pull/31959#issuecomment-879959184

Comment:
Oh yeah, updated it.

Re: libxcb-devel: install static libraries

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31959#issuecomment-879963828

Comment:
I think you can remove

```
Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) thinking
```

from the commit, you are correct in how static linking works. And yeah, it can be unpopular.

Re: [PR PATCH] [Updated] libxcb-devel: install static libraries

[arp242]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

There is an updated pull request by arp242 against master on the void-packages repository

https://github.com/arp242/void-packages xcb-static
https://github.com/void-linux/void-packages/pull/31959

libxcb-devel: install static libraries
So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31959.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xcb-static-31959.patch --]
[-- Type: text/x-diff, Size: 1162 bytes --]

From 03ffbbd5d11aadf6eb62a777c96932bbd8a2ce2e Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Wed, 14 Jul 2021 22:17:22 +0800
Subject: [PATCH] libxcb: install static libraries in -devel package

So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.
---
 srcpkgs/libxcb/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/libxcb/template b/srcpkgs/libxcb/template
index 0f8ab5564243..73ca6d5aa008 100644
--- a/srcpkgs/libxcb/template
+++ b/srcpkgs/libxcb/template
@@ -1,9 +1,9 @@
 # Template file for 'libxcb'
 pkgname=libxcb
 version=1.14
-revision=1
+revision=2
 build_style=gnu-configure
-configure_args="--disable-build-docs --disable-static --enable-xinput --enable-xkb"
+configure_args="--disable-build-docs --enable-xinput --enable-xkb"
 hostmakedepends="libtool pkg-config xorg-util-macros xcb-proto"
 makedepends="xcb-proto libXdmcp-devel libXau-devel"
 short_desc="X protocol C-language Binding"
@@ -25,5 +25,6 @@ libxcb-devel_package() {
 		vmove usr/share
 		vmove usr/lib/pkgconfig
 		vmove "usr/lib/*.so"
+		vmove "usr/lib/*.a"
 	}
 }

Re: libxcb-devel: install static libraries

[arp242]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by arp242 on void-packages repository

https://github.com/void-linux/void-packages/pull/31959#issuecomment-879989542

Comment:
I shouldn't make PRs when I'm tired

Re: [PR PATCH] [Merged]: libxcb-devel: install static libraries

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

There's a merged pull request on the void-packages repository

libxcb-devel: install static libraries
https://github.com/void-linux/void-packages/pull/31959

Description:
So you can statically link against X programs; since libX11 links
against libxcb this is impossible now.

Either I'm not understanding how static linking works (AFAIK you *need*
the .a file?), or this is a very unpopular thing to do as it's been like
this for 9 years (changed in commit 9526648, in 2012) 🤔

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->