[PR PATCH] imlib2: install static libraries for -devel package

[PR PATCH] imlib2: install static libraries for -devel package

[arp242]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There is a new pull request by arp242 against master on the void-packages repository

https://github.com/arp242/void-packages imlib-static
https://github.com/void-linux/void-packages/pull/31973

imlib2: install static libraries for -devel package
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31973.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-imlib-static-31973.patch --]
[-- Type: text/x-diff, Size: 1078 bytes --]

From 088bc7c686365cdabbcfd84ce3583227a3c25e7a Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Thu, 15 Jul 2021 11:01:41 +0800
Subject: [PATCH] imlib2: install static libraries for -devel package

---
 srcpkgs/imlib2/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/imlib2/template b/srcpkgs/imlib2/template
index c25e300a103a..7be594d8b3c6 100644
--- a/srcpkgs/imlib2/template
+++ b/srcpkgs/imlib2/template
@@ -1,9 +1,9 @@
 # Template file for 'imlib2'
 pkgname=imlib2
 version=1.7.1
-revision=1
+revision=2
 build_style=gnu-configure
-configure_args="--disable-static --sysconfdir=/etc/imlib2 --enable-visibility-hiding"
+configure_args="--sysconfdir=/etc/imlib2 --enable-visibility-hiding"
 hostmakedepends="pkg-config"
 makedepends="freetype-devel libjpeg-turbo-devel libpng-devel libwebp-devel
  tiff-devel libid3tag-devel giflib-devel libXext-devel libSM-devel"
@@ -34,6 +34,7 @@ imlib2-devel_package() {
 		vmove usr/share
 		vmove usr/lib/pkgconfig
 		vmove "usr/lib/*.so"
+		vmove "usr/lib/*.a"
 	}
 }
 

Re: imlib2: install static libraries for -devel package

[arp242]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by arp242 on void-packages repository

https://github.com/void-linux/void-packages/pull/31973#issuecomment-880482534

Comment:
It seems that actually using this causes some Weird Shit™ to happen; I don't *think* that's a problem in my application, but in Imlib, so I'll close this for now.

Re: [PR PATCH] [Closed]: imlib2: install static libraries for -devel package

[arp242]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

There's a closed pull request on the void-packages repository

imlib2: install static libraries for -devel package
https://github.com/void-linux/void-packages/pull/31973

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: imlib2: install static libraries for -devel package

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31973#issuecomment-880707802

Comment:
imlib is all about dlopening things iirc, so you will likely have issues.

Re: imlib2: install static libraries for -devel package

[arp242]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

New comment by arp242 on void-packages repository

https://github.com/void-linux/void-packages/pull/31973#issuecomment-880712223

Comment:
Indeed; I was somewhat surprised that it worked at all, but in-between building imlib, working on my "release software as a static build" script, and the musl reallocarray fix I simply used the wrong (dynamic) version :-/ I discovered imlib2 actually has a bunch of limitations so it's not even useful for me anyway.