Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] synfig + synfigstudio: update to 1.4.2
@ 2021-08-06  8:03 newbluemoon
  2021-08-06 20:17 ` newbluemoon
                   ` (24 more replies)
  0 siblings, 25 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-06  8:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

There is a new pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages synfig
https://github.com/void-linux/void-packages/pull/32358

synfig + synfigstudio: update to 1.4.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32358.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-synfig-32358.patch --]
[-- Type: text/x-diff, Size: 3153 bytes --]

From 1bf22f7b70a0f62486e2cf65c7818e4babea31a1 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:50:35 +0200
Subject: [PATCH 1/3] ETL: update to 1.4.2

---
 srcpkgs/ETL/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ETL/template b/srcpkgs/ETL/template
index 2cc7ce21461e..0a395b6e296a 100644
--- a/srcpkgs/ETL/template
+++ b/srcpkgs/ETL/template
@@ -1,6 +1,6 @@
 # Template file for 'ETL'
 pkgname=ETL
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config"
@@ -10,4 +10,4 @@ maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/ETL-${version}.tar.gz"
-checksum=ecb61942da60dca8e623af8ad03656897d10b03296e8907dd3c6c296390a074c
+checksum=e54192d284df16305ddfdfcc5bdfe93e139e6db5bc283dd4bab2413ebbead7c7

From eb586069bb88cecc4fb718a27113fc1e05da39b6 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:50:58 +0200
Subject: [PATCH 2/3] synfig: update to 1.4.2

---
 srcpkgs/synfig/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/synfig/template b/srcpkgs/synfig/template
index d36db2d1ea6e..bae3a4672dae 100644
--- a/srcpkgs/synfig/template
+++ b/srcpkgs/synfig/template
@@ -1,6 +1,6 @@
 # Template file for 'synfig'
 pkgname=synfig
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 configure_args="--with-boost-libdir=${XBPS_CROSS_BASE}/usr/lib"
@@ -13,7 +13,7 @@ maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/synfig-${version}.tar.gz"
-checksum=f90f1dcff1a409bbe2bfbb2cf42b7019cf735bec3223722db2feba6e198d1bc1
+checksum=e66688b908ab2f05f87cc5a364f958a1351f101ccab3b3ade33a926453002f4e
 
 CXXFLAGS="-std=c++11 -DHAVE_LOCALE_H=1"
 

From 4426bb3ecf53667432bca8bedaa168dd57b0ba14 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:51:27 +0200
Subject: [PATCH 3/3] synfigstudio: update to 1.4.2

---
 srcpkgs/synfigstudio/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/synfigstudio/template b/srcpkgs/synfigstudio/template
index 3e40a99fb28c..2cb07e51e086 100644
--- a/srcpkgs/synfigstudio/template
+++ b/srcpkgs/synfigstudio/template
@@ -1,6 +1,6 @@
 # Template file for 'synfigstudio'
 pkgname=synfigstudio
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 configure_args="--disable-update-mimedb"
@@ -11,7 +11,7 @@ maintainer="newbluemoon <blaumolch@mailbox.org>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/synfigstudio-${version}.tar.gz"
-checksum=af9a9b0064064907ae24a693b607dcba633a8a2cd45fa1357f61c035efd6020e
+checksum=4e86d4d8def6675fc92855a411795cc4062a1669cda82535d18b48a68b4d5497
 python_version=3
 CXXFLAGS="-Wno-deprecated-copy -DHAVE_LOCALE_H=1"
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
@ 2021-08-06 20:17 ` newbluemoon
  2021-08-06 20:22 ` ericonr
                   ` (23 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-06 20:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894497443

Comment:
The test passes on x86_64 and my local i686-musl build. So it might not be musl specific.
With version 1.4.1 the test passes on all targets.
No idea why there is a segmentation fault on x86_64-musl. Maybe I should open an issue upstream?
I could post a gdb backtrace if anyone is intrested. ;)

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
  2021-08-06 20:17 ` newbluemoon
@ 2021-08-06 20:22 ` ericonr
  2021-08-06 20:25 ` newbluemoon
                   ` (22 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ericonr @ 2021-08-06 20:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894499473

Comment:
>  I could post a gdb backtrace if anyone is intrested. ;)

Please do :)

I bet on thread stack size, if the test binary is threaded :p

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
  2021-08-06 20:17 ` newbluemoon
  2021-08-06 20:22 ` ericonr
@ 2021-08-06 20:25 ` newbluemoon
  2021-08-06 20:51 ` newbluemoon
                   ` (21 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-06 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 3680 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894501029

Comment:
Here you go:
```
(gdb) run
Starting program: /builddir/synfigstudio-1.4.2/test/.libs/lt-app_layerduplicate 
[New LWP 23222]
[New LWP 23223]
[New LWP 23224]
[New LWP 23225]
[New LWP 23226]
[New LWP 23227]
[New LWP 23228]
[New LWP 23229]
[New LWP 23230]
[New LWP 23231]
[New LWP 23232]
[New LWP 23233]
[New LWP 23234]
[New LWP 23235]
[New LWP 23236]
[New LWP 23237]
synfig(23218) [19:29:09] info: rendering threads 16
synfig(23218) [19:29:09] warning: Cannot open ./synfig_modules.cfg
synfig(23218) [19:29:09] warning: Cannot open /tmp/.local/share/synfig/synfig_modules.cfg
synfig(23218) [19:29:09] info: Loading modules from /etc/synfig_modules.cfg
synfig(23218) [19:29:09] info: Loading lyr_std..
synfig(23218) [19:29:09] info: Loading lyr_freetype..
synfig(23218) [19:29:09] info: Loading mod_geometry..
synfig(23218) [19:29:09] info: Loading mod_gradient..
synfig(23218) [19:29:09] info: Loading mod_particle..
synfig(23218) [19:29:09] info: Loading mod_example..
synfig(23218) [19:29:09] info: Loading mod_gif..
synfig(23218) [19:29:09] info: Loading mod_imagemagick..
synfig(23218) [19:29:09] info: Loading mod_magickpp..
synfig(23218) [19:29:09] info: Loading mod_mng..
synfig(23218) [19:29:09] info: Loading mod_noise..
synfig(23218) [19:29:09] info: Loading mod_filter..
synfig(23218) [19:29:09] info: Loading mod_ffmpeg..
synfig(23218) [19:29:09] info: Loading mod_bmp..
synfig(23218) [19:29:09] info: Loading mod_dv..
synfig(23218) [19:29:09] info: Loading mod_png..
synfig(23218) [19:29:09] info: Loading mod_ppm..
synfig(23218) [19:29:09] info: Loading mod_openexr..
synfig(23218) [19:29:09] info: Loading mod_jpeg..
synfig(23218) [19:29:09] info: Loading mod_libavcodec..
synfig(23218) [19:29:09] info: Loading mod_yuv420p..
synfig(23218) [19:29:09] info: Loading mod_svg..

Thread 1 "lt-app_layerdup" received signal SIGSEGV, Segmentation fault.
0x00007ffff7d23710 in synfigapp::Action::LayerDuplicate::replace_valuenodes(std::map<etl::handle<synfig::Layer>, etl::handle<synfig::Layer>, std::less<etl::handle<synfig::Layer> >, std::allocator<std::pair<etl::handle<synfig::Layer> const, etl::handle<synfig::Layer> > > > const&, std::map<etl::rhandle<synfig::ValueNode>, etl::rhandle<synfig::ValueNode>, std::less<etl::rhandle<synfig::ValueNode> >, std::allocator<std::pair<etl::rhandle<synfig::ValueNode> const, etl::rhandle<synfig::ValueNode> > > > const&) () from /builddir/synfigstudio-1.4.2/src/synfigapp/.libs/libsynfigapp.so.0
(gdb) bt
#0  0x00007ffff7d23710 in synfigapp::Action::LayerDuplicate::replace_valuenodes(std::map<etl::handle<synfig::Layer>, etl::handle<synfig::Layer>, std::less<etl::handle<synfig::Layer> >, std::allocator<std::pair<etl::handle<synfig::Layer> const, etl::handle<synfig::Layer> > > > const&, std::map<etl::rhandle<synfig::ValueNode>, etl::rhandle<synfig::ValueNode>, std::less<etl::rhandle<synfig::ValueNode> >, std::allocator<std::pair<etl::rhandle<synfig::ValueNode> const, etl::rhandle<synfig::ValueNode> > > > const&) () from /builddir/synfigstudio-1.4.2/src/synfigapp/.libs/libsynfigapp.so.0
#1  0x00007ffff7d25ad6 in synfigapp::Action::LayerDuplicate::prepare() ()
   from /builddir/synfigstudio-1.4.2/src/synfigapp/.libs/libsynfigapp.so.0
#2  0x00007ffff7e7e1da in synfigapp::Action::Super::perform() ()
   from /builddir/synfigstudio-1.4.2/src/synfigapp/.libs/libsynfigapp.so.0
#3  0x000055555556ca4a in test_synfigapp_layerduplicate_both_layer_duplicate_and_linked_layers() ()
#4  0x000055555556186a in main ()
(gdb)
```

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (2 preceding siblings ...)
  2021-08-06 20:25 ` newbluemoon
@ 2021-08-06 20:51 ` newbluemoon
  2021-08-06 21:21 ` ericonr
                   ` (20 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-06 20:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894512143

Comment:
I tried to increase the stack size via `-Wl,-z,stack-size=2097152`, but to no avail. :(

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (3 preceding siblings ...)
  2021-08-06 20:51 ` newbluemoon
@ 2021-08-06 21:21 ` ericonr
  2021-08-07  8:32 ` newbluemoon
                   ` (19 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ericonr @ 2021-08-06 21:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894524673

Comment:
Yeah segfault is in the main thread, so it would seem to be something else.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (4 preceding siblings ...)
  2021-08-06 21:21 ` ericonr
@ 2021-08-07  8:32 ` newbluemoon
  2021-08-07 10:43 ` sgn
                   ` (18 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-07  8:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894624911

Comment:
I opened an issue at synfig: https://github.com/synfig/synfig/issues/2259

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (5 preceding siblings ...)
  2021-08-07  8:32 ` newbluemoon
@ 2021-08-07 10:43 ` sgn
  2021-08-07 14:42 ` sgn
                   ` (17 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-07 10:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894637766

Comment:
Hm, `synfigstudio` drops `-g` from our `CFLAGS` and `CXXFLAGS`?

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (6 preceding siblings ...)
  2021-08-07 10:43 ` sgn
@ 2021-08-07 14:42 ` sgn
  2021-08-08 19:44 ` newbluemoon
                   ` (16 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-07 14:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894663389

Comment:
```diff
 srcpkgs/synfigstudio/patches/cflags-cxxflags.patch | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch b/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
new file mode 100644
index 0000000000..85d84ff60a
--- /dev/null
+++ b/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
@@ -0,0 +1,26 @@
+--- synfigstudio-1.4.2.orig/configure
++++ synfigstudio-1.4.2/configure
+@@ -18015,8 +18015,8 @@ fi
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
++			CFLAGS="$CFLAGS -DNDEBUG"
++			CXXFLAGS="$CXXFLAGS -DNDEBUG"
+ 		;;
+ 	esac
+ 
+--- synfigstudio-1.4.2.orig/m4/subs.m4
++++ synfigstudio-1.4.2/m4/subs.m4
+@@ -83,8 +83,8 @@ AC_DEFUN([AC_ARG_DEBUG],
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS -DNDEBUG"
++			CFLAGS="$CFLAGS -DNDEBUG"
+ 		;;
+ 	esac
+ 
```

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (7 preceding siblings ...)
  2021-08-07 14:42 ` sgn
@ 2021-08-08 19:44 ` newbluemoon
  2021-08-09 11:37 ` sgn
                   ` (15 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-08 19:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-894845678

Comment:
@sgn Thanks for noticing and the patch! I’ll add it.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (8 preceding siblings ...)
  2021-08-08 19:44 ` newbluemoon
@ 2021-08-09 11:37 ` sgn
  2021-08-09 11:44 ` [PR REVIEW] " sgn
                   ` (14 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-09 11:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-895152163

Comment:
On 2021-08-08 12:44:39-0700, newbluemoon ***@***.***> wrote:
> @sgn Thanks for noticing and the patch! I’ll add it.

Actually, synfig also have that problems, you may need to add the
patch to synfig, too.

-- 
Danh


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (9 preceding siblings ...)
  2021-08-09 11:37 ` sgn
@ 2021-08-09 11:44 ` sgn
  2021-08-09 14:17 ` sgn
                   ` (13 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-09 11:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r685122186

Comment:
`synfig` should be put in `hostmakedepends` regardless of cross.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (10 preceding siblings ...)
  2021-08-09 11:44 ` [PR REVIEW] " sgn
@ 2021-08-09 14:17 ` sgn
  2021-08-09 14:17 ` sgn
                   ` (12 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-09 14:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r685233898

Comment:
Also: `export DATADIRNAME=share`, otherwise, you'll see `-DLOCALEDIR=/usr//locale`

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (11 preceding siblings ...)
  2021-08-09 14:17 ` sgn
@ 2021-08-09 14:17 ` sgn
  2021-08-09 15:20 ` sgn
                   ` (11 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-09 14:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r685233898

Comment:
Also: `export DATADIRNAME=share`, otherwise, you'll see `-DLOCALEDIR=\"/usr//locale\"`

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (12 preceding siblings ...)
  2021-08-09 14:17 ` sgn
@ 2021-08-09 15:20 ` sgn
  2021-08-09 15:23 ` sgn
                   ` (10 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-09 15:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 5324 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-895314130

Comment:
```
rendering/task.h:227:11: runtime error: member call on address 0x7ffa3e282dd8 which does not point to an object of type 'synfig::Token'
0x7ffa3e282dd8: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/task.h:227:11 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
^[[33msynfig(4256) [15:18:34] warning: Cannot open ./synfig_modules.cfg^[[0m
^[[33msynfig(4256) [15:18:34] warning: Cannot open /tmp/.local/share/synfig/synfig_modules.cfg^[[0m
valuenode_registry.cpp:85:9: runtime error: call to function (unknown) through pointer to incorrect function type 'synfig::LinkableValueNode *(*)(const synfig::ValueBase &, etl::loose_handle<synfig::Canvas>)'
(/lib/libsynfig.so.0+0x2520c20): note: (unknown) defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior valuenode_registry.cpp:85:9 in 
^[[33msynfig(4256) [15:18:34] warning: Can't replace a null valuenode^[[0m
^[[33msynfig(4256) [15:18:34] warning: Can't replace a null valuenode^[[0m
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==4256==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address (pc 0x7ffa39d003f0 bp 0x563d068d2ef8 sp 0x7ffd70aa3180 T4256)
==4256==The signal is caused by a READ memory access.
==4256==Hint: this fault was caused by a dereference of a high value address (see register values below).  Disassemble the provided pc to learn which register was used.
    #0 0x7ffa39d003f0  (/lib/libstdc++.so.6+0xe43f0)

UndefinedBehaviorSanitizer can not provide additional info.
SUMMARY: UndefinedBehaviorSanitizer: SEGV (/lib/libstdc++.so.6+0xe43f0) 
==4256==ABORTING
```

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (13 preceding siblings ...)
  2021-08-09 15:20 ` sgn
@ 2021-08-09 15:23 ` sgn
  2021-08-09 20:27 ` [PR PATCH] [Updated] " newbluemoon
                   ` (9 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-09 15:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 5365 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-895314130

Comment:
Look like a use-after-free somewhere.

```
rendering/task.h:227:11: runtime error: member call on address 0x7ffa3e282dd8 which does not point to an object of type 'synfig::Token'
0x7ffa3e282dd8: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/task.h:227:11 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
rendering/software/task/../../task.h:259:22: runtime error: member call on address 0x7ffa3e285120 which does not point to an object of type 'synfig::rendering::ModeToken'
0x7ffa3e285120: note: object has invalid vptr
 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              invalid vptr
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior rendering/software/task/../../task.h:259:22 in 
^[[33msynfig(4256) [15:18:34] warning: Cannot open ./synfig_modules.cfg^[[0m
^[[33msynfig(4256) [15:18:34] warning: Cannot open /tmp/.local/share/synfig/synfig_modules.cfg^[[0m
valuenode_registry.cpp:85:9: runtime error: call to function (unknown) through pointer to incorrect function type 'synfig::LinkableValueNode *(*)(const synfig::ValueBase &, etl::loose_handle<synfig::Canvas>)'
(/lib/libsynfig.so.0+0x2520c20): note: (unknown) defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior valuenode_registry.cpp:85:9 in 
^[[33msynfig(4256) [15:18:34] warning: Can't replace a null valuenode^[[0m
^[[33msynfig(4256) [15:18:34] warning: Can't replace a null valuenode^[[0m
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==4256==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address (pc 0x7ffa39d003f0 bp 0x563d068d2ef8 sp 0x7ffd70aa3180 T4256)
==4256==The signal is caused by a READ memory access.
==4256==Hint: this fault was caused by a dereference of a high value address (see register values below).  Disassemble the provided pc to learn which register was used.
    #0 0x7ffa39d003f0  (/lib/libstdc++.so.6+0xe43f0)

UndefinedBehaviorSanitizer can not provide additional info.
SUMMARY: UndefinedBehaviorSanitizer: SEGV (/lib/libstdc++.so.6+0xe43f0) 
==4256==ABORTING
```

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (14 preceding siblings ...)
  2021-08-09 15:23 ` sgn
@ 2021-08-09 20:27 ` newbluemoon
  2021-08-09 20:35 ` [PR REVIEW] " newbluemoon
                   ` (8 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-09 20:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

There is an updated pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages synfig
https://github.com/void-linux/void-packages/pull/32358

synfig + synfigstudio: update to 1.4.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32358.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-synfig-32358.patch --]
[-- Type: text/x-diff, Size: 6403 bytes --]

From cae4bbbbecd6f55bf250fa2c0342cb72c899a231 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:50:35 +0200
Subject: [PATCH 1/3] ETL: update to 1.4.2

---
 srcpkgs/ETL/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ETL/template b/srcpkgs/ETL/template
index 2cc7ce21461e..0a395b6e296a 100644
--- a/srcpkgs/ETL/template
+++ b/srcpkgs/ETL/template
@@ -1,6 +1,6 @@
 # Template file for 'ETL'
 pkgname=ETL
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config"
@@ -10,4 +10,4 @@ maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/ETL-${version}.tar.gz"
-checksum=ecb61942da60dca8e623af8ad03656897d10b03296e8907dd3c6c296390a074c
+checksum=e54192d284df16305ddfdfcc5bdfe93e139e6db5bc283dd4bab2413ebbead7c7

From 75ca5a5288ae021a8ba986fc8d8511cbd504356c Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:50:58 +0200
Subject: [PATCH 2/3] synfig: update to 1.4.2

---
 srcpkgs/synfig/patches/cflags-cxxflags.patch | 29 ++++++++++++++++++++
 srcpkgs/synfig/template                      |  4 +--
 2 files changed, 31 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/synfig/patches/cflags-cxxflags.patch

diff --git a/srcpkgs/synfig/patches/cflags-cxxflags.patch b/srcpkgs/synfig/patches/cflags-cxxflags.patch
new file mode 100644
index 000000000000..d0c1b2280fde
--- /dev/null
+++ b/srcpkgs/synfig/patches/cflags-cxxflags.patch
@@ -0,0 +1,29 @@
+Prevent synfig from filtering out the compiler’s '-g' option to produce debug
+information.
+
+--- a/configure	2021-07-28 17:11:56.000000000 +0200
++++ b/configure	2021-08-09 21:35:13.846748903 +0200
+@@ -19613,8 +19613,8 @@
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS $debug_flags"
++			CFLAGS="$CFLAGS $debug_flags"
+ 		;;
+ 	esac
+ 
+--- a/m4/subs.m4	2021-07-12 17:45:48.000000000 +0200
++++ b/m4/subs.m4	2021-08-09 21:39:39.014802968 +0200
+@@ -85,8 +85,8 @@
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS $debug_flags"
++			CFLAGS="$CFLAGS $debug_flags"
+ 		;;
+ 	esac
+ 
diff --git a/srcpkgs/synfig/template b/srcpkgs/synfig/template
index d36db2d1ea6e..bae3a4672dae 100644
--- a/srcpkgs/synfig/template
+++ b/srcpkgs/synfig/template
@@ -1,6 +1,6 @@
 # Template file for 'synfig'
 pkgname=synfig
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 configure_args="--with-boost-libdir=${XBPS_CROSS_BASE}/usr/lib"
@@ -13,7 +13,7 @@ maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/synfig-${version}.tar.gz"
-checksum=f90f1dcff1a409bbe2bfbb2cf42b7019cf735bec3223722db2feba6e198d1bc1
+checksum=e66688b908ab2f05f87cc5a364f958a1351f101ccab3b3ade33a926453002f4e
 
 CXXFLAGS="-std=c++11 -DHAVE_LOCALE_H=1"
 

From 0652dcb5a5be4ad8549c5a4f8a500feeef388286 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:51:27 +0200
Subject: [PATCH 3/3] synfigstudio: update to 1.4.2

---
 .../patches/cflags-cxxflags.patch             | 29 +++++++++++++++++++
 srcpkgs/synfigstudio/template                 | 13 +++------
 2 files changed, 33 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/synfigstudio/patches/cflags-cxxflags.patch

diff --git a/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch b/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
new file mode 100644
index 000000000000..d70d2a23f7f4
--- /dev/null
+++ b/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
@@ -0,0 +1,29 @@
+Prevent synfigstudio from filtering out the compiler’s '-g' option to produce debug
+information.
+
+--- synfigstudio-1.4.2.orig/configure
++++ synfigstudio-1.4.2/configure
+@@ -18015,8 +18015,8 @@ fi
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
++			CFLAGS="$CFLAGS -DNDEBUG"
++			CXXFLAGS="$CXXFLAGS -DNDEBUG"
+ 		;;
+ 	esac
+ 
+--- synfigstudio-1.4.2.orig/m4/subs.m4
++++ synfigstudio-1.4.2/m4/subs.m4
+@@ -83,8 +83,8 @@ AC_DEFUN([AC_ARG_DEBUG],
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS -DNDEBUG"
++			CFLAGS="$CFLAGS -DNDEBUG"
+ 		;;
+ 	esac
+ 
diff --git a/srcpkgs/synfigstudio/template b/srcpkgs/synfigstudio/template
index 3e40a99fb28c..d4fe620bffd6 100644
--- a/srcpkgs/synfigstudio/template
+++ b/srcpkgs/synfigstudio/template
@@ -1,25 +1,20 @@
 # Template file for 'synfigstudio'
 pkgname=synfigstudio
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 configure_args="--disable-update-mimedb"
-hostmakedepends="pkg-config intltool gettext"
+hostmakedepends="pkg-config intltool gettext synfig"
 makedepends="ETL synfig-devel gtkmm-devel libltdl-devel boost-devel"
 short_desc="Vector based 2D animation studio"
 maintainer="newbluemoon <blaumolch@mailbox.org>"
 license="GPL-2.0-or-later"
-homepage="http://www.synfig.org/"
+homepage="https://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/synfigstudio-${version}.tar.gz"
-checksum=af9a9b0064064907ae24a693b607dcba633a8a2cd45fa1357f61c035efd6020e
+checksum=4e86d4d8def6675fc92855a411795cc4062a1669cda82535d18b48a68b4d5497
 python_version=3
 CXXFLAGS="-Wno-deprecated-copy -DHAVE_LOCALE_H=1"
 
-if [ -n "$CROSS_BUILD" ]; then
-	# uses synfig to create some icons
-	hostmakedepends+=" synfig"
-fi
-
 synfigstudio-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (15 preceding siblings ...)
  2021-08-09 20:27 ` [PR PATCH] [Updated] " newbluemoon
@ 2021-08-09 20:35 ` newbluemoon
  2021-08-10  2:58 ` sgn
                   ` (7 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-09 20:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New review comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r685502629

Comment:
However, when checking the built packages (native and cross) the localization files are always installed correctly in `/usr/share/locale`. Shall I explicitly add `DATADIRNAME` anyway?

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (16 preceding siblings ...)
  2021-08-09 20:35 ` [PR REVIEW] " newbluemoon
@ 2021-08-10  2:58 ` sgn
  2021-08-10 13:49 ` [PR PATCH] [Updated] " newbluemoon
                   ` (6 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: sgn @ 2021-08-10  2:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r685654049

Comment:
It's installed correctly, but load incorrectly. So, yes, please add `DATADIRNAME`.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (17 preceding siblings ...)
  2021-08-10  2:58 ` sgn
@ 2021-08-10 13:49 ` newbluemoon
  2021-10-12 13:39 ` newbluemoon
                   ` (5 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-08-10 13:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

There is an updated pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages synfig
https://github.com/void-linux/void-packages/pull/32358

synfig + synfigstudio: update to 1.4.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32358.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-synfig-32358.patch --]
[-- Type: text/x-diff, Size: 6392 bytes --]

From 2ed310b465b82ce2e866ce08f7fce461ff5a4a57 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:50:35 +0200
Subject: [PATCH 1/3] ETL: update to 1.4.2

---
 srcpkgs/ETL/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ETL/template b/srcpkgs/ETL/template
index 2cc7ce21461e..0a395b6e296a 100644
--- a/srcpkgs/ETL/template
+++ b/srcpkgs/ETL/template
@@ -1,6 +1,6 @@
 # Template file for 'ETL'
 pkgname=ETL
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config"
@@ -10,4 +10,4 @@ maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/ETL-${version}.tar.gz"
-checksum=ecb61942da60dca8e623af8ad03656897d10b03296e8907dd3c6c296390a074c
+checksum=e54192d284df16305ddfdfcc5bdfe93e139e6db5bc283dd4bab2413ebbead7c7

From 5f0950d805a84e7b3a3e213258c828cb49e21991 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:50:58 +0200
Subject: [PATCH 2/3] synfig: update to 1.4.2

---
 srcpkgs/synfig/patches/cflags-cxxflags.patch | 29 ++++++++++++++++++++
 srcpkgs/synfig/template                      |  4 +--
 2 files changed, 31 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/synfig/patches/cflags-cxxflags.patch

diff --git a/srcpkgs/synfig/patches/cflags-cxxflags.patch b/srcpkgs/synfig/patches/cflags-cxxflags.patch
new file mode 100644
index 000000000000..d0c1b2280fde
--- /dev/null
+++ b/srcpkgs/synfig/patches/cflags-cxxflags.patch
@@ -0,0 +1,29 @@
+Prevent synfig from filtering out the compiler’s '-g' option to produce debug
+information.
+
+--- a/configure	2021-07-28 17:11:56.000000000 +0200
++++ b/configure	2021-08-09 21:35:13.846748903 +0200
+@@ -19613,8 +19613,8 @@
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS $debug_flags"
++			CFLAGS="$CFLAGS $debug_flags"
+ 		;;
+ 	esac
+ 
+--- a/m4/subs.m4	2021-07-12 17:45:48.000000000 +0200
++++ b/m4/subs.m4	2021-08-09 21:39:39.014802968 +0200
+@@ -85,8 +85,8 @@
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS $debug_flags"
++			CFLAGS="$CFLAGS $debug_flags"
+ 		;;
+ 	esac
+ 
diff --git a/srcpkgs/synfig/template b/srcpkgs/synfig/template
index d36db2d1ea6e..bae3a4672dae 100644
--- a/srcpkgs/synfig/template
+++ b/srcpkgs/synfig/template
@@ -1,6 +1,6 @@
 # Template file for 'synfig'
 pkgname=synfig
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 configure_args="--with-boost-libdir=${XBPS_CROSS_BASE}/usr/lib"
@@ -13,7 +13,7 @@ maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/synfig-${version}.tar.gz"
-checksum=f90f1dcff1a409bbe2bfbb2cf42b7019cf735bec3223722db2feba6e198d1bc1
+checksum=e66688b908ab2f05f87cc5a364f958a1351f101ccab3b3ade33a926453002f4e
 
 CXXFLAGS="-std=c++11 -DHAVE_LOCALE_H=1"
 

From 2ad5039db0e9138b683b5ea0edcb7d559ed64328 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:51:27 +0200
Subject: [PATCH 3/3] synfigstudio: update to 1.4.2

---
 .../patches/cflags-cxxflags.patch             | 29 +++++++++++++++++++
 srcpkgs/synfigstudio/template                 | 14 ++++-----
 2 files changed, 34 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/synfigstudio/patches/cflags-cxxflags.patch

diff --git a/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch b/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
new file mode 100644
index 000000000000..d70d2a23f7f4
--- /dev/null
+++ b/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
@@ -0,0 +1,29 @@
+Prevent synfigstudio from filtering out the compiler’s '-g' option to produce debug
+information.
+
+--- synfigstudio-1.4.2.orig/configure
++++ synfigstudio-1.4.2/configure
+@@ -18015,8 +18015,8 @@ fi
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
++			CFLAGS="$CFLAGS -DNDEBUG"
++			CXXFLAGS="$CXXFLAGS -DNDEBUG"
+ 		;;
+ 	esac
+ 
+--- synfigstudio-1.4.2.orig/m4/subs.m4
++++ synfigstudio-1.4.2/m4/subs.m4
+@@ -83,8 +83,8 @@ AC_DEFUN([AC_ARG_DEBUG],
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS -DNDEBUG"
++			CFLAGS="$CFLAGS -DNDEBUG"
+ 		;;
+ 	esac
+ 
diff --git a/srcpkgs/synfigstudio/template b/srcpkgs/synfigstudio/template
index 3e40a99fb28c..359882fb1915 100644
--- a/srcpkgs/synfigstudio/template
+++ b/srcpkgs/synfigstudio/template
@@ -1,24 +1,20 @@
 # Template file for 'synfigstudio'
 pkgname=synfigstudio
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 configure_args="--disable-update-mimedb"
-hostmakedepends="pkg-config intltool gettext"
+hostmakedepends="pkg-config intltool gettext synfig"
 makedepends="ETL synfig-devel gtkmm-devel libltdl-devel boost-devel"
 short_desc="Vector based 2D animation studio"
 maintainer="newbluemoon <blaumolch@mailbox.org>"
 license="GPL-2.0-or-later"
-homepage="http://www.synfig.org/"
+homepage="https://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/synfigstudio-${version}.tar.gz"
-checksum=af9a9b0064064907ae24a693b607dcba633a8a2cd45fa1357f61c035efd6020e
+checksum=4e86d4d8def6675fc92855a411795cc4062a1669cda82535d18b48a68b4d5497
 python_version=3
 CXXFLAGS="-Wno-deprecated-copy -DHAVE_LOCALE_H=1"
-
-if [ -n "$CROSS_BUILD" ]; then
-	# uses synfig to create some icons
-	hostmakedepends+=" synfig"
-fi
+export DATADIRNAME=share
 
 synfigstudio-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (18 preceding siblings ...)
  2021-08-10 13:49 ` [PR PATCH] [Updated] " newbluemoon
@ 2021-10-12 13:39 ` newbluemoon
  2021-10-12 13:46 ` newbluemoon
                   ` (4 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-10-12 13:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

There is an updated pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages synfig
https://github.com/void-linux/void-packages/pull/32358

synfig + synfigstudio: update to 1.4.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32358.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-synfig-32358.patch --]
[-- Type: text/x-diff, Size: 7731 bytes --]

From 71e65e75c1554be9a3dfefc1818ac8c828e4f264 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:50:35 +0200
Subject: [PATCH 1/3] ETL: update to 1.4.2

---
 srcpkgs/ETL/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ETL/template b/srcpkgs/ETL/template
index 2cc7ce21461e..0a395b6e296a 100644
--- a/srcpkgs/ETL/template
+++ b/srcpkgs/ETL/template
@@ -1,6 +1,6 @@
 # Template file for 'ETL'
 pkgname=ETL
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config"
@@ -10,4 +10,4 @@ maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/ETL-${version}.tar.gz"
-checksum=ecb61942da60dca8e623af8ad03656897d10b03296e8907dd3c6c296390a074c
+checksum=e54192d284df16305ddfdfcc5bdfe93e139e6db5bc283dd4bab2413ebbead7c7

From 63d75dc3e8c6be5e28797a2384f7adac288fcfc9 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:50:58 +0200
Subject: [PATCH 2/3] synfig: update to 1.4.2

---
 srcpkgs/synfig/patches/cflags-cxxflags.patch | 29 ++++++++++++++++++++
 srcpkgs/synfig/template                      |  4 +--
 2 files changed, 31 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/synfig/patches/cflags-cxxflags.patch

diff --git a/srcpkgs/synfig/patches/cflags-cxxflags.patch b/srcpkgs/synfig/patches/cflags-cxxflags.patch
new file mode 100644
index 000000000000..d0c1b2280fde
--- /dev/null
+++ b/srcpkgs/synfig/patches/cflags-cxxflags.patch
@@ -0,0 +1,29 @@
+Prevent synfig from filtering out the compiler’s '-g' option to produce debug
+information.
+
+--- a/configure	2021-07-28 17:11:56.000000000 +0200
++++ b/configure	2021-08-09 21:35:13.846748903 +0200
+@@ -19613,8 +19613,8 @@
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS $debug_flags"
++			CFLAGS="$CFLAGS $debug_flags"
+ 		;;
+ 	esac
+ 
+--- a/m4/subs.m4	2021-07-12 17:45:48.000000000 +0200
++++ b/m4/subs.m4	2021-08-09 21:39:39.014802968 +0200
+@@ -85,8 +85,8 @@
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS $debug_flags"
++			CFLAGS="$CFLAGS $debug_flags"
+ 		;;
+ 	esac
+ 
diff --git a/srcpkgs/synfig/template b/srcpkgs/synfig/template
index d36db2d1ea6e..bae3a4672dae 100644
--- a/srcpkgs/synfig/template
+++ b/srcpkgs/synfig/template
@@ -1,6 +1,6 @@
 # Template file for 'synfig'
 pkgname=synfig
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 configure_args="--with-boost-libdir=${XBPS_CROSS_BASE}/usr/lib"
@@ -13,7 +13,7 @@ maintainer="Diogo Leal <diogo@diogoleal.com>"
 license="GPL-2.0-or-later"
 homepage="http://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/synfig-${version}.tar.gz"
-checksum=f90f1dcff1a409bbe2bfbb2cf42b7019cf735bec3223722db2feba6e198d1bc1
+checksum=e66688b908ab2f05f87cc5a364f958a1351f101ccab3b3ade33a926453002f4e
 
 CXXFLAGS="-std=c++11 -DHAVE_LOCALE_H=1"
 

From 6e414e7ac705695365231d46a4e1aad9918e9c70 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Fri, 6 Aug 2021 09:51:27 +0200
Subject: [PATCH 3/3] synfigstudio: update to 1.4.2

---
 .../patches/cflags-cxxflags.patch             | 29 +++++++++++++++++++
 .../synfigstudio/patches/fix-test-crash.patch | 19 ++++++++++++
 srcpkgs/synfigstudio/template                 | 14 ++++-----
 3 files changed, 53 insertions(+), 9 deletions(-)
 create mode 100644 srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
 create mode 100644 srcpkgs/synfigstudio/patches/fix-test-crash.patch

diff --git a/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch b/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
new file mode 100644
index 000000000000..d70d2a23f7f4
--- /dev/null
+++ b/srcpkgs/synfigstudio/patches/cflags-cxxflags.patch
@@ -0,0 +1,29 @@
+Prevent synfigstudio from filtering out the compiler’s '-g' option to produce debug
+information.
+
+--- synfigstudio-1.4.2.orig/configure
++++ synfigstudio-1.4.2/configure
+@@ -18015,8 +18015,8 @@ fi
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[a-z-]*\s::g' | sed 's:-g[a-z-]*$::'` $debug_flags"
++			CFLAGS="$CFLAGS -DNDEBUG"
++			CXXFLAGS="$CXXFLAGS -DNDEBUG"
+ 		;;
+ 	esac
+ 
+--- synfigstudio-1.4.2.orig/m4/subs.m4
++++ synfigstudio-1.4.2/m4/subs.m4
+@@ -83,8 +83,8 @@ AC_DEFUN([AC_ARG_DEBUG],
+ 		;;
+ 		no|*)
+ 			debug_flags="-DNDEBUG"
+-			CXXFLAGS="`echo $CXXFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
+-			CFLAGS="`echo $CFLAGS | sed 's:-g[[a-z-]]*\s::g' | sed 's:-g[[a-z-]]*$::'` $debug_flags"
++			CXXFLAGS="$CXXFLAGS -DNDEBUG"
++			CFLAGS="$CFLAGS -DNDEBUG"
+ 		;;
+ 	esac
+ 
diff --git a/srcpkgs/synfigstudio/patches/fix-test-crash.patch b/srcpkgs/synfigstudio/patches/fix-test-crash.patch
new file mode 100644
index 000000000000..651b3bc245b8
--- /dev/null
+++ b/srcpkgs/synfigstudio/patches/fix-test-crash.patch
@@ -0,0 +1,19 @@
+Fix a crash when running tests. Source:
+https://github.com/synfig/synfig/pull/2265
+https://github.com/synfig/synfig/commit/61a290b1aaf58366149662ae0ad224127711aea8
+
+--- a/src/synfigapp/actions/layerduplicate.cpp	2021-07-12 17:45:50.000000000 +0200
++++ b/src/synfigapp/actions/layerduplicate.cpp	2021-08-15 11:52:47.878894610 +0200
+@@ -417,7 +417,11 @@
+ 
+ 		auto cloned_layer = layer_pair.second;
+ 
+-		for(auto iter=cloned_layer->dynamic_param_list().cbegin();iter!=cloned_layer->dynamic_param_list().cend();++iter)
++		// disconnect_dynamic_param/connect_dynamic_param can change dynamic_param_list() while iterating
++		// which makes iter invalid, so we create a copy of dynamic_param_list() first
++		auto param_list = cloned_layer->dynamic_param_list();
++
++		for (auto iter=param_list.cbegin();iter!=param_list.cend();++iter)
+ 		{
+ 			for (const auto& vn_pair : cloned_valuenode_map) {
+ 				if (iter->second == vn_pair.first) {
diff --git a/srcpkgs/synfigstudio/template b/srcpkgs/synfigstudio/template
index 3e40a99fb28c..359882fb1915 100644
--- a/srcpkgs/synfigstudio/template
+++ b/srcpkgs/synfigstudio/template
@@ -1,24 +1,20 @@
 # Template file for 'synfigstudio'
 pkgname=synfigstudio
-version=1.4.1
+version=1.4.2
 revision=1
 build_style=gnu-configure
 configure_args="--disable-update-mimedb"
-hostmakedepends="pkg-config intltool gettext"
+hostmakedepends="pkg-config intltool gettext synfig"
 makedepends="ETL synfig-devel gtkmm-devel libltdl-devel boost-devel"
 short_desc="Vector based 2D animation studio"
 maintainer="newbluemoon <blaumolch@mailbox.org>"
 license="GPL-2.0-or-later"
-homepage="http://www.synfig.org/"
+homepage="https://www.synfig.org/"
 distfiles="https://github.com/synfig/synfig/releases/download/v${version}/synfigstudio-${version}.tar.gz"
-checksum=af9a9b0064064907ae24a693b607dcba633a8a2cd45fa1357f61c035efd6020e
+checksum=4e86d4d8def6675fc92855a411795cc4062a1669cda82535d18b48a68b4d5497
 python_version=3
 CXXFLAGS="-Wno-deprecated-copy -DHAVE_LOCALE_H=1"
-
-if [ -n "$CROSS_BUILD" ]; then
-	# uses synfig to create some icons
-	hostmakedepends+=" synfig"
-fi
+export DATADIRNAME=share
 
 synfigstudio-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (19 preceding siblings ...)
  2021-10-12 13:39 ` newbluemoon
@ 2021-10-12 13:46 ` newbluemoon
  2021-10-12 19:07 ` [PR REVIEW] " ericonr
                   ` (3 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-10-12 13:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#issuecomment-941029012

Comment:
A fix for the failing test was merged upstream, I added it as a patch, because there is no new release with it, yet.
There is also a newer version 1.5, but it seems to be a development one so I left it at 1.4.2.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (20 preceding siblings ...)
  2021-10-12 13:46 ` newbluemoon
@ 2021-10-12 19:07 ` ericonr
  2021-10-12 19:09 ` ericonr
                   ` (2 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ericonr @ 2021-10-12 19:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r727416216

Comment:
Do you think this has a chance of being upstreamed? It's really unfortunate that we have to carry a patch at all :(

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (21 preceding siblings ...)
  2021-10-12 19:07 ` [PR REVIEW] " ericonr
@ 2021-10-12 19:09 ` ericonr
  2021-10-13 17:48 ` newbluemoon
  2021-10-13 17:50 ` newbluemoon
  24 siblings, 0 replies; 26+ messages in thread
From: ericonr @ 2021-10-12 19:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r727417514

Comment:
If synfigstudio needed this, chances are so does `synfig`. Both install locale files.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (22 preceding siblings ...)
  2021-10-12 19:09 ` ericonr
@ 2021-10-13 17:48 ` newbluemoon
  2021-10-13 17:50 ` newbluemoon
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-10-13 17:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r728312736

Comment:
We can try! :) I’ll ask upstream.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] synfig + synfigstudio: update to 1.4.2
  2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
                   ` (23 preceding siblings ...)
  2021-10-13 17:48 ` newbluemoon
@ 2021-10-13 17:50 ` newbluemoon
  24 siblings, 0 replies; 26+ messages in thread
From: newbluemoon @ 2021-10-13 17:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New review comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/32358#discussion_r728314139

Comment:
I’ll have a look into it.

^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2021-10-13 17:50 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06  8:03 [PR PATCH] synfig + synfigstudio: update to 1.4.2 newbluemoon
2021-08-06 20:17 ` newbluemoon
2021-08-06 20:22 ` ericonr
2021-08-06 20:25 ` newbluemoon
2021-08-06 20:51 ` newbluemoon
2021-08-06 21:21 ` ericonr
2021-08-07  8:32 ` newbluemoon
2021-08-07 10:43 ` sgn
2021-08-07 14:42 ` sgn
2021-08-08 19:44 ` newbluemoon
2021-08-09 11:37 ` sgn
2021-08-09 11:44 ` [PR REVIEW] " sgn
2021-08-09 14:17 ` sgn
2021-08-09 14:17 ` sgn
2021-08-09 15:20 ` sgn
2021-08-09 15:23 ` sgn
2021-08-09 20:27 ` [PR PATCH] [Updated] " newbluemoon
2021-08-09 20:35 ` [PR REVIEW] " newbluemoon
2021-08-10  2:58 ` sgn
2021-08-10 13:49 ` [PR PATCH] [Updated] " newbluemoon
2021-10-12 13:39 ` newbluemoon
2021-10-12 13:46 ` newbluemoon
2021-10-12 19:07 ` [PR REVIEW] " ericonr
2021-10-12 19:09 ` ericonr
2021-10-13 17:48 ` newbluemoon
2021-10-13 17:50 ` newbluemoon

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ https://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git