* [PR PATCH] rofi: update to 1.7.0.
@ 2021-09-05 12:38 ram02z
2021-09-05 12:43 ` ram02z
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: ram02z @ 2021-09-05 12:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
There is a new pull request by ram02z against master on the void-packages repository
https://github.com/ram02z/void-packages rofi
https://github.com/void-linux/void-packages/pull/32843
rofi: update to 1.7.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32843.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-32843.patch --]
[-- Type: text/x-diff, Size: 1319 bytes --]
From badd30b105fc6637046e0020084f14f9ac4286b8 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Sun, 5 Sep 2021 13:36:58 +0100
Subject: [PATCH] rofi: update to 1.7.0.
---
srcpkgs/rofi/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/rofi/template b/srcpkgs/rofi/template
index c012437bc6f6..83320ae2a9dd 100644
--- a/srcpkgs/rofi/template
+++ b/srcpkgs/rofi/template
@@ -1,18 +1,18 @@
# Template file for 'rofi'
pkgname=rofi
-version=1.6.1
+version=1.7.0
revision=1
build_style=gnu-configure
hostmakedepends="autoconf automake flex glib-devel pkg-config"
makedepends="check-devel libXinerama-devel librsvg-devel
libxkbcommon-devel pango-devel startup-notification-devel
- xcb-util-wm-devel xcb-util-xrm-devel"
+ xcb-util-wm-devel xcb-util-xrm-devel xcb-util-cursor-devel"
short_desc="Window switcher, run dialog and dmenu replacement"
maintainer="Dave Davenport <qball@gmpclient.org>"
license="MIT"
homepage="https://github.com/davatorium/rofi"
distfiles="https://github.com/davatorium/rofi/releases/download/${version}/rofi-${version}.tar.xz"
-checksum=424c6ea7b14b3dac324ab065e59c5f3fb877befb46914a0498e8bd4017fae98a
+checksum=aabb95b35fc30da2de75292b97d9a3f0f367805a40ffe9ee68d8213ddbc049a4
post_install() {
vlicense COPYING
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
@ 2021-09-05 12:43 ` ram02z
2021-09-05 17:15 ` ram02z
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-05 12:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
New comment by ram02z on void-packages repository
https://github.com/void-linux/void-packages/pull/32843#issuecomment-913148159
Comment:
Hmm, I tried to recompile 1.6.1 and it also segfaulted, so I thought it might have been my machine. I'll report this to upstream.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
2021-09-05 12:43 ` ram02z
@ 2021-09-05 17:15 ` ram02z
2021-09-05 17:29 ` ram02z
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-05 17:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
New comment by ram02z on void-packages repository
https://github.com/void-linux/void-packages/pull/32843#issuecomment-913148159
Comment:
Hmm, I tried to recompile 1.6.1 and it also segfaulted, so I thought it might have been my machine. I'll report this to upstream.
Edit: I tried compiling it without xbps-src and the tests pass, so maybe I am missing a dependancy in the template, not sure.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
2021-09-05 12:43 ` ram02z
2021-09-05 17:15 ` ram02z
@ 2021-09-05 17:29 ` ram02z
2021-09-05 18:51 ` ericonr
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-05 17:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
New comment by ram02z on void-packages repository
https://github.com/void-linux/void-packages/pull/32843#issuecomment-913148159
Comment:
Hmm, I tried to recompile 1.6.1 and it also segfaulted, so I thought it might have been my machine. ~I'll report this to upstream.~
Edit: I tried compiling it without xbps-src and the tests pass, so maybe I am missing a dependancy in the template, not sure.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (2 preceding siblings ...)
2021-09-05 17:29 ` ram02z
@ 2021-09-05 18:51 ` ericonr
2021-09-05 19:35 ` ram02z
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2021-09-05 18:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32843#issuecomment-913205976
Comment:
If they run tests in CI, try to see what packages they install.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (3 preceding siblings ...)
2021-09-05 18:51 ` ericonr
@ 2021-09-05 19:35 ` ram02z
2021-09-06 13:14 ` [PR PATCH] [Updated] " ram02z
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-05 19:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
New comment by ram02z on void-packages repository
https://github.com/void-linux/void-packages/pull/32843#issuecomment-913215035
Comment:
>
>
> If they run tests in CI, try to see what packages they install.
They do, here are the packages. https://github.com/davatorium/rofi/blob/1.7.0/.github/actions/setup/action.yml#L21-L33
Pretty sure the current template covers them all, different names though.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (4 preceding siblings ...)
2021-09-05 19:35 ` ram02z
@ 2021-09-06 13:14 ` ram02z
2021-09-06 13:24 ` ram02z
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-06 13:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
There is an updated pull request by ram02z against master on the void-packages repository
https://github.com/ram02z/void-packages rofi
https://github.com/void-linux/void-packages/pull/32843
rofi: update to 1.7.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32843.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-32843.patch --]
[-- Type: text/x-diff, Size: 1577 bytes --]
From f882c89c5cb3c496f36a25fc8856147a54366888 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Sun, 5 Sep 2021 13:36:58 +0100
Subject: [PATCH] rofi: update to 1.7.0.
---
srcpkgs/rofi/template | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/srcpkgs/rofi/template b/srcpkgs/rofi/template
index c012437bc6f6..6e0bfa8a8931 100644
--- a/srcpkgs/rofi/template
+++ b/srcpkgs/rofi/template
@@ -1,18 +1,20 @@
# Template file for 'rofi'
pkgname=rofi
-version=1.6.1
+version=1.7.0
revision=1
build_style=gnu-configure
-hostmakedepends="autoconf automake flex glib-devel pkg-config"
-makedepends="check-devel libXinerama-devel librsvg-devel
- libxkbcommon-devel pango-devel startup-notification-devel
- xcb-util-wm-devel xcb-util-xrm-devel"
+configure_args="--disable-check"
+hostmakedepends="autoconf automake flex pkg-config"
+makedepends="glib-devel gdk-pixbuf-devel libXinerama-devel librsvg-devel
+ libxkbcommon-devel pango-devel startup-notification-devel libxcb-devel
+ xcb-util-wm-devel xcb-util-xrm-devel xcb-util-cursor-devel"
short_desc="Window switcher, run dialog and dmenu replacement"
maintainer="Dave Davenport <qball@gmpclient.org>"
license="MIT"
homepage="https://github.com/davatorium/rofi"
distfiles="https://github.com/davatorium/rofi/releases/download/${version}/rofi-${version}.tar.xz"
-checksum=424c6ea7b14b3dac324ab065e59c5f3fb877befb46914a0498e8bd4017fae98a
+checksum=aabb95b35fc30da2de75292b97d9a3f0f367805a40ffe9ee68d8213ddbc049a4
+make_check=no
post_install() {
vlicense COPYING
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (5 preceding siblings ...)
2021-09-06 13:14 ` [PR PATCH] [Updated] " ram02z
@ 2021-09-06 13:24 ` ram02z
2021-09-06 18:09 ` ahesford
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-06 13:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
There is an updated pull request by ram02z against master on the void-packages repository
https://github.com/ram02z/void-packages rofi
https://github.com/void-linux/void-packages/pull/32843
rofi: update to 1.7.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32843.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-32843.patch --]
[-- Type: text/x-diff, Size: 1419 bytes --]
From 2df9f946963186ee2973793c84eead0be37239fe Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Sun, 5 Sep 2021 13:36:58 +0100
Subject: [PATCH] rofi: update to 1.7.0.
---
srcpkgs/rofi/template | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/rofi/template b/srcpkgs/rofi/template
index c012437bc6f6..c46401560595 100644
--- a/srcpkgs/rofi/template
+++ b/srcpkgs/rofi/template
@@ -1,18 +1,20 @@
# Template file for 'rofi'
pkgname=rofi
-version=1.6.1
+version=1.7.0
revision=1
build_style=gnu-configure
+configure_args="--disable-check"
hostmakedepends="autoconf automake flex glib-devel pkg-config"
-makedepends="check-devel libXinerama-devel librsvg-devel
+makedepends="libXinerama-devel librsvg-devel
libxkbcommon-devel pango-devel startup-notification-devel
- xcb-util-wm-devel xcb-util-xrm-devel"
+ xcb-util-wm-devel xcb-util-xrm-devel xcb-util-cursor-devel"
short_desc="Window switcher, run dialog and dmenu replacement"
maintainer="Dave Davenport <qball@gmpclient.org>"
license="MIT"
homepage="https://github.com/davatorium/rofi"
distfiles="https://github.com/davatorium/rofi/releases/download/${version}/rofi-${version}.tar.xz"
-checksum=424c6ea7b14b3dac324ab065e59c5f3fb877befb46914a0498e8bd4017fae98a
+checksum=aabb95b35fc30da2de75292b97d9a3f0f367805a40ffe9ee68d8213ddbc049a4
+make_check=no
post_install() {
vlicense COPYING
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (6 preceding siblings ...)
2021-09-06 13:24 ` ram02z
@ 2021-09-06 18:09 ` ahesford
2021-09-06 19:45 ` [PR PATCH] [Updated] " ram02z
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2021-09-06 18:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/32843#issuecomment-913797298
Comment:
For some reason, the `textbox_test` executable crashes when making a call into pango from `xbps-src`. The same executable runs fine when run from the host. Maybe it's an X11 thing? (Although blanking `$DISPLAY` doesn't cause a problem.) All other tests pass.
If the `textbox_test` failure is too much of a pain to resolve, maybe skipping that test is sufficient so we can at least run others.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (7 preceding siblings ...)
2021-09-06 18:09 ` ahesford
@ 2021-09-06 19:45 ` ram02z
2021-09-06 19:50 ` ram02z
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-06 19:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
There is an updated pull request by ram02z against master on the void-packages repository
https://github.com/ram02z/void-packages rofi
https://github.com/void-linux/void-packages/pull/32843
rofi: update to 1.7.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32843.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-32843.patch --]
[-- Type: text/x-diff, Size: 1442 bytes --]
From 01661d55ed0f6ebcf0a7a814e5177a2edc354341 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Sun, 5 Sep 2021 13:36:58 +0100
Subject: [PATCH] rofi: update to 1.7.0.
---
srcpkgs/rofi/template | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/rofi/template b/srcpkgs/rofi/template
index c012437bc6f6..cf54aa668820 100644
--- a/srcpkgs/rofi/template
+++ b/srcpkgs/rofi/template
@@ -1,18 +1,20 @@
# Template file for 'rofi'
pkgname=rofi
-version=1.6.1
+version=1.7.0
revision=1
build_style=gnu-configure
+make_check_args="XFAIL_TESTS=textbox_test"
hostmakedepends="autoconf automake flex glib-devel pkg-config"
-makedepends="check-devel libXinerama-devel librsvg-devel
+makedepends="libXinerama-devel librsvg-devel
libxkbcommon-devel pango-devel startup-notification-devel
- xcb-util-wm-devel xcb-util-xrm-devel"
+ xcb-util-wm-devel xcb-util-xrm-devel xcb-util-cursor-devel"
+checkdepends="check-devel"
short_desc="Window switcher, run dialog and dmenu replacement"
maintainer="Dave Davenport <qball@gmpclient.org>"
license="MIT"
homepage="https://github.com/davatorium/rofi"
distfiles="https://github.com/davatorium/rofi/releases/download/${version}/rofi-${version}.tar.xz"
-checksum=424c6ea7b14b3dac324ab065e59c5f3fb877befb46914a0498e8bd4017fae98a
+checksum=aabb95b35fc30da2de75292b97d9a3f0f367805a40ffe9ee68d8213ddbc049a4
post_install() {
vlicense COPYING
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (8 preceding siblings ...)
2021-09-06 19:45 ` [PR PATCH] [Updated] " ram02z
@ 2021-09-06 19:50 ` ram02z
2021-09-06 19:53 ` ram02z
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-06 19:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
There is an updated pull request by ram02z against master on the void-packages repository
https://github.com/ram02z/void-packages rofi
https://github.com/void-linux/void-packages/pull/32843
rofi: update to 1.7.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32843.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-32843.patch --]
[-- Type: text/x-diff, Size: 1364 bytes --]
From b6945b35ce78e773127c23faff9254514efeec68 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Sun, 5 Sep 2021 13:36:58 +0100
Subject: [PATCH] rofi: update to 1.7.0.
---
srcpkgs/rofi/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/rofi/template b/srcpkgs/rofi/template
index c012437bc6f6..a0a1c95abd39 100644
--- a/srcpkgs/rofi/template
+++ b/srcpkgs/rofi/template
@@ -1,18 +1,19 @@
# Template file for 'rofi'
pkgname=rofi
-version=1.6.1
+version=1.7.0
revision=1
build_style=gnu-configure
+make_check_args="XFAIL_TESTS=textbox_test"
hostmakedepends="autoconf automake flex glib-devel pkg-config"
makedepends="check-devel libXinerama-devel librsvg-devel
libxkbcommon-devel pango-devel startup-notification-devel
- xcb-util-wm-devel xcb-util-xrm-devel"
+ xcb-util-wm-devel xcb-util-xrm-devel xcb-util-cursor-devel"
short_desc="Window switcher, run dialog and dmenu replacement"
maintainer="Dave Davenport <qball@gmpclient.org>"
license="MIT"
homepage="https://github.com/davatorium/rofi"
distfiles="https://github.com/davatorium/rofi/releases/download/${version}/rofi-${version}.tar.xz"
-checksum=424c6ea7b14b3dac324ab065e59c5f3fb877befb46914a0498e8bd4017fae98a
+checksum=aabb95b35fc30da2de75292b97d9a3f0f367805a40ffe9ee68d8213ddbc049a4
post_install() {
vlicense COPYING
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (9 preceding siblings ...)
2021-09-06 19:50 ` ram02z
@ 2021-09-06 19:53 ` ram02z
2021-09-06 19:54 ` ahesford
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-06 19:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
New comment by ram02z on void-packages repository
https://github.com/void-linux/void-packages/pull/32843#issuecomment-913830350
Comment:
>
> If the `textbox_test` failure is too much of a pain to resolve, maybe skipping that test is sufficient so we can at least run others.
Yeah after comparing other templates, I can't seem to find a resolution. I used the `XFAIL_TESTS` variable to skip the test. I don't have much experience with automake, so let me know if there is another approach.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (10 preceding siblings ...)
2021-09-06 19:53 ` ram02z
@ 2021-09-06 19:54 ` ahesford
2021-09-06 19:57 ` [PR PATCH] [Updated] " ram02z
2021-09-06 20:06 ` [PR PATCH] [Closed]: " ahesford
13 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2021-09-06 19:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/32843#issuecomment-913830403
Comment:
You need `which` in `hostmakedepends`, the build is trying to run it for something.
Also, make the checks depend on whether xbps-src actually enables checks:
```sh
if [ "$XBPS_CHECK_PKGS" ]; then
makedepends+=" check-devel"
else
configure_args+=" --disable-check"
fi
```
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (11 preceding siblings ...)
2021-09-06 19:54 ` ahesford
@ 2021-09-06 19:57 ` ram02z
2021-09-06 20:06 ` [PR PATCH] [Closed]: " ahesford
13 siblings, 0 replies; 15+ messages in thread
From: ram02z @ 2021-09-06 19:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
There is an updated pull request by ram02z against master on the void-packages repository
https://github.com/ram02z/void-packages rofi
https://github.com/void-linux/void-packages/pull/32843
rofi: update to 1.7.0.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/32843.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-32843.patch --]
[-- Type: text/x-diff, Size: 1604 bytes --]
From 487d1b218f3394662ff94f6c1bcb2ecab6c54e25 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Sun, 5 Sep 2021 13:36:58 +0100
Subject: [PATCH] rofi: update to 1.7.0.
---
srcpkgs/rofi/template | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/rofi/template b/srcpkgs/rofi/template
index c012437bc6f6..b3aab8f8fd30 100644
--- a/srcpkgs/rofi/template
+++ b/srcpkgs/rofi/template
@@ -1,18 +1,25 @@
# Template file for 'rofi'
pkgname=rofi
-version=1.6.1
+version=1.7.0
revision=1
build_style=gnu-configure
-hostmakedepends="autoconf automake flex glib-devel pkg-config"
-makedepends="check-devel libXinerama-devel librsvg-devel
+make_check_args="XFAIL_TESTS=textbox_test"
+hostmakedepends="autoconf automake flex glib-devel pkg-config which"
+makedepends="libXinerama-devel librsvg-devel
libxkbcommon-devel pango-devel startup-notification-devel
- xcb-util-wm-devel xcb-util-xrm-devel"
+ xcb-util-wm-devel xcb-util-xrm-devel xcb-util-cursor-devel"
short_desc="Window switcher, run dialog and dmenu replacement"
maintainer="Dave Davenport <qball@gmpclient.org>"
license="MIT"
homepage="https://github.com/davatorium/rofi"
distfiles="https://github.com/davatorium/rofi/releases/download/${version}/rofi-${version}.tar.xz"
-checksum=424c6ea7b14b3dac324ab065e59c5f3fb877befb46914a0498e8bd4017fae98a
+checksum=aabb95b35fc30da2de75292b97d9a3f0f367805a40ffe9ee68d8213ddbc049a4
+
+if [ "$XBPS_CHECK_PKGS" ]; then
+ makedepends+=" check-devel"
+else
+ configure_args+=" --disable-check"
+fi
post_install() {
vlicense COPYING
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Closed]: rofi: update to 1.7.0.
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
` (12 preceding siblings ...)
2021-09-06 19:57 ` [PR PATCH] [Updated] " ram02z
@ 2021-09-06 20:06 ` ahesford
13 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2021-09-06 20:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
There's a closed pull request on the void-packages repository
rofi: update to 1.7.0.
https://github.com/void-linux/void-packages/pull/32843
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-09-06 20:06 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 12:38 [PR PATCH] rofi: update to 1.7.0 ram02z
2021-09-05 12:43 ` ram02z
2021-09-05 17:15 ` ram02z
2021-09-05 17:29 ` ram02z
2021-09-05 18:51 ` ericonr
2021-09-05 19:35 ` ram02z
2021-09-06 13:14 ` [PR PATCH] [Updated] " ram02z
2021-09-06 13:24 ` ram02z
2021-09-06 18:09 ` ahesford
2021-09-06 19:45 ` [PR PATCH] [Updated] " ram02z
2021-09-06 19:50 ` ram02z
2021-09-06 19:53 ` ram02z
2021-09-06 19:54 ` ahesford
2021-09-06 19:57 ` [PR PATCH] [Updated] " ram02z
2021-09-06 20:06 ` [PR PATCH] [Closed]: " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).