Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] perl-File-MimeInfo: update to 0.30.
@ 2021-09-16 15:25 hdinc
  2021-09-17 16:03 ` [PR REVIEW] " ahesford
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: hdinc @ 2021-09-16 15:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

There is a new pull request by hdinc against master on the void-packages repository

https://github.com/hdinc/void-packages master
https://github.com/void-linux/void-packages/pull/32981

perl-File-MimeInfo: update to 0.30.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32981.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32981.patch --]
[-- Type: text/x-diff, Size: 1378 bytes --]

From 93b04e0db876e4a39203654a32332fe3e9bad81b Mon Sep 17 00:00:00 2001
From: hdinc <macellan091@gmail.com>
Date: Thu, 16 Sep 2021 18:15:29 +0300
Subject: [PATCH] perl-File-MimeInfo: update to 0.30.

---
 srcpkgs/perl-File-MimeInfo/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/perl-File-MimeInfo/template b/srcpkgs/perl-File-MimeInfo/template
index a29a216f9f8b..4addcc99e3b3 100644
--- a/srcpkgs/perl-File-MimeInfo/template
+++ b/srcpkgs/perl-File-MimeInfo/template
@@ -1,15 +1,15 @@
 # Template file for 'perl-File-MimeInfo'
 pkgname=perl-File-MimeInfo
-version=0.29
-revision=2
+version=0.30
+revision=1
 wrksrc="${pkgname/perl-/}-${version}"
 build_style=perl-module
 hostmakedepends="perl"
-makedepends="${hostmakedepends} perl-File-BaseDir perl-File-DesktopEntry"
+makedepends="${hostmakedepends} perl-File-BaseDir perl-File-DesktopEntry perl-Encode-Locale"
 depends="$makedepends"
 short_desc="Perl utility to detect file mimetypes and open them accordingly"
 maintainer="crater2150 <void@qwertyuiop.de>"
 license="Artistic-1.0-Perl, GPL-1.0-or-later"
 homepage="https://metacpan.org/release/File-MimeInfo"
 distfiles="${CPAN_SITE}/File/${pkgname/perl-/}-${version}.tar.gz"
-checksum=f1962779652eae1d5a6e722a5220e3c50465deac52bb8dea47e0fbcfb6c908ea
+checksum=e2c6e4bf90be3b863bfb4efadbcb1b4b029fc74f4e794bd86965aca7ee3ba872

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] perl-File-MimeInfo: update to 0.30.
  2021-09-16 15:25 [PR PATCH] perl-File-MimeInfo: update to 0.30 hdinc
@ 2021-09-17 16:03 ` ahesford
  2021-09-17 20:37 ` [PR PATCH] [Updated] " hdinc
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2021-09-17 16:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/32981#discussion_r711179490

Comment:
Please drop `${hostmakedepends}` from `makedepends`. The other `perl-*` packages will automatically pull in `perl` itself, plus using `$hostmakedepends` like that is bad form since a later change to `hostmakedepends` might cause unnoticed `makedepends` creep.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] perl-File-MimeInfo: update to 0.30.
  2021-09-16 15:25 [PR PATCH] perl-File-MimeInfo: update to 0.30 hdinc
  2021-09-17 16:03 ` [PR REVIEW] " ahesford
@ 2021-09-17 20:37 ` hdinc
  2021-09-18 14:04 ` [PR REVIEW] " hdinc
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: hdinc @ 2021-09-17 20:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

There is an updated pull request by hdinc against master on the void-packages repository

https://github.com/hdinc/void-packages master
https://github.com/void-linux/void-packages/pull/32981

perl-File-MimeInfo: update to 0.30.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32981.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-32981.patch --]
[-- Type: text/x-diff, Size: 2293 bytes --]

From 93b04e0db876e4a39203654a32332fe3e9bad81b Mon Sep 17 00:00:00 2001
From: hdinc <macellan091@gmail.com>
Date: Thu, 16 Sep 2021 18:15:29 +0300
Subject: [PATCH 1/2] perl-File-MimeInfo: update to 0.30.

---
 srcpkgs/perl-File-MimeInfo/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/perl-File-MimeInfo/template b/srcpkgs/perl-File-MimeInfo/template
index a29a216f9f8b..4addcc99e3b3 100644
--- a/srcpkgs/perl-File-MimeInfo/template
+++ b/srcpkgs/perl-File-MimeInfo/template
@@ -1,15 +1,15 @@
 # Template file for 'perl-File-MimeInfo'
 pkgname=perl-File-MimeInfo
-version=0.29
-revision=2
+version=0.30
+revision=1
 wrksrc="${pkgname/perl-/}-${version}"
 build_style=perl-module
 hostmakedepends="perl"
-makedepends="${hostmakedepends} perl-File-BaseDir perl-File-DesktopEntry"
+makedepends="${hostmakedepends} perl-File-BaseDir perl-File-DesktopEntry perl-Encode-Locale"
 depends="$makedepends"
 short_desc="Perl utility to detect file mimetypes and open them accordingly"
 maintainer="crater2150 <void@qwertyuiop.de>"
 license="Artistic-1.0-Perl, GPL-1.0-or-later"
 homepage="https://metacpan.org/release/File-MimeInfo"
 distfiles="${CPAN_SITE}/File/${pkgname/perl-/}-${version}.tar.gz"
-checksum=f1962779652eae1d5a6e722a5220e3c50465deac52bb8dea47e0fbcfb6c908ea
+checksum=e2c6e4bf90be3b863bfb4efadbcb1b4b029fc74f4e794bd86965aca7ee3ba872

From 6734ac56c16aff01f80e012e9fe3d8d2c2c2c603 Mon Sep 17 00:00:00 2001
From: hdinc <macellan091@gmail.com>
Date: Fri, 17 Sep 2021 23:37:44 +0300
Subject: [PATCH 2/2] fix

---
 srcpkgs/perl-File-MimeInfo/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/perl-File-MimeInfo/template b/srcpkgs/perl-File-MimeInfo/template
index 4addcc99e3b3..8b10bfdcefd9 100644
--- a/srcpkgs/perl-File-MimeInfo/template
+++ b/srcpkgs/perl-File-MimeInfo/template
@@ -5,7 +5,7 @@ revision=1
 wrksrc="${pkgname/perl-/}-${version}"
 build_style=perl-module
 hostmakedepends="perl"
-makedepends="${hostmakedepends} perl-File-BaseDir perl-File-DesktopEntry perl-Encode-Locale"
+makedepends="perl-File-BaseDir perl-File-DesktopEntry perl-Encode-Locale"
 depends="$makedepends"
 short_desc="Perl utility to detect file mimetypes and open them accordingly"
 maintainer="crater2150 <void@qwertyuiop.de>"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] perl-File-MimeInfo: update to 0.30.
  2021-09-16 15:25 [PR PATCH] perl-File-MimeInfo: update to 0.30 hdinc
  2021-09-17 16:03 ` [PR REVIEW] " ahesford
  2021-09-17 20:37 ` [PR PATCH] [Updated] " hdinc
@ 2021-09-18 14:04 ` hdinc
  2021-09-19  1:21 ` ahesford
  2021-09-19  1:21 ` [PR PATCH] [Closed]: " ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: hdinc @ 2021-09-18 14:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New review comment by hdinc on void-packages repository

https://github.com/void-linux/void-packages/pull/32981#discussion_r711594622

Comment:
Done.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: perl-File-MimeInfo: update to 0.30.
  2021-09-16 15:25 [PR PATCH] perl-File-MimeInfo: update to 0.30 hdinc
                   ` (2 preceding siblings ...)
  2021-09-18 14:04 ` [PR REVIEW] " hdinc
@ 2021-09-19  1:21 ` ahesford
  2021-09-19  1:21 ` [PR PATCH] [Closed]: " ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2021-09-19  1:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/32981#issuecomment-922397908

Comment:
Squashed and merged in 41435a1bb033

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: perl-File-MimeInfo: update to 0.30.
  2021-09-16 15:25 [PR PATCH] perl-File-MimeInfo: update to 0.30 hdinc
                   ` (3 preceding siblings ...)
  2021-09-19  1:21 ` ahesford
@ 2021-09-19  1:21 ` ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2021-09-19  1:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

There's a closed pull request on the void-packages repository

perl-File-MimeInfo: update to 0.30.
https://github.com/void-linux/void-packages/pull/32981

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-19  1:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 15:25 [PR PATCH] perl-File-MimeInfo: update to 0.30 hdinc
2021-09-17 16:03 ` [PR REVIEW] " ahesford
2021-09-17 20:37 ` [PR PATCH] [Updated] " hdinc
2021-09-18 14:04 ` [PR REVIEW] " hdinc
2021-09-19  1:21 ` ahesford
2021-09-19  1:21 ` [PR PATCH] [Closed]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).