[PR PATCH] ncurses: install non-wide pkg-config files

[PR PATCH] ncurses: install non-wide pkg-config files

[r-c-f]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

There is a new pull request by r-c-f against master on the void-packages repository

https://github.com/r-c-f/void-packages ncurses-nonwide-pc
https://github.com/void-linux/void-packages/pull/32988

ncurses: install non-wide pkg-config files
Currently, there are symlinks to fool non-wide users into using the
proper .so/.a files, but pkg-config is unable to make use of them. This
installs the .pc files (which were already being generated). Fixes #32987

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [x] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/32988.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncurses-nonwide-pc-32988.patch --]
[-- Type: text/x-diff, Size: 1648 bytes --]

From 4d7e7501b95f48127a25266a37cbd2a14c9d41df Mon Sep 17 00:00:00 2001
From: Ryan Farley <ryan.farley@gmx.com>
Date: Thu, 16 Sep 2021 19:39:22 -0500
Subject: [PATCH] ncurses: install non-wide pkg-config files

Currently, there are symlinks to fool non-wide users into using the
proper .so/.a files, but pkg-config is unable to make use of them. This
installs the .pc files (which were already being generated).
---
 srcpkgs/ncurses/template | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/ncurses/template b/srcpkgs/ncurses/template
index 90454e01ec10..7c96a8f3a00a 100644
--- a/srcpkgs/ncurses/template
+++ b/srcpkgs/ncurses/template
@@ -1,7 +1,7 @@
 # Template file for 'ncurses'
 pkgname=ncurses
 version=6.2
-revision=4
+revision=5
 bootstrap=yes
 configure_args="--enable-big-core"
 short_desc="System V Release 4.0 curses emulation library"
@@ -50,6 +50,9 @@ do_build() {
 do_install() {
 	vlicense COPYING
 
+	cd ${wrksrc}/ncurses-build/misc
+	make DESTDIR=${DESTDIR} install
+
 	cd ${wrksrc}/ncursesw-build
 	make DESTDIR=${DESTDIR} install
 
@@ -110,11 +113,10 @@ ncurses-devel_package() {
 	pkg_install() {
 		vmove "usr/bin/ncurses*-config"
 		vmove usr/include
-		vmove usr/lib/pkgconfig/ncursesw.pc
-		vmove usr/lib/pkgconfig/formw.pc
-		vmove usr/lib/pkgconfig/menuw.pc
-		vmove usr/lib/pkgconfig/ncurses++w.pc
-		vmove usr/lib/pkgconfig/panelw.pc
+		vmove "usr/lib/pkgconfig/ncurses*.pc"
+		vmove "usr/lib/pkgconfig/form*.pc"
+		vmove "usr/lib/pkgconfig/menu*.pc"
+		vmove "usr/lib/pkgconfig/panel*.pc"
 		vmove "usr/lib/*.a"
 		vmove "usr/lib/libcurses*.so"
 		vmove "usr/lib/libform*.so"

Re: [PR PATCH] [Closed]: ncurses: install non-wide pkg-config files

[q66]

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

There's a closed pull request on the void-packages repository

ncurses: install non-wide pkg-config files
https://github.com/void-linux/void-packages/pull/32988

Description:
Currently, there are symlinks to fool non-wide users into using the
proper .so/.a files, but pkg-config is unable to make use of them. This
installs the .pc files (which were already being generated). Fixes #32987

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [x] armv7l
  - [ ] armv6l-musl

Re: ncurses: install non-wide pkg-config files

[q66]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/32988#issuecomment-925377075

Comment:
this is intended, the non-widechar versions are not meant to be linked against and exist only for compatibility

Re: ncurses: install non-wide pkg-config files

[q66]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/32988#issuecomment-925377075

Comment:
this is intended, the non-widechar versions are not meant to be linked against and exist only for compatibility

software making bad assumptions at build time should be patched instead