[PR PATCH] Added xz as dependency

[PR PATCH] Added xz as dependency

[efade]

[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]

There is a new pull request by efade against master on the void-packages repository

https://github.com/efade/void-packages patch-2
https://github.com/void-linux/void-packages/pull/33020

Added xz as dependency
Vivaldi doesn't use system library to play proprietary codec. It downloads its own ffmpeg library using a script named update-ffmpeg whenever it was installed or upgraded. The script needs xz installed otherwise it will fail and the ffmpeg library needed to play proprietary code won't be downloaded.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33020.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-33020.patch --]
[-- Type: text/x-diff, Size: 1158 bytes --]

From cc2603e22e8c987e28d02be3d96d1ce835fa5e62 Mon Sep 17 00:00:00 2001
From: Fakhruddin Ahmad Darwis <fakhri.satu@gmail.com>
Date: Sun, 19 Sep 2021 19:10:33 +0700
Subject: [PATCH] Added xz as dependency

Vivaldi doesn't use system library to play proprietary codec. It downloads its own ffmpeg library using a script named update-ffmpeg whenever it was installed or upgraded. The script needs xz installed otherwise it will fail and the ffmpeg library needed to play proprietary code won't be downloaded.
---
 srcpkgs/vivaldi/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/vivaldi/template b/srcpkgs/vivaldi/template
index 3ceec7c1865e..d27b157f5c22 100644
--- a/srcpkgs/vivaldi/template
+++ b/srcpkgs/vivaldi/template
@@ -5,7 +5,7 @@ revision=1
 _release=1
 archs="x86_64"
 hostmakedepends="curl python3-html2text python3-setuptools"
-depends="desktop-file-utils hicolor-icon-theme"
+depends="desktop-file-utils hicolor-icon-theme xz"
 short_desc="Advanced browser made with the power user in mind"
 maintainer="Diogo Leal <diogo@diogoleal.com>"
 # EULA: https://vivaldi.com/privacy/vivaldi-end-user-license-agreement/

Re: Added xz as dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-922468703

Comment:
* the commit messages should follow the [conventions](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes)
* increase revision, otherwise the package will not have any effect until the next update

cc @rafeyu

Re: vivaldi: added xz as dependency

[efade]

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

New comment by efade on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-922469722

Comment:
> * the commit messages should follow the [conventions](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes)
> * increase revision, otherwise the package will not have any effect until the next update
> 
> cc @rafeyu



> * the commit messages should follow the [conventions](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes)
> * increase revision, otherwise the package will not have any effect until the next update
> 
> cc @rafeyu

Sorry. My bad. Edited the message. Is it correct?

Re: vivaldi: added xz as dependency

[rafeyu]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by rafeyu on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-922481471

Comment:
@paper42 Ok got it

Re: vivaldi: added xz as dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

New comment by efade on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-922469722

Comment:
> * the commit messages should follow the [conventions](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes)
> * increase revision, otherwise the package will not have any effect until the next update
> 
> cc @rafeyu

Sorry. My bad. Edited the message. Is it correct?

Re: vivaldi: added xz as dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-922487339

Comment:
> > * the commit messages should follow the [conventions](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md?rgh-link-date=2021-09-19T12%3A57%3A15Z#committing-your-changes)
> > * increase revision, otherwise the package will not have any effect until the next update
> > 
> > cc @rafeyu
> 
> Sorry. My bad. Edited the message. Is it correct?

You edited the PR title, not the commit title. Could you run `git commit --amend` and edit the title there? It should be something like `vivaldi: add xz dependency` (imperative is preferred in commit messages).

Re: vivaldi: added xz as dependency

[rafeyu]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by rafeyu on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-922481471

Comment:
@paper42 Ok got it.

I don't think I'll fix this. Let @efade fix with right conventions.

But if this PR doesn't getting merge, I'll fix it in the next release.

Re: vivaldi: added xz as dependency

[rafeyu]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by rafeyu on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-922481471

Comment:
@paper42 Ok got it.

I don't think I'll fix this. Let @efade fix with right conventions.

But if this PR doesn't getting merged, I'll fix it in the next release.

Re: vivaldi: added xz as dependency

[rafeyu]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by rafeyu on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-927009968

Comment:
Fixed in new update #33054 

Re: vivaldi: added xz as dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33020#issuecomment-927129543

Comment:
Fix merged in #33054, thank you for your contribution

Re: [PR PATCH] [Closed]: vivaldi: added xz as dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]

There's a closed pull request on the void-packages repository

vivaldi: added xz as dependency
https://github.com/void-linux/void-packages/pull/33020

Description:
Without xz, the update-ffmpeg script will fail and user won't be able to play proprietary codec. 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [X] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->