Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pyradio: update to 0.8.9.9.
@ 2021-10-01 16:14 mobinmob
  2021-10-01 19:25 ` [PR REVIEW] " paper42
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: mobinmob @ 2021-10-01 16:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages pyradio
https://github.com/void-linux/void-packages/pull/33210

pyradio: update to 0.8.9.9.
Also:
- add proper dependencies
- disable tests (nothing runs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pyradio-33210.patch --]
[-- Type: text/x-diff, Size: 1330 bytes --]

From a835f8b7b527939725730963bbb2304c522f99a0 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Fri, 1 Oct 2021 19:11:29 +0300
Subject: [PATCH] pyradio: update to 0.8.9.9.

Also:
- add proper dependencies
- disable tests (nothing runs).
---
 srcpkgs/pyradio/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pyradio/template b/srcpkgs/pyradio/template
index 209f439da0b9..d9d9de189948 100644
--- a/srcpkgs/pyradio/template
+++ b/srcpkgs/pyradio/template
@@ -1,17 +1,21 @@
 # Template file for 'pyradio'
 pkgname=pyradio
-version=0.8.7.3
+version=0.8.9.9
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3 python3-requests python3-dnspython"
 short_desc="Curses based internet radio player"
 maintainer="Lugubris <lugubris@disroot.org>"
 license="MIT"
 homepage="http://www.coderholic.com/pyradio/"
 changelog="https://raw.githubusercontent.com/coderholic/pyradio/master/ChangeLog"
 distfiles="https://github.com/coderholic/pyradio/archive/${version}.tar.gz"
-checksum=a483ac1601fc89ee3a72fb30b290e06f58dc585b07acec6d776b2640ab7c90f6
+checksum=9114254088e294bf06399f892c08056d86172bd32c40869474347eb846a965f3
+
+do_check() {
+	: # pytest reports "no tests ran" 
+}
 
 post_install() {
 	vman pyradio.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] pyradio: update to 0.8.9.9.
  2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
@ 2021-10-01 19:25 ` paper42
  2021-10-01 19:25 ` paper42
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2021-10-01 19:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33210#discussion_r720490342

Comment:
you don't need to list python3 as a dependency when the package already depends on other python packages (because they depend on python3) 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] pyradio: update to 0.8.9.9.
  2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
  2021-10-01 19:25 ` [PR REVIEW] " paper42
@ 2021-10-01 19:25 ` paper42
  2021-10-02 17:45 ` [PR PATCH] [Updated] " mobinmob
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2021-10-01 19:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33210#discussion_r720490021

Comment:
we now prefer `make_check=no # comment`

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] pyradio: update to 0.8.9.9.
  2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
  2021-10-01 19:25 ` [PR REVIEW] " paper42
  2021-10-01 19:25 ` paper42
@ 2021-10-02 17:45 ` mobinmob
  2021-10-02 17:46 ` [PR REVIEW] " mobinmob
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2021-10-02 17:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages pyradio
https://github.com/void-linux/void-packages/pull/33210

pyradio: update to 0.8.9.9.
Also:
- add proper dependencies
- disable tests (nothing runs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pyradio-33210.patch --]
[-- Type: text/x-diff, Size: 1311 bytes --]

From f66cca56ad07f0c5ca452eb6ce0d896076dfc034 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Fri, 1 Oct 2021 19:11:29 +0300
Subject: [PATCH] pyradio: update to 0.8.9.9.

Also:
- add proper dependencies
- disable tests (nothing runs).
---
 srcpkgs/pyradio/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pyradio/template b/srcpkgs/pyradio/template
index 209f439da0b9..5483640d70d4 100644
--- a/srcpkgs/pyradio/template
+++ b/srcpkgs/pyradio/template
@@ -1,17 +1,19 @@
 # Template file for 'pyradio'
 pkgname=pyradio
-version=0.8.7.3
+version=0.8.9.9
 revision=1
 build_style=python3-module
+make_check=no # pytest reports "no tests ran
 hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3-requests python3-dnspython"
 short_desc="Curses based internet radio player"
 maintainer="Lugubris <lugubris@disroot.org>"
 license="MIT"
 homepage="http://www.coderholic.com/pyradio/"
 changelog="https://raw.githubusercontent.com/coderholic/pyradio/master/ChangeLog"
 distfiles="https://github.com/coderholic/pyradio/archive/${version}.tar.gz"
-checksum=a483ac1601fc89ee3a72fb30b290e06f58dc585b07acec6d776b2640ab7c90f6
+checksum=9114254088e294bf06399f892c08056d86172bd32c40869474347eb846a965f3
+
 
 post_install() {
 	vman pyradio.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] pyradio: update to 0.8.9.9.
  2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
                   ` (2 preceding siblings ...)
  2021-10-02 17:45 ` [PR PATCH] [Updated] " mobinmob
@ 2021-10-02 17:46 ` mobinmob
  2021-10-02 17:46 ` mobinmob
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2021-10-02 17:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/33210#discussion_r720707832

Comment:
Much better ;) 
Done, thanx!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] pyradio: update to 0.8.9.9.
  2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
                   ` (3 preceding siblings ...)
  2021-10-02 17:46 ` [PR REVIEW] " mobinmob
@ 2021-10-02 17:46 ` mobinmob
  2021-10-02 17:47 ` [PR PATCH] [Updated] " mobinmob
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2021-10-02 17:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/33210#discussion_r720707854

Comment:
Done!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] pyradio: update to 0.8.9.9.
  2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
                   ` (4 preceding siblings ...)
  2021-10-02 17:46 ` mobinmob
@ 2021-10-02 17:47 ` mobinmob
  2021-10-02 17:49 ` mobinmob
  2021-10-02 19:40 ` [PR PATCH] [Merged]: " ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2021-10-02 17:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages pyradio
https://github.com/void-linux/void-packages/pull/33210

pyradio: update to 0.8.9.9.
Also:
- add proper dependencies
- disable tests (nothing runs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pyradio-33210.patch --]
[-- Type: text/x-diff, Size: 1308 bytes --]

From 66a05444d9af711b5265b8cd8758bd8165af3c2a Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Fri, 1 Oct 2021 19:11:29 +0300
Subject: [PATCH] pyradio: update to 0.8.9.9.

Also:
- add proper dependencies
- disable tests (nothing runs).
---
 srcpkgs/pyradio/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pyradio/template b/srcpkgs/pyradio/template
index 209f439da0b9..6ffc333df7e9 100644
--- a/srcpkgs/pyradio/template
+++ b/srcpkgs/pyradio/template
@@ -1,17 +1,18 @@
 # Template file for 'pyradio'
 pkgname=pyradio
-version=0.8.7.3
+version=0.8.9.9
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3-requests python3-dnspython"
 short_desc="Curses based internet radio player"
 maintainer="Lugubris <lugubris@disroot.org>"
 license="MIT"
 homepage="http://www.coderholic.com/pyradio/"
 changelog="https://raw.githubusercontent.com/coderholic/pyradio/master/ChangeLog"
 distfiles="https://github.com/coderholic/pyradio/archive/${version}.tar.gz"
-checksum=a483ac1601fc89ee3a72fb30b290e06f58dc585b07acec6d776b2640ab7c90f6
+checksum=9114254088e294bf06399f892c08056d86172bd32c40869474347eb846a965f3
+make_check=no # pytest reports "no tests ran
 
 post_install() {
 	vman pyradio.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] pyradio: update to 0.8.9.9.
  2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
                   ` (5 preceding siblings ...)
  2021-10-02 17:47 ` [PR PATCH] [Updated] " mobinmob
@ 2021-10-02 17:49 ` mobinmob
  2021-10-02 19:40 ` [PR PATCH] [Merged]: " ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: mobinmob @ 2021-10-02 17:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages pyradio
https://github.com/void-linux/void-packages/pull/33210

pyradio: update to 0.8.9.9.
Also:
- add proper dependencies
- disable tests (nothing runs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33210.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pyradio-33210.patch --]
[-- Type: text/x-diff, Size: 1309 bytes --]

From 8dffe97c7b6664f0d2ba6967ed29d51f51738648 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Fri, 1 Oct 2021 19:11:29 +0300
Subject: [PATCH] pyradio: update to 0.8.9.9.

Also:
- add proper dependencies
- disable tests (nothing runs).
---
 srcpkgs/pyradio/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/pyradio/template b/srcpkgs/pyradio/template
index 209f439da0b9..2acc624db61d 100644
--- a/srcpkgs/pyradio/template
+++ b/srcpkgs/pyradio/template
@@ -1,17 +1,18 @@
 # Template file for 'pyradio'
 pkgname=pyradio
-version=0.8.7.3
+version=0.8.9.9
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3-requests python3-dnspython"
 short_desc="Curses based internet radio player"
 maintainer="Lugubris <lugubris@disroot.org>"
 license="MIT"
 homepage="http://www.coderholic.com/pyradio/"
 changelog="https://raw.githubusercontent.com/coderholic/pyradio/master/ChangeLog"
 distfiles="https://github.com/coderholic/pyradio/archive/${version}.tar.gz"
-checksum=a483ac1601fc89ee3a72fb30b290e06f58dc585b07acec6d776b2640ab7c90f6
+checksum=9114254088e294bf06399f892c08056d86172bd32c40869474347eb846a965f3
+make_check=no # pytest reports "no tests ran"
 
 post_install() {
 	vman pyradio.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: pyradio: update to 0.8.9.9.
  2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
                   ` (6 preceding siblings ...)
  2021-10-02 17:49 ` mobinmob
@ 2021-10-02 19:40 ` ericonr
  7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-10-02 19:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

There's a merged pull request on the void-packages repository

pyradio: update to 0.8.9.9.
https://github.com/void-linux/void-packages/pull/33210

Description:
Also:
- add proper dependencies
- disable tests (nothing runs).

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-10-02 19:40 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 16:14 [PR PATCH] pyradio: update to 0.8.9.9 mobinmob
2021-10-01 19:25 ` [PR REVIEW] " paper42
2021-10-01 19:25 ` paper42
2021-10-02 17:45 ` [PR PATCH] [Updated] " mobinmob
2021-10-02 17:46 ` [PR REVIEW] " mobinmob
2021-10-02 17:46 ` mobinmob
2021-10-02 17:47 ` [PR PATCH] [Updated] " mobinmob
2021-10-02 17:49 ` mobinmob
2021-10-02 19:40 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).