* [PR PATCH] [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
@ 2021-10-02 23:06 mahiuchun
2021-10-02 23:09 ` ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: mahiuchun @ 2021-10-02 23:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]
There is a new pull request by mahiuchun against master on the void-packages repository
https://github.com/mahiuchun/void-packages led
https://github.com/void-linux/void-packages/pull/33275
[ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
See https://github.com/void-ppc/void-packages/pull/48 for the reason of this change. It was applied to previous versions of Linux.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33275.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-led-33275.patch --]
[-- Type: text/x-diff, Size: 1256 bytes --]
From 9bf81df5b58adad61c93be257e803b202ff09b66 Mon Sep 17 00:00:00 2001
From: Hill Ma <maahiuzeon@gmail.com>
Date: Sat, 2 Oct 2021 16:03:42 -0700
Subject: [PATCH] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
---
srcpkgs/linux5.13/files/ppc-dotconfig | 2 +-
srcpkgs/linux5.14/files/ppc-dotconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/linux5.13/files/ppc-dotconfig b/srcpkgs/linux5.13/files/ppc-dotconfig
index 7e08591b96da..b1aa275a73c3 100644
--- a/srcpkgs/linux5.13/files/ppc-dotconfig
+++ b/srcpkgs/linux5.13/files/ppc-dotconfig
@@ -2290,7 +2290,7 @@ CONFIG_ADB=y
CONFIG_ADB_CUDA=y
CONFIG_ADB_PMU=y
CONFIG_ADB_PMU_LED=y
-CONFIG_ADB_PMU_LED_DISK=y
+# CONFIG_ADB_PMU_LED_DISK is not set
CONFIG_PMAC_APM_EMU=m
CONFIG_PMAC_MEDIABAY=y
CONFIG_PMAC_BACKLIGHT=y
diff --git a/srcpkgs/linux5.14/files/ppc-dotconfig b/srcpkgs/linux5.14/files/ppc-dotconfig
index c33f11d33f45..9b1396be86b7 100644
--- a/srcpkgs/linux5.14/files/ppc-dotconfig
+++ b/srcpkgs/linux5.14/files/ppc-dotconfig
@@ -2294,7 +2294,7 @@ CONFIG_ADB=y
CONFIG_ADB_CUDA=y
CONFIG_ADB_PMU=y
CONFIG_ADB_PMU_LED=y
-CONFIG_ADB_PMU_LED_DISK=y
+# CONFIG_ADB_PMU_LED_DISK is not set
CONFIG_PMAC_APM_EMU=m
CONFIG_PMAC_MEDIABAY=y
CONFIG_PMAC_BACKLIGHT=y
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
2021-10-02 23:06 [PR PATCH] [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc mahiuchun
@ 2021-10-02 23:09 ` ericonr
2021-10-02 23:23 ` [PR PATCH] [Updated] " mahiuchun
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-10-02 23:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/33275#issuecomment-932832081
Comment:
Please document it in the commit message, since you already have the explanation. And apply the commit only to 5.14 (and name it `linux5.14: ...`), since 5.13 is EOL and won't be built any more.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
2021-10-02 23:06 [PR PATCH] [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc mahiuchun
2021-10-02 23:09 ` ericonr
@ 2021-10-02 23:23 ` mahiuchun
2021-10-02 23:41 ` mahiuchun
2021-10-03 0:20 ` [PR PATCH] [Merged]: " q66
3 siblings, 0 replies; 5+ messages in thread
From: mahiuchun @ 2021-10-02 23:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]
There is an updated pull request by mahiuchun against master on the void-packages repository
https://github.com/mahiuchun/void-packages led
https://github.com/void-linux/void-packages/pull/33275
[ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
See https://github.com/void-ppc/void-packages/pull/48 for the reason of this change. It was applied to previous versions of Linux.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/33275.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-led-33275.patch --]
[-- Type: text/x-diff, Size: 918 bytes --]
From 21ad636b9877b59584b21484f713a34fb664d105 Mon Sep 17 00:00:00 2001
From: Hill Ma <maahiuzeon@gmail.com>
Date: Sat, 2 Oct 2021 16:03:42 -0700
Subject: [PATCH] linux5.14: unset CONFIG_ADB_PMU_LED_DISK for ppc.
Unsetting CONFIG_ADB_PMU_LED_DISK prevents bright flashing of LED on iBooks.
See https://github.com/void-ppc/void-packages/pull/48 for a longer explanation.
---
srcpkgs/linux5.14/files/ppc-dotconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/linux5.14/files/ppc-dotconfig b/srcpkgs/linux5.14/files/ppc-dotconfig
index c33f11d33f45..9b1396be86b7 100644
--- a/srcpkgs/linux5.14/files/ppc-dotconfig
+++ b/srcpkgs/linux5.14/files/ppc-dotconfig
@@ -2294,7 +2294,7 @@ CONFIG_ADB=y
CONFIG_ADB_CUDA=y
CONFIG_ADB_PMU=y
CONFIG_ADB_PMU_LED=y
-CONFIG_ADB_PMU_LED_DISK=y
+# CONFIG_ADB_PMU_LED_DISK is not set
CONFIG_PMAC_APM_EMU=m
CONFIG_PMAC_MEDIABAY=y
CONFIG_PMAC_BACKLIGHT=y
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
2021-10-02 23:06 [PR PATCH] [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc mahiuchun
2021-10-02 23:09 ` ericonr
2021-10-02 23:23 ` [PR PATCH] [Updated] " mahiuchun
@ 2021-10-02 23:41 ` mahiuchun
2021-10-03 0:20 ` [PR PATCH] [Merged]: " q66
3 siblings, 0 replies; 5+ messages in thread
From: mahiuchun @ 2021-10-02 23:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 147 bytes --]
New comment by mahiuchun on void-packages repository
https://github.com/void-linux/void-packages/pull/33275#issuecomment-932834581
Comment:
done
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
2021-10-02 23:06 [PR PATCH] [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc mahiuchun
` (2 preceding siblings ...)
2021-10-02 23:41 ` mahiuchun
@ 2021-10-03 0:20 ` q66
3 siblings, 0 replies; 5+ messages in thread
From: q66 @ 2021-10-03 0:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]
There's a merged pull request on the void-packages repository
[ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc.
https://github.com/void-linux/void-packages/pull/33275
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [X] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
See https://github.com/void-ppc/void-packages/pull/48 for the reason of this change. It was applied to previous versions of Linux.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-03 0:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-02 23:06 [PR PATCH] [ci skip] linux: unset CONFIG_ADB_PMU_LED_DISK for ppc mahiuchun
2021-10-02 23:09 ` ericonr
2021-10-02 23:23 ` [PR PATCH] [Updated] " mahiuchun
2021-10-02 23:41 ` mahiuchun
2021-10-03 0:20 ` [PR PATCH] [Merged]: " q66
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).