Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] anki: fix use of deprecated method removed in python 3.9
@ 2021-10-03 11:01 Bikutoso
  2021-10-03 11:06 ` paper42
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Bikutoso @ 2021-10-03 11:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

There is a new pull request by Bikutoso against master on the void-packages repository

https://github.com/Bikutoso/void-packages anki-fix-unescape
https://github.com/void-linux/void-packages/pull/33287

anki: fix use of deprecated method removed in python 3.9
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33287.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-anki-fix-unescape-33287.patch --]
[-- Type: text/x-diff, Size: 997 bytes --]

From 0c44600a3a0e6a747360262309114cc42d4a1544 Mon Sep 17 00:00:00 2001
From: Bikutoso <10584311+Bikutoso@users.noreply.github.com>
Date: Sun, 3 Oct 2021 12:22:06 +0200
Subject: [PATCH] anki: fix use of deprecated method removed in python 3.9

---
 srcpkgs/anki/patches/fix_unescape.patch | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 srcpkgs/anki/patches/fix_unescape.patch

diff --git a/srcpkgs/anki/patches/fix_unescape.patch b/srcpkgs/anki/patches/fix_unescape.patch
new file mode 100644
index 000000000000..f7024bc7bf15
--- /dev/null
+++ b/srcpkgs/anki/patches/fix_unescape.patch
@@ -0,0 +1,11 @@
+--- a/aqt/reviewer.py
++++ b/aqt/reviewer.py
+@@ -359,7 +359,7 @@
+         cor = stripHTML(cor)
+         # ensure we don't chomp multiple whitespace
+         cor = cor.replace(" ", "&nbsp;")
+-        cor = parser.unescape(cor)
++        cor = html.unescape(cor)
+         cor = cor.replace("\xa0", " ")
+         cor = cor.strip()
+         given = self.typedAnswer

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: anki: fix use of deprecated method removed in python 3.9
  2021-10-03 11:01 [PR PATCH] anki: fix use of deprecated method removed in python 3.9 Bikutoso
@ 2021-10-03 11:06 ` paper42
  2021-10-03 11:20 ` [PR PATCH] [Updated] " Bikutoso
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-10-03 11:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33287#issuecomment-932920134

Comment:
@Bikutoso please also increase the revision in the package template

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] anki: fix use of deprecated method removed in python 3.9
  2021-10-03 11:01 [PR PATCH] anki: fix use of deprecated method removed in python 3.9 Bikutoso
  2021-10-03 11:06 ` paper42
@ 2021-10-03 11:20 ` Bikutoso
  2021-10-08 13:39 ` ahesford
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Bikutoso @ 2021-10-03 11:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

There is an updated pull request by Bikutoso against master on the void-packages repository

https://github.com/Bikutoso/void-packages anki-fix-unescape
https://github.com/void-linux/void-packages/pull/33287

anki: fix use of deprecated method removed in python 3.9
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33287.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-anki-fix-unescape-33287.patch --]
[-- Type: text/x-diff, Size: 1477 bytes --]

From cc869287d2c09823fb53036389c62f46bb909eba Mon Sep 17 00:00:00 2001
From: Bikutoso <10584311+Bikutoso@users.noreply.github.com>
Date: Sun, 3 Oct 2021 12:22:06 +0200
Subject: [PATCH] anki: fix use of deprecated method removed in python 3.9

---
 srcpkgs/anki/patches/fix_unescape.patch | 11 +++++++++++
 srcpkgs/anki/template                   |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/anki/patches/fix_unescape.patch

diff --git a/srcpkgs/anki/patches/fix_unescape.patch b/srcpkgs/anki/patches/fix_unescape.patch
new file mode 100644
index 000000000000..f7024bc7bf15
--- /dev/null
+++ b/srcpkgs/anki/patches/fix_unescape.patch
@@ -0,0 +1,11 @@
+--- a/aqt/reviewer.py
++++ b/aqt/reviewer.py
+@@ -359,7 +359,7 @@
+         cor = stripHTML(cor)
+         # ensure we don't chomp multiple whitespace
+         cor = cor.replace(" ", "&nbsp;")
+-        cor = parser.unescape(cor)
++        cor = html.unescape(cor)
+         cor = cor.replace("\xa0", " ")
+         cor = cor.strip()
+         given = self.typedAnswer
diff --git a/srcpkgs/anki/template b/srcpkgs/anki/template
index 55976fbd26eb..f2a476844717 100644
--- a/srcpkgs/anki/template
+++ b/srcpkgs/anki/template
@@ -1,7 +1,7 @@
 # Template file for 'anki'
 pkgname=anki
 version=2.1.15
-revision=4
+revision=5
 build_style=gnu-makefile
 depends="python3-PyQt5-webengine python3-requests python3-SQLAlchemy
  python3-PyAudio python3-mpv python3-Markdown python3-send2trash

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: anki: fix use of deprecated method removed in python 3.9
  2021-10-03 11:01 [PR PATCH] anki: fix use of deprecated method removed in python 3.9 Bikutoso
  2021-10-03 11:06 ` paper42
  2021-10-03 11:20 ` [PR PATCH] [Updated] " Bikutoso
@ 2021-10-08 13:39 ` ahesford
  2021-10-09 12:08 ` [PR PATCH] [Closed]: " ahesford
  2021-10-09 14:38 ` paper42
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2021-10-08 13:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/33287#issuecomment-938651149

Comment:
Thanks, I'll pull this into the pending py3.10 update

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: anki: fix use of deprecated method removed in python 3.9
  2021-10-03 11:01 [PR PATCH] anki: fix use of deprecated method removed in python 3.9 Bikutoso
                   ` (2 preceding siblings ...)
  2021-10-08 13:39 ` ahesford
@ 2021-10-09 12:08 ` ahesford
  2021-10-09 14:38 ` paper42
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2021-10-09 12:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]

There's a closed pull request on the void-packages repository

anki: fix use of deprecated method removed in python 3.9
https://github.com/void-linux/void-packages/pull/33287

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: anki: fix use of deprecated method removed in python 3.9
  2021-10-03 11:01 [PR PATCH] anki: fix use of deprecated method removed in python 3.9 Bikutoso
                   ` (3 preceding siblings ...)
  2021-10-09 12:08 ` [PR PATCH] [Closed]: " ahesford
@ 2021-10-09 14:38 ` paper42
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-10-09 14:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33287#issuecomment-939307437

Comment:
This PR was merged as a part of #33097, so github marked this as closed. I labeled this PR with hacktoberfest-accepted to make it count for hacktoberfest.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-09 14:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-03 11:01 [PR PATCH] anki: fix use of deprecated method removed in python 3.9 Bikutoso
2021-10-03 11:06 ` paper42
2021-10-03 11:20 ` [PR PATCH] [Updated] " Bikutoso
2021-10-08 13:39 ` ahesford
2021-10-09 12:08 ` [PR PATCH] [Closed]: " ahesford
2021-10-09 14:38 ` paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).