From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Manual.md: require justification for make_check
Date: Fri, 15 Oct 2021 20:05:04 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33574@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
There is a new pull request by Chocimier against master on the void-packages repository
https://github.com/Chocimier/void-packages-org explain_make_check
https://github.com/void-linux/void-packages/pull/33574
Manual.md: require justification for make_check
Helps to decide if tests can be reenabled.
xlint can check that with https://github.com/Chocimier/xtools/commit/2c9348ee837703994d0f367a4bb478e6b08a519f
Alternatively, we could split make_check into per-current-value variables set to freeform text, then ban `=yes|on|1|true` on make_check_*, nocross, lib32disabled etc.
A patch file from https://github.com/void-linux/void-packages/pull/33574.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-explain_make_check-33574.patch --]
[-- Type: text/x-diff, Size: 935 bytes --]
From 406040f74c0ffdf384ff61fdbb170398a04231eb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Fri, 15 Oct 2021 19:47:27 +0200
Subject: [PATCH] Manual.md: require justification for make_check
---
Manual.md | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Manual.md b/Manual.md
index db605c52135f..99c301f417eb 100644
--- a/Manual.md
+++ b/Manual.md
@@ -605,8 +605,7 @@ patches to the package sources during `do_patch()`. Patches are stored in
and `XBPS_MAKEJOBS` has no effect.
- `make_check` Sets the cases in which the `check` phase is run.
-This option should usually be accompanied by a comment explaining why it was set, especially when
-set to `no`.
+This option need to be accompanied by a comment explaining why tests do fail.
Allowed values:
- `yes` (the default) to run if `XBPS_CHECK_PKGS` is set.
- `extended` to run if `XBPS_CHECK_PKGS` is `full`.
next reply other threads:[~2021-10-15 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 18:05 Chocimier [this message]
2021-10-15 19:44 ` [PR REVIEW] " paper42
2021-10-25 17:26 ` [PR PATCH] [Updated] " Chocimier
2021-10-25 17:27 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33574@inbox.vuxu.org \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).