Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] hexchat-python3: missing dependency & files
@ 2021-10-19  0:02 0x5c
  2021-10-19  0:50 ` [PR PATCH] [Merged]: " ahesford
  0 siblings, 1 reply; 2+ messages in thread
From: 0x5c @ 2021-10-19  0:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1916 bytes --]

There is a new pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages hexchat-pythonfix
https://github.com/void-linux/void-packages/pull/33628

hexchat-python3: missing dependency & files
- Was missing a dependency on python3-cffi
- The associated python module had been left
  in the main package.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
I use hexchat (main package) daily, but found the bug in the plugin (subpackage) when attempting to try some python scripts. Now with the fix, the python plugin loads and behaves as expected.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33628.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hexchat-pythonfix-33628.patch --]
[-- Type: text/x-diff, Size: 1139 bytes --]

From 3dfcec877a3f77d3834d85fbb840d5492f7d5dca Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Mon, 18 Oct 2021 19:49:03 -0400
Subject: [PATCH] hexchat-python3: missing dependency & files

- Was missing a dependency on python3-cffi
- The associated python module had been left
  in the main package.
---
 srcpkgs/hexchat/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/hexchat/template b/srcpkgs/hexchat/template
index 9f11a75d3adc..97937999bb0d 100644
--- a/srcpkgs/hexchat/template
+++ b/srcpkgs/hexchat/template
@@ -1,7 +1,7 @@
 # Template file for 'hexchat'
 pkgname=hexchat
 version=2.16.0
-revision=2
+revision=3
 build_style=meson
 configure_args="-Ddbus=enabled -Dtls=enabled -Dwith-text=false
  -Dwith-perl=/usr/bin/perl -Dwith-python=python3
@@ -49,9 +49,10 @@ hexchat-perl_package() {
 hexchat-python3_package() {
 	lib32disabled=yes
 	short_desc+=" - Python3 plugin"
-	depends="${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}-${version}_${revision} python3-cffi"
 	pkg_install() {
 		vmove usr/lib/hexchat/plugins/python.so
+		vmove usr/lib/hexchat/python
 	}
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: hexchat-python3: missing dependency & files
  2021-10-19  0:02 [PR PATCH] hexchat-python3: missing dependency & files 0x5c
@ 2021-10-19  0:50 ` ahesford
  0 siblings, 0 replies; 2+ messages in thread
From: ahesford @ 2021-10-19  0:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]

There's a merged pull request on the void-packages repository

hexchat-python3: missing dependency & files
https://github.com/void-linux/void-packages/pull/33628

Description:
- Was missing a dependency on python3-cffi
- The associated python module had been left
  in the main package.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
I use hexchat (main package) daily, but found the bug in the plugin (subpackage) when attempting to try some python scripts. Now with the fix, the python plugin loads and behaves as expected.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-19  0:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19  0:02 [PR PATCH] hexchat-python3: missing dependency & files 0x5c
2021-10-19  0:50 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).