[PR PATCH] gpsd: fix pkglint warnings regarding libgpsdpacket

[PR PATCH] gpsd: fix pkglint warnings regarding libgpsdpacket

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]

There is a new pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages fix-libgpsdpacket
https://github.com/void-linux/void-packages/pull/33873

gpsd: fix pkglint warnings regarding libgpsdpacket
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33873.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-libgpsdpacket-33873.patch --]
[-- Type: text/x-diff, Size: 1273 bytes --]

From 9644e58d5f3af2b3cf699efb5d9c71706185cc29 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Wed, 3 Nov 2021 04:01:25 +0200
Subject: [PATCH] gpsd: fix pkglint warnings regarding libgpsdpacket

---
 common/shlibs         | 1 +
 srcpkgs/gpsd/template | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/common/shlibs b/common/shlibs
index 7e95fce39f7e..d838fe68e62c 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4035,3 +4035,4 @@ libstemmer.so.2 libstemmer-2.1.0_1
 libdecor-0.so.0 libdecor-0.1.0_1
 libavif.so.13 libavif-0.9.3_1
 libkdumpfile.so.8 libkdumpfile-0.4.0_1
+libgpsdpacket.so.29 gpsd-3.23.1_3
diff --git a/srcpkgs/gpsd/template b/srcpkgs/gpsd/template
index cf2bb26beefb..668e3885487f 100644
--- a/srcpkgs/gpsd/template
+++ b/srcpkgs/gpsd/template
@@ -1,7 +1,7 @@
 # Template file for 'gpsd'
 pkgname=gpsd
 version=3.23.1
-revision=2
+revision=3
 build_style=scons
 make_build_args="dbus_export=0 gpsd_user=gpsd gpsd_group=gpsd sbindir=/usr/bin
  udevdir=/usr/lib/udev CC=${CC} qt_versioned=5"
@@ -105,6 +105,7 @@ gpsd-devel_package() {
 		vmove usr/include
 		vmove "usr/lib/pkgconfig/libgps*.pc"
 		vmove usr/lib/libgps.so
+		vmove usr/lib/libgpsdpacket.so
 		vmove "usr/share/man/man3/libgps*"
 	}
 }

Re: [PR REVIEW] gpsd: fix pkglint warnings regarding libgpsdpacket

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33873#discussion_r742931296

Comment:
This warning is harmless, so please leave it out for now. It's necessary only if some other package depends on it.

Re: [PR REVIEW] gpsd: fix pkglint warnings regarding libgpsdpacket

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/33873#discussion_r742932406

Comment:
Alright. So should I close this or move the `.so` under `-devel` at least?

Re: [PR PATCH] [Updated] gpsd: fix pkglint warnings regarding libgpsdpacket

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

There is an updated pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages fix-libgpsdpacket
https://github.com/void-linux/void-packages/pull/33873

gpsd: fix pkglint warnings regarding libgpsdpacket
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33873.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-libgpsdpacket-33873.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]

From c766e6968879b6fa6721d580e2dc307fdb1657df Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Wed, 3 Nov 2021 04:01:25 +0200
Subject: [PATCH] gpsd: fix pkglint warnings regarding libgpsdpacket

---
 srcpkgs/gpsd/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gpsd/template b/srcpkgs/gpsd/template
index cf2bb26beefb..668e3885487f 100644
--- a/srcpkgs/gpsd/template
+++ b/srcpkgs/gpsd/template
@@ -1,7 +1,7 @@
 # Template file for 'gpsd'
 pkgname=gpsd
 version=3.23.1
-revision=2
+revision=3
 build_style=scons
 make_build_args="dbus_export=0 gpsd_user=gpsd gpsd_group=gpsd sbindir=/usr/bin
  udevdir=/usr/lib/udev CC=${CC} qt_versioned=5"
@@ -105,6 +105,7 @@ gpsd-devel_package() {
 		vmove usr/include
 		vmove "usr/lib/pkgconfig/libgps*.pc"
 		vmove usr/lib/libgps.so
+		vmove usr/lib/libgpsdpacket.so
 		vmove "usr/share/man/man3/libgps*"
 	}
 }

Re: [PR PATCH] [Updated] gpsd: fix pkglint warnings regarding libgpsdpacket

[JamiKettunen]

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

There is an updated pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages fix-libgpsdpacket
https://github.com/void-linux/void-packages/pull/33873

gpsd: fix pkglint warnings regarding libgpsdpacket
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33873.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-libgpsdpacket-33873.patch --]
[-- Type: text/x-diff, Size: 924 bytes --]

From faa0dd6409ac7be35ff25a2dddb7ea3f93a12306 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Wed, 3 Nov 2021 04:01:25 +0200
Subject: [PATCH] gpsd: move libgpsdpacket.so under -devel subpackage

---
 srcpkgs/gpsd/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gpsd/template b/srcpkgs/gpsd/template
index cf2bb26beefb..668e3885487f 100644
--- a/srcpkgs/gpsd/template
+++ b/srcpkgs/gpsd/template
@@ -1,7 +1,7 @@
 # Template file for 'gpsd'
 pkgname=gpsd
 version=3.23.1
-revision=2
+revision=3
 build_style=scons
 make_build_args="dbus_export=0 gpsd_user=gpsd gpsd_group=gpsd sbindir=/usr/bin
  udevdir=/usr/lib/udev CC=${CC} qt_versioned=5"
@@ -105,6 +105,7 @@ gpsd-devel_package() {
 		vmove usr/include
 		vmove "usr/lib/pkgconfig/libgps*.pc"
 		vmove usr/lib/libgps.so
+		vmove usr/lib/libgpsdpacket.so
 		vmove "usr/share/man/man3/libgps*"
 	}
 }

Re: [PR REVIEW] gpsd: move libgpsdpacket.so under -devel subpackage

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33873#discussion_r742954342

Comment:
Moving the .so is fine :)

If you want, `vmove "usr/lib/*.so"` should also work.

Re: [PR REVIEW] gpsd: move libgpsdpacket.so under -devel subpackage

[abenson]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/33873#discussion_r744017772

Comment:
Could these be combined to be just `vmove "usr/lib/*.so"`?

Re: [PR REVIEW] gpsd: move libgpsdpacket.so under -devel subpackage

[abenson]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/33873#discussion_r744018076

Comment:
This whole section could be changed to

    vmove usr/include
    vmove usr/lib/pkgconfig
    vmove "usr/lib/*.so"
    vmove usr/share/man/man3

Re: [PR REVIEW] gpsd: move libgpsdpacket.so under -devel subpackage

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/33873#discussion_r744019479

Comment:
in such scenarios, implicit subpackages (like alpine does) seem appealing

Re: [PR REVIEW] gpsd: move libgpsdpacket.so under -devel subpackage

[abenson]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/33873#discussion_r744160472

Comment:
Ah, I didn't think about the other `-devel` package.  This is fine as is

Re: [PR PATCH] [Merged]: gpsd: move libgpsdpacket.so under -devel subpackage

[abenson]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

There's a merged pull request on the void-packages repository

gpsd: move libgpsdpacket.so under -devel subpackage
https://github.com/void-linux/void-packages/pull/33873

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->