[PR PATCH] gnome-tweaks: fix libhandy dependency

[PR PATCH] gnome-tweaks: fix libhandy dependency

[Roger-Roger-debug]

[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]

There is a new pull request by Roger-Roger-debug against master on the void-packages repository

https://github.com/Roger-Roger-debug/void-packages gnome-tweaks-fix
https://github.com/void-linux/void-packages/pull/33903

gnome-tweaks: fix libhandy dependency
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
The newest version requires libhandy >= 1.0

A patch file from https://github.com/void-linux/void-packages/pull/33903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-tweaks-fix-33903.patch --]
[-- Type: text/x-diff, Size: 960 bytes --]

From 54144a7147c183fd5cdc5a9a144df01b09af92e7 Mon Sep 17 00:00:00 2001
From: Roger Roger <me@rogerrogert.de>
Date: Thu, 4 Nov 2021 17:20:49 +0100
Subject: [PATCH] gnome-tweaks: fix libhandy dependency

---
 srcpkgs/gnome-tweaks/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnome-tweaks/template b/srcpkgs/gnome-tweaks/template
index 8f7a3eda15d2..ffacf386224e 100644
--- a/srcpkgs/gnome-tweaks/template
+++ b/srcpkgs/gnome-tweaks/template
@@ -1,10 +1,10 @@
 # Template file for 'gnome-tweaks'
 pkgname=gnome-tweaks
 version=40.0
-revision=2
+revision=3
 build_style=meson
 hostmakedepends="gettext"
-depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy"
+depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy1"
 short_desc="GNOME3 tool to customize advanced options"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later, CC0-1.0"

Re: [PR REVIEW] gnome-tweaks: fix libhandy dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33903#discussion_r743240642

Comment:
Let's also fix this:
```suggestion
 short_desc="GNOME tool to customize advanced options"
```

Re: gnome-tweaks: fix libhandy dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33903#issuecomment-961476652

Comment:
Could you add the email used in the commit to your github profile so gh can associate the commit with you?

Re: [PR PATCH] [Updated] gnome-tweaks: fix libhandy dependency

[Roger-Roger-debug]

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

There is an updated pull request by Roger-Roger-debug against master on the void-packages repository

https://github.com/Roger-Roger-debug/void-packages gnome-tweaks-fix
https://github.com/void-linux/void-packages/pull/33903

gnome-tweaks: fix libhandy dependency
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
The newest version requires libhandy >= 1.0

A patch file from https://github.com/void-linux/void-packages/pull/33903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-tweaks-fix-33903.patch --]
[-- Type: text/x-diff, Size: 1900 bytes --]

From 54144a7147c183fd5cdc5a9a144df01b09af92e7 Mon Sep 17 00:00:00 2001
From: Roger Roger <me@rogerrogert.de>
Date: Thu, 4 Nov 2021 17:20:49 +0100
Subject: [PATCH 1/2] gnome-tweaks: fix libhandy dependency

---
 srcpkgs/gnome-tweaks/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnome-tweaks/template b/srcpkgs/gnome-tweaks/template
index 8f7a3eda15d2..ffacf386224e 100644
--- a/srcpkgs/gnome-tweaks/template
+++ b/srcpkgs/gnome-tweaks/template
@@ -1,10 +1,10 @@
 # Template file for 'gnome-tweaks'
 pkgname=gnome-tweaks
 version=40.0
-revision=2
+revision=3
 build_style=meson
 hostmakedepends="gettext"
-depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy"
+depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy1"
 short_desc="GNOME3 tool to customize advanced options"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later, CC0-1.0"

From 21552b912c3592ca867328bbc2d0dab558ba1990 Mon Sep 17 00:00:00 2001
From: Roger Roger <me@rogerrogert.de>
Date: Fri, 5 Nov 2021 11:43:57 +0100
Subject: [PATCH 2/2] gnome-tweaks: Change description

Co-authored-by: Michal Vasilek <michal@vasilek.cz>
---
 srcpkgs/gnome-tweaks/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gnome-tweaks/template b/srcpkgs/gnome-tweaks/template
index ffacf386224e..3aa31defe696 100644
--- a/srcpkgs/gnome-tweaks/template
+++ b/srcpkgs/gnome-tweaks/template
@@ -5,7 +5,7 @@ revision=3
 build_style=meson
 hostmakedepends="gettext"
 depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy1"
-short_desc="GNOME3 tool to customize advanced options"
+ short_desc="GNOME tool to customize advanced options"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later, CC0-1.0"
 homepage="https://wiki.gnome.org/Apps/Tweaks"

Re: gnome-tweaks: fix libhandy dependency

[Roger-Roger-debug]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New comment by Roger-Roger-debug on void-packages repository

https://github.com/void-linux/void-packages/pull/33903#issuecomment-961797225

Comment:
> Could you add the email used in the commit to your github profile so gh can associate the commit with you?

Is this okay or does it have to be displayed as the public email?

Re: [PR PATCH] [Updated] gnome-tweaks: fix libhandy dependency

[Roger-Roger-debug]

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

There is an updated pull request by Roger-Roger-debug against master on the void-packages repository

https://github.com/Roger-Roger-debug/void-packages gnome-tweaks-fix
https://github.com/void-linux/void-packages/pull/33903

gnome-tweaks: fix libhandy dependency
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
The newest version requires libhandy >= 1.0

A patch file from https://github.com/void-linux/void-packages/pull/33903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-tweaks-fix-33903.patch --]
[-- Type: text/x-diff, Size: 2787 bytes --]

From 54144a7147c183fd5cdc5a9a144df01b09af92e7 Mon Sep 17 00:00:00 2001
From: Roger Roger <me@rogerrogert.de>
Date: Thu, 4 Nov 2021 17:20:49 +0100
Subject: [PATCH 1/3] gnome-tweaks: fix libhandy dependency

---
 srcpkgs/gnome-tweaks/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnome-tweaks/template b/srcpkgs/gnome-tweaks/template
index 8f7a3eda15d2..ffacf386224e 100644
--- a/srcpkgs/gnome-tweaks/template
+++ b/srcpkgs/gnome-tweaks/template
@@ -1,10 +1,10 @@
 # Template file for 'gnome-tweaks'
 pkgname=gnome-tweaks
 version=40.0
-revision=2
+revision=3
 build_style=meson
 hostmakedepends="gettext"
-depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy"
+depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy1"
 short_desc="GNOME3 tool to customize advanced options"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later, CC0-1.0"

From 21552b912c3592ca867328bbc2d0dab558ba1990 Mon Sep 17 00:00:00 2001
From: Roger Roger <me@rogerrogert.de>
Date: Fri, 5 Nov 2021 11:43:57 +0100
Subject: [PATCH 2/3] gnome-tweaks: Change description

Co-authored-by: Michal Vasilek <michal@vasilek.cz>
---
 srcpkgs/gnome-tweaks/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gnome-tweaks/template b/srcpkgs/gnome-tweaks/template
index ffacf386224e..3aa31defe696 100644
--- a/srcpkgs/gnome-tweaks/template
+++ b/srcpkgs/gnome-tweaks/template
@@ -5,7 +5,7 @@ revision=3
 build_style=meson
 hostmakedepends="gettext"
 depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy1"
-short_desc="GNOME3 tool to customize advanced options"
+ short_desc="GNOME tool to customize advanced options"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later, CC0-1.0"
 homepage="https://wiki.gnome.org/Apps/Tweaks"

From 4a958467c6bfba7d13cc5094cc0f9471b75a19e0 Mon Sep 17 00:00:00 2001
From: Roger Roger <me@rogerrogert.de>
Date: Fri, 5 Nov 2021 12:36:34 +0100
Subject: [PATCH 3/3] gnome-tweaks: fix short_desc indent

---
 srcpkgs/gnome-tweaks/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gnome-tweaks/template b/srcpkgs/gnome-tweaks/template
index 3aa31defe696..e2ef4e83d274 100644
--- a/srcpkgs/gnome-tweaks/template
+++ b/srcpkgs/gnome-tweaks/template
@@ -5,7 +5,7 @@ revision=3
 build_style=meson
 hostmakedepends="gettext"
 depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy1"
- short_desc="GNOME tool to customize advanced options"
+short_desc="GNOME tool to customize advanced options"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later, CC0-1.0"
 homepage="https://wiki.gnome.org/Apps/Tweaks"

Re: gnome-tweaks: fix libhandy dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33903#issuecomment-961825008

Comment:
> > Could you add the email used in the commit to your github profile so gh can associate the commit with you?
> 
> Is this okay or does it have to be displayed as the public email?

It's fine like this, could you also please squash the commits into one?

Re: [PR PATCH] [Updated] gnome-tweaks: fix libhandy dependency

[Roger-Roger-debug]

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

There is an updated pull request by Roger-Roger-debug against master on the void-packages repository

https://github.com/Roger-Roger-debug/void-packages gnome-tweaks-fix
https://github.com/void-linux/void-packages/pull/33903

gnome-tweaks: fix libhandy dependency
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
The newest version requires libhandy >= 1.0

A patch file from https://github.com/void-linux/void-packages/pull/33903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnome-tweaks-fix-33903.patch --]
[-- Type: text/x-diff, Size: 1064 bytes --]

From 1fd346ead88203b73eb0cd9809d853275aa6d79c Mon Sep 17 00:00:00 2001
From: Roger Roger <me@rogerrogert.de>
Date: Thu, 4 Nov 2021 17:20:49 +0100
Subject: [PATCH] gnome-tweaks: fix libhandy dependency

---
 srcpkgs/gnome-tweaks/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gnome-tweaks/template b/srcpkgs/gnome-tweaks/template
index 8f7a3eda15d2..e2ef4e83d274 100644
--- a/srcpkgs/gnome-tweaks/template
+++ b/srcpkgs/gnome-tweaks/template
@@ -1,11 +1,11 @@
 # Template file for 'gnome-tweaks'
 pkgname=gnome-tweaks
 version=40.0
-revision=2
+revision=3
 build_style=meson
 hostmakedepends="gettext"
-depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy"
-short_desc="GNOME3 tool to customize advanced options"
+depends="gtk+3 dconf gnome-settings-daemon mutter libnotify python3-gobject libhandy1"
+short_desc="GNOME tool to customize advanced options"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later, CC0-1.0"
 homepage="https://wiki.gnome.org/Apps/Tweaks"

Re: gnome-tweaks: fix libhandy dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33903#issuecomment-962175482

Comment:
thank you for catching this

Re: [PR PATCH] [Merged]: gnome-tweaks: fix libhandy dependency

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

There's a merged pull request on the void-packages repository

gnome-tweaks: fix libhandy dependency
https://github.com/void-linux/void-packages/pull/33903

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
The newest version requires libhandy >= 1.0