From: ScrelliCopter <ScrelliCopter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] qemu: fix typo resulting in broken build when disabling Jack
Date: Thu, 04 Nov 2021 19:50:30 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33906@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
There is a new pull request by ScrelliCopter against master on the void-packages repository
https://github.com/ScrelliCopter/void-packages qemu-jack
https://github.com/void-linux/void-packages/pull/33906
qemu: fix typo resulting in broken build when disabling Jack
Oops 🥴
addresses part of #33728
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/33906.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qemu-jack-33906.patch --]
[-- Type: text/x-diff, Size: 651 bytes --]
From e99781e6c1510816751e3a6b98061bfa1ab4c5c2 Mon Sep 17 00:00:00 2001
From: a dinosaur <nick@a-dinosaur.com>
Date: Fri, 5 Nov 2021 05:45:22 +1100
Subject: [PATCH] qemu: fix typo resulting in broken build when disabling Jack
---
srcpkgs/qemu/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index cbb6bd8b89d2..cb21578cfed2 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -69,7 +69,7 @@ do_configure() {
want_sdl="--enable-sdl"
audio_sdl=",sdl"
fi
- if [ $"build_option_jack" ]; then
+ if [ "$build_option_jack" ]; then
audio_jack=",jack"
fi
next reply other threads:[~2021-11-04 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:50 ScrelliCopter [this message]
2021-11-04 19:03 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33906@inbox.vuxu.org \
--to=screllicopter@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).