Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] qemu: fix typo resulting in broken build when disabling Jack
@ 2021-11-04 18:50 ScrelliCopter
  2021-11-04 19:03 ` [PR PATCH] [Merged]: " leahneukirchen
  0 siblings, 1 reply; 2+ messages in thread
From: ScrelliCopter @ 2021-11-04 18:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

There is a new pull request by ScrelliCopter against master on the void-packages repository

https://github.com/ScrelliCopter/void-packages qemu-jack
https://github.com/void-linux/void-packages/pull/33906

qemu: fix typo resulting in broken build when disabling Jack
Oops 🥴
addresses part of #33728

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR


A patch file from https://github.com/void-linux/void-packages/pull/33906.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qemu-jack-33906.patch --]
[-- Type: text/x-diff, Size: 651 bytes --]

From e99781e6c1510816751e3a6b98061bfa1ab4c5c2 Mon Sep 17 00:00:00 2001
From: a dinosaur <nick@a-dinosaur.com>
Date: Fri, 5 Nov 2021 05:45:22 +1100
Subject: [PATCH] qemu: fix typo resulting in broken build when disabling Jack

---
 srcpkgs/qemu/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index cbb6bd8b89d2..cb21578cfed2 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -69,7 +69,7 @@ do_configure() {
 		want_sdl="--enable-sdl"
 		audio_sdl=",sdl"
 	fi
-	if [ $"build_option_jack" ]; then
+	if [ "$build_option_jack" ]; then
 		audio_jack=",jack"
 	fi
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: qemu: fix typo resulting in broken build when disabling Jack
  2021-11-04 18:50 [PR PATCH] qemu: fix typo resulting in broken build when disabling Jack ScrelliCopter
@ 2021-11-04 19:03 ` leahneukirchen
  0 siblings, 0 replies; 2+ messages in thread
From: leahneukirchen @ 2021-11-04 19:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

There's a merged pull request on the void-packages repository

qemu: fix typo resulting in broken build when disabling Jack
https://github.com/void-linux/void-packages/pull/33906

Description:
Oops 🥴
addresses part of #33728

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-04 19:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 18:50 [PR PATCH] qemu: fix typo resulting in broken build when disabling Jack ScrelliCopter
2021-11-04 19:03 ` [PR PATCH] [Merged]: " leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).