[PR PATCH] fzf: update installation path for completions and key-bindings

[PR PATCH] fzf: update installation path for completions and key-bindings

[kkga]

[-- Attachment #1: Type: text/plain, Size: 1853 bytes --]

There is a new pull request by kkga against master on the void-packages repository

https://github.com/kkga/void-packages update-fzf
https://github.com/void-linux/void-packages/pull/33947

fzf: update installation path for completions and key-bindings
This changes the installation additional files from `/usr/share/doc/fzf` to `usr/share/fzf`.

I'm not sure why they were originally installed in the `doc` folder, since these are not documentation files,
but if there is a reason, please feel free to close.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33947.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-fzf-33947.patch --]
[-- Type: text/x-diff, Size: 1414 bytes --]

From 2d7c930b09e9bcb846ae5b4712037837fb597abf Mon Sep 17 00:00:00 2001
From: Gadzhi Kharkharov <me@kkga.me>
Date: Mon, 8 Nov 2021 12:06:15 +0300
Subject: [PATCH] fzf: update installation path for completions and
 key-bindings

---
 srcpkgs/fzf/template | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/fzf/template b/srcpkgs/fzf/template
index c4c869c3e4c9..6f6afd6686ff 100644
--- a/srcpkgs/fzf/template
+++ b/srcpkgs/fzf/template
@@ -1,7 +1,7 @@
 # Template file for 'fzf'
 pkgname=fzf
 version=0.28.0
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/junegunn/fzf"
 hostmakedepends="git"
@@ -23,9 +23,10 @@ post_install() {
 	sed -i -e 's#source ~/\.fzf\.bash; ##' shell/key-bindings.bash
 	vinstall plugin/fzf.vim 644 usr/share/vim/vimfiles/plugin
 	vinstall plugin/fzf.vim 644 usr/share/nvim/runtime/plugin
-	vinstall shell/completion.bash 644 usr/share/doc/fzf
-	vinstall shell/completion.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.zsh 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.bash 644 usr/share/doc/fzf
-	vinstall shell/key-bindings.fish 644 usr/share/doc/fzf
+
+	vinstall shell/completion.bash 644 usr/share/fzf
+	vinstall shell/completion.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.zsh 644 usr/share/fzf
+	vinstall shell/key-bindings.bash 644 usr/share/fzf
+	vinstall shell/key-bindings.fish 644 usr/share/fzf
 }

Re: fzf: update installation path for completions and key-bindings

[kkga]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by kkga on void-packages repository

https://github.com/void-linux/void-packages/pull/33947#issuecomment-962949553

Comment:
cc @leahneukirchen 

Re: fzf: update installation path for completions and key-bindings

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/33947#issuecomment-963325733

Comment:
It would be even better if upstream shipped completion files suitable for proper installation at the right locations, but so be it.

Re: [PR PATCH] [Merged]: fzf: update installation path for completions and key-bindings

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

There's a merged pull request on the void-packages repository

fzf: update installation path for completions and key-bindings
https://github.com/void-linux/void-packages/pull/33947

Description:
This changes the installation path of additional files from `/usr/share/doc/fzf` to `usr/share/fzf`.

I'm not sure why they were originally installed in the `doc` folder, since these are not documentation files,
but if there is a reason, please feel free to close.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->