Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pcc: add missing dependencies
@ 2021-11-10 12:53 loreb
  2021-11-11  0:47 ` [PR PATCH] [Closed]: " sgn
  0 siblings, 1 reply; 2+ messages in thread
From: loreb @ 2021-11-10 12:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]

There is a new pull request by loreb against master on the void-packages repository

https://github.com/loreb/void-packages pcc-needs-libc-devel
https://github.com/void-linux/void-packages/pull/34009

pcc: add missing dependencies
Same as https://github.com/void-linux/void-packages/issues/30630

Tested on a glibc vm - on a fresh void install, it can't find headers & crt.o

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34009.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcc-needs-libc-devel-34009.patch --]
[-- Type: text/x-diff, Size: 972 bytes --]

From 62d36fb3ac019c4baffe9b8b9410d704f0c58259 Mon Sep 17 00:00:00 2001
From: Lorenzo Beretta <vc.net.loreb@gmail.com>
Date: Wed, 10 Nov 2021 13:46:45 +0100
Subject: [PATCH] pcc: add missing dependencies

Same as https://github.com/void-linux/void-packages/issues/30630
---
 srcpkgs/pcc/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/pcc/template b/srcpkgs/pcc/template
index 8d6b4748b8d5..2a1c28ff1171 100644
--- a/srcpkgs/pcc/template
+++ b/srcpkgs/pcc/template
@@ -1,7 +1,7 @@
 # Template file for 'pcc'
 pkgname=pcc
 version=1.1.0.20190420
-revision=3
+revision=4
 _distver="${version%.*}"
 _snapshot="${version##*.}"
 archs="i686* x86_64*"
@@ -21,6 +21,10 @@ checksum="a114dfca04b8b0559ea5d67b87d2d0fcb2bae2b4d9b9ba16ebc27960b921c812
 nocross=yes
 
 CFLAGS="-fcommon"
+case "$XBPS_TARGET_MACHINE" in
+	*-musl)	 depends+=" musl-devel";;
+	*) 	 depends+=" glibc-devel";;
+esac
 
 post_extract() {
 	mv pcc-${_distver}.BETA pcc

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Closed]: pcc: add missing dependencies
  2021-11-10 12:53 [PR PATCH] pcc: add missing dependencies loreb
@ 2021-11-11  0:47 ` sgn
  0 siblings, 0 replies; 2+ messages in thread
From: sgn @ 2021-11-11  0:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

There's a closed pull request on the void-packages repository

pcc: add missing dependencies
https://github.com/void-linux/void-packages/pull/34009

Description:
Same as https://github.com/void-linux/void-packages/issues/30630

Tested on a glibc vm - on a fresh void install, it can't find headers & crt.o

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-11  0:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 12:53 [PR PATCH] pcc: add missing dependencies loreb
2021-11-11  0:47 ` [PR PATCH] [Closed]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).