Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] minised: update to 1.16
@ 2021-11-12 19:01 mtboehlke
  2021-11-12 22:50 ` [PR REVIEW] " ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: mtboehlke @ 2021-11-12 19:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]

There is a new pull request by mtboehlke against master on the void-packages repository

https://github.com/mtboehlke/void-packages minised
https://github.com/void-linux/void-packages/pull/34048

minised: update to 1.16
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34048.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-minised-34048.patch --]
[-- Type: text/x-diff, Size: 1156 bytes --]

From 5ff554940714e4d9877657e79bb19c9ec5cc17aa Mon Sep 17 00:00:00 2001
From: Mat Boehlke <mtboehlke@gmail.com>
Date: Fri, 12 Nov 2021 08:51:41 -0600
Subject: [PATCH] minised: update to 1.16

---
 srcpkgs/minised/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/minised/template b/srcpkgs/minised/template
index b4f212a287d7..f431a712662e 100644
--- a/srcpkgs/minised/template
+++ b/srcpkgs/minised/template
@@ -1,14 +1,14 @@
 # Template file for 'minised'
 pkgname=minised
-version=1.15
-revision=2
+version=1.16
+revision=1
 build_style=gnu-makefile
-short_desc="A smaller, cheaper, faster sed implementation"
+short_desc="Smaller, cheaper, faster sed implementation"
 maintainer="Richard Taityr <dicktyr@yahoo.co.uk>"
 license="BSD-3-Clause"
 homepage="http://exactcode.com/opensource/minised/"
 distfiles="http://dl.exactcode.de/oss/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=ada36a55b71d1f2eb61f2f3b95f112708ce51e69f601bf5ea5d7acb7c21b3481
+checksum=46e072d5d45c9fd3d5b268523501bbea0ad016232b2d3f366a7aad0b1e7b3f71
 
 # arguably not an alternative as minised lacks common extensions
 #alternatives="

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] minised: update to 1.16
  2021-11-12 19:01 [PR PATCH] minised: update to 1.16 mtboehlke
@ 2021-11-12 22:50 ` ericonr
  2021-11-13  2:49 ` [PR PATCH] [Updated] " mtboehlke
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-11-12 22:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34048#discussion_r748628265

Comment:
At least homepage works with https, distfiles probably do as well.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] minised: update to 1.16
  2021-11-12 19:01 [PR PATCH] minised: update to 1.16 mtboehlke
  2021-11-12 22:50 ` [PR REVIEW] " ericonr
@ 2021-11-13  2:49 ` mtboehlke
  2021-11-13  2:52 ` [PR REVIEW] " mtboehlke
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: mtboehlke @ 2021-11-13  2:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

There is an updated pull request by mtboehlke against master on the void-packages repository

https://github.com/mtboehlke/void-packages minised
https://github.com/void-linux/void-packages/pull/34048

minised: update to 1.16
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->
Short description changed to comply with linting

A patch file from https://github.com/void-linux/void-packages/pull/34048.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-minised-34048.patch --]
[-- Type: text/x-diff, Size: 1296 bytes --]

From abcae7fa933952f13d5786aadbea96961371e3a6 Mon Sep 17 00:00:00 2001
From: Mat Boehlke <mtboehlke@gmail.com>
Date: Fri, 12 Nov 2021 08:51:41 -0600
Subject: [PATCH] minised: update to 1.16

---
 srcpkgs/minised/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/minised/template b/srcpkgs/minised/template
index b4f212a287d7..93c68498466f 100644
--- a/srcpkgs/minised/template
+++ b/srcpkgs/minised/template
@@ -1,14 +1,14 @@
 # Template file for 'minised'
 pkgname=minised
-version=1.15
-revision=2
+version=1.16
+revision=1
 build_style=gnu-makefile
-short_desc="A smaller, cheaper, faster sed implementation"
+short_desc="Smaller, cheaper, faster sed implementation"
 maintainer="Richard Taityr <dicktyr@yahoo.co.uk>"
 license="BSD-3-Clause"
-homepage="http://exactcode.com/opensource/minised/"
-distfiles="http://dl.exactcode.de/oss/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum=ada36a55b71d1f2eb61f2f3b95f112708ce51e69f601bf5ea5d7acb7c21b3481
+homepage="https://exactcode.com/opensource/minised/"
+distfiles="https://dl.exactcode.de/oss/${pkgname}/${pkgname}-${version}.tar.gz"
+checksum=46e072d5d45c9fd3d5b268523501bbea0ad016232b2d3f366a7aad0b1e7b3f71
 
 # arguably not an alternative as minised lacks common extensions
 #alternatives="

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] minised: update to 1.16
  2021-11-12 19:01 [PR PATCH] minised: update to 1.16 mtboehlke
  2021-11-12 22:50 ` [PR REVIEW] " ericonr
  2021-11-13  2:49 ` [PR PATCH] [Updated] " mtboehlke
@ 2021-11-13  2:52 ` mtboehlke
  2021-11-13  2:56 ` mtboehlke
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: mtboehlke @ 2021-11-13  2:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by mtboehlke on void-packages repository

https://github.com/void-linux/void-packages/pull/34048#discussion_r748672156

Comment:
Yep, https worked just fine

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: minised: update to 1.16
  2021-11-12 19:01 [PR PATCH] minised: update to 1.16 mtboehlke
                   ` (2 preceding siblings ...)
  2021-11-13  2:52 ` [PR REVIEW] " mtboehlke
@ 2021-11-13  2:56 ` mtboehlke
  2021-11-13  3:00 ` mtboehlke
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: mtboehlke @ 2021-11-13  2:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

New comment by mtboehlke on void-packages repository

https://github.com/void-linux/void-packages/pull/34048#issuecomment-967767976

Comment:
One issue I found while building this outside of xbps-src is that the run script for the tests, as of this version, contains a bash-ism, but the shebang is still /bin/sh.  It will fail with dash as /bin/sh, but works in the chroot. I was planning on reporting upstream.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: minised: update to 1.16
  2021-11-12 19:01 [PR PATCH] minised: update to 1.16 mtboehlke
                   ` (3 preceding siblings ...)
  2021-11-13  2:56 ` mtboehlke
@ 2021-11-13  3:00 ` mtboehlke
  2021-11-13  3:01 ` ericonr
  2021-11-13  3:07 ` [PR PATCH] [Merged]: " ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: mtboehlke @ 2021-11-13  3:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

New comment by mtboehlke on void-packages repository

https://github.com/void-linux/void-packages/pull/34048#issuecomment-967767976

Comment:
One issue I found while building this outside of xbps-src is that the run script for the tests, as of this version, contains a bash-ism, but the shebang is still /bin/sh.  It will fail with dash as /bin/sh, but works in the chroot.  Is this worth patching the run script so that it doesn't rely on bash being /bin/sh?  Either way, I will probably report it upstream.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: minised: update to 1.16
  2021-11-12 19:01 [PR PATCH] minised: update to 1.16 mtboehlke
                   ` (4 preceding siblings ...)
  2021-11-13  3:00 ` mtboehlke
@ 2021-11-13  3:01 ` ericonr
  2021-11-13  3:07 ` [PR PATCH] [Merged]: " ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-11-13  3:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34048#issuecomment-967768534

Comment:
No need to patch, shell inside xbps-src will always be bash. Reporting upstream sounds good tho!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: minised: update to 1.16
  2021-11-12 19:01 [PR PATCH] minised: update to 1.16 mtboehlke
                   ` (5 preceding siblings ...)
  2021-11-13  3:01 ` ericonr
@ 2021-11-13  3:07 ` ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-11-13  3:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

There's a merged pull request on the void-packages repository

minised: update to 1.16
https://github.com/void-linux/void-packages/pull/34048

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->
Short description changed to comply with linting

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-11-13  3:07 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 19:01 [PR PATCH] minised: update to 1.16 mtboehlke
2021-11-12 22:50 ` [PR REVIEW] " ericonr
2021-11-13  2:49 ` [PR PATCH] [Updated] " mtboehlke
2021-11-13  2:52 ` [PR REVIEW] " mtboehlke
2021-11-13  2:56 ` mtboehlke
2021-11-13  3:00 ` mtboehlke
2021-11-13  3:01 ` ericonr
2021-11-13  3:07 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).