[PR PATCH] common/environment/build-style: remove nostrip from go.sh

[PR PATCH] common/environment/build-style: remove nostrip from go.sh

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages go
https://github.com/void-linux/void-packages/pull/34065

common/environment/build-style: remove nostrip from go.sh
Hasn't been necessary in Go for a long time [1], so we should take
advantage of that. For an example of the advantages, the 'micro' editor
went from 15MB to 11MB on disk.

[1] https://honnef.co/posts/2016/10/go-and-strip/

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

@the-maldridge

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34065.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-34065.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]

From a89c9dfb97ba47722a9f6a771e8a95d659868215 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Sun, 14 Nov 2021 04:31:57 -0300
Subject: [PATCH] common/environment/build-style: remove nostrip from go.sh

Hasn't been necessary in Go for a long time [1], so we should take
advantage of that. For an example of the advantages, the 'micro' editor
went from 15MB to 11MB on disk.

[1] https://honnef.co/posts/2016/10/go-and-strip/
---
 common/environment/build-style/go.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/common/environment/build-style/go.sh b/common/environment/build-style/go.sh
index 6bdf6529a8c9..afa9082c927a 100644
--- a/common/environment/build-style/go.sh
+++ b/common/environment/build-style/go.sh
@@ -16,7 +16,6 @@ else
 		export GCCGO="${XBPS_CROSS_TRIPLET}-gccgo"
 	fi
 fi
-nostrip=yes
 
 case "$XBPS_TARGET_MACHINE" in
 	aarch64*) export GOARCH=arm64;;

Re: [PR PATCH] [Merged]: common/environment/build-style: remove nostrip from go.sh

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

There's a merged pull request on the void-packages repository

common/environment/build-style: remove nostrip from go.sh
https://github.com/void-linux/void-packages/pull/34065

Description:
Hasn't been necessary in Go for a long time [1], so we should take
advantage of that. For an example of the advantages, the 'micro' editor
went from 15MB to 11MB on disk.

[1] https://honnef.co/posts/2016/10/go-and-strip/

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

@the-maldridge

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->