Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Manual.md: clarify default build target
@ 2021-11-14 15:01 tornaria
  2021-11-14 18:37 ` [PR PATCH] [Merged]: " ericonr
  0 siblings, 1 reply; 2+ messages in thread
From: tornaria @ 2021-11-14 15:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages Manual.md
https://github.com/void-linux/void-packages/pull/34079

Manual.md: clarify default build target
New text:
  - `make_build_target` The build target. If `${build_style}` is set to `configure`, `gnu-configure` or `gnu-makefile`, this is the target passed to `${make_cmd}` in the build phase; when unset the default target is used.

The previous text incorrectly claims that it defaults to `all`


A patch file from https://github.com/void-linux/void-packages/pull/34079.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Manual.md-34079.patch --]
[-- Type: text/x-diff, Size: 1160 bytes --]

From 1f39c21972bb92da69adaadc9f7bad32460908f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sun, 14 Nov 2021 11:57:58 -0300
Subject: [PATCH] Manual.md: clarify default build target

---
 Manual.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Manual.md b/Manual.md
index b0afd6db1596..22d650b8c529 100644
--- a/Manual.md
+++ b/Manual.md
@@ -581,8 +581,9 @@ phase if `${build_style}` is set to `configure`, `gnu-configure` or
 `PREFIX=/usr DESTDIR=${DESTDIR}`.
 
 - `make_build_target` The build target. If `${build_style}` is set to `configure`, `gnu-configure`
-or `gnu-makefile`, this is the target passed to `${make_cmd}` in the build phase; when unset, it
-defaults to `all`. If `${build_style}` is `python3-pep517`, this is the path of the package
+or `gnu-makefile`, this is the target passed to `${make_cmd}` in the build phase;
+when unset the default target is used.
+If `${build_style}` is `python3-pep517`, this is the path of the package
 directory that should be built as a Python wheel; when unset, defaults to `.` (the current
 directory with respect to the build).
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: Manual.md: clarify default build target
  2021-11-14 15:01 [PR PATCH] Manual.md: clarify default build target tornaria
@ 2021-11-14 18:37 ` ericonr
  0 siblings, 0 replies; 2+ messages in thread
From: ericonr @ 2021-11-14 18:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There's a merged pull request on the void-packages repository

Manual.md: clarify default build target
https://github.com/void-linux/void-packages/pull/34079

Description:
New text:
  - `make_build_target` The build target. If `${build_style}` is set to `configure`, `gnu-configure` or `gnu-makefile`, this is the target passed to `${make_cmd}` in the build phase; when unset the default target is used.

The previous text incorrectly claims that it defaults to `all`


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-14 18:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-14 15:01 [PR PATCH] Manual.md: clarify default build target tornaria
2021-11-14 18:37 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).