Github messages for voidlinux
 help / color / mirror / Atom feed
From: bobertlo <bobertlo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] [wip] new package: firewalld-1.0.1
Date: Sat, 04 Dec 2021 08:12:14 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34378@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

There is a new pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.1
Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1728 bytes --]

From ba3a24fe8f06ebda29a954a5e8c035c731d05db4 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.1

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..62f228bf1b4f
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,20 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

             reply	other threads:[~2021-12-04  7:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-04  7:12 bobertlo [this message]
2021-12-04  7:19 ` [PR PATCH] [Updated] " bobertlo
2021-12-04  8:17 ` bobertlo
2021-12-04  8:23 ` bobertlo
2021-12-04  8:24 ` bobertlo
2021-12-07  4:53 ` [PR PATCH] [Updated] [wip] new package: firewalld-1.0.2 bobertlo
2021-12-13 13:18 ` [PR REVIEW] " ahesford
2021-12-14  2:05 ` [PR PATCH] [Updated] " bobertlo
2021-12-14  2:06 ` bobertlo
2021-12-14  3:40 ` bobertlo
2021-12-14  3:42 ` bobertlo
2021-12-14  3:55 ` bobertlo
2021-12-14  3:56 ` bobertlo
2021-12-14  4:48 ` [PR PATCH] [Updated] " bobertlo
2021-12-15  0:24 ` bobertlo
2021-12-15 14:01 ` bobertlo
2021-12-16  0:05 ` [PR REVIEW] " paper42
2021-12-16  0:05 ` paper42
2021-12-16  0:05 ` paper42
2021-12-16  1:45 ` [PR PATCH] [Updated] " bobertlo
2021-12-16 10:53 ` [PR REVIEW] " paper42
2021-12-16 10:53 ` paper42
2021-12-16 13:20 ` [PR PATCH] [Updated] " bobertlo
2022-02-07 20:59 ` bobertlo
2022-02-07 20:59 ` [PR PATCH] [Closed]: " bobertlo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34378@inbox.vuxu.org \
    --to=bobertlo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).