[PR PATCH] hstr: update to 2.5

[PR PATCH] hstr: update to 2.5

[NeelChotai]

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

There is a new pull request by NeelChotai against master on the void-packages repository

https://github.com/NeelChotai/void-packages hstr-update
https://github.com/void-linux/void-packages/pull/34619

hstr: update to 2.5
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34619.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hstr-update-34619.patch --]
[-- Type: text/x-diff, Size: 1037 bytes --]

From 5d5ac88fe766f646bec4c0a2fe82735f91545b16 Mon Sep 17 00:00:00 2001
From: Neel <neel@chot.ai>
Date: Sun, 19 Dec 2021 21:54:53 +0000
Subject: [PATCH] hstr: update to 2.5

---
 srcpkgs/hstr/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/hstr/template b/srcpkgs/hstr/template
index ee259a9eac03..c37cc4737cfc 100644
--- a/srcpkgs/hstr/template
+++ b/srcpkgs/hstr/template
@@ -1,6 +1,6 @@
 # Template file for 'hstr'
 pkgname=hstr
-version=2.3
+version=2.5
 revision=1
 build_style=gnu-configure
 hostmakedepends="automake pkg-config"
@@ -11,7 +11,7 @@ license="Apache-2.0"
 homepage="https://github.com/dvorka/hstr"
 changelog="https://raw.githubusercontent.com/dvorka/hstr/master/Changelog"
 distfiles="https://github.com/dvorka/hstr/archive/${version}.tar.gz"
-checksum=c7e7408671757b3f4be9c5a59b4e2d56e7a7b601ace2a94eb6b2b61f20ee890b
+checksum=7f5933fc07d55d09d5f7f9a6fbfdfc556d8a7d8575c3890ac1e672adabd2bec4
 
 pre_configure() {
 	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h

Re: hstr: update to 2.5

[paper42]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34619#issuecomment-997474141

Comment:
Can we do something simpler in pre_configure or is there a reason why it's done this way?
```sh
pre_configure() {
    vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h src/include/hstr_curses.h
	autoreconf -fi
}
```

Re: hstr: update to 2.5

[NeelChotai]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by NeelChotai on void-packages repository

https://github.com/void-linux/void-packages/pull/34619#issuecomment-997477697

Comment:
> Can we do something simpler in pre_configure or is there a reason why it's done this way?
> 
> ```shell
> pre_configure() {
>     vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h src/include/hstr_curses.h
> 	autoreconf -fi
> }
> ```

Doesn't seem to be any particular reason, updated!

Re: [PR PATCH] [Updated] hstr: update to 2.5

[NeelChotai]

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

There is an updated pull request by NeelChotai against master on the void-packages repository

https://github.com/NeelChotai/void-packages hstr-update
https://github.com/void-linux/void-packages/pull/34619

hstr: update to 2.5
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34619.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hstr-update-34619.patch --]
[-- Type: text/x-diff, Size: 1482 bytes --]

From 95f6fbbfaadfb94b35026b75915f2288459d2406 Mon Sep 17 00:00:00 2001
From: Neel <neel@chot.ai>
Date: Sun, 19 Dec 2021 21:54:53 +0000
Subject: [PATCH] hstr: update to 2.5

---
 srcpkgs/hstr/template | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/hstr/template b/srcpkgs/hstr/template
index ee259a9eac03..5737a666f240 100644
--- a/srcpkgs/hstr/template
+++ b/srcpkgs/hstr/template
@@ -1,9 +1,9 @@
 # Template file for 'hstr'
 pkgname=hstr
-version=2.3
+version=2.5
 revision=1
 build_style=gnu-configure
-hostmakedepends="automake pkg-config"
+hostmakedepends="autoconf automake pkg-config"
 makedepends="readline-devel"
 short_desc="Easily view, navigate, search and manage your command history"
 maintainer="Neel Chotai <neel@chot.ai>"
@@ -11,12 +11,9 @@ license="Apache-2.0"
 homepage="https://github.com/dvorka/hstr"
 changelog="https://raw.githubusercontent.com/dvorka/hstr/master/Changelog"
 distfiles="https://github.com/dvorka/hstr/archive/${version}.tar.gz"
-checksum=c7e7408671757b3f4be9c5a59b4e2d56e7a7b601ace2a94eb6b2b61f20ee890b
+checksum=7f5933fc07d55d09d5f7f9a6fbfdfc556d8a7d8575c3890ac1e672adabd2bec4
 
 pre_configure() {
-	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h
-	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr_curses.h
-	aclocal
-	automake --force-missing --add-missing
-	autoconf
+	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h src/include/hstr_curses.h
+	autoreconf -fi
 }

Re: [PR REVIEW] hstr: update to 2.5

[paper42]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34619#discussion_r772019404

Comment:
autoconf is already a dependency of automake

Re: [PR REVIEW] hstr: update to 2.5

[paper42]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34619#discussion_r772019404

Comment:
autoconf is already a dependency of automake, so we don't need to explicitly specify it

Re: [PR PATCH] [Updated] hstr: update to 2.5

[NeelChotai]

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

There is an updated pull request by NeelChotai against master on the void-packages repository

https://github.com/NeelChotai/void-packages hstr-update
https://github.com/void-linux/void-packages/pull/34619

hstr: update to 2.5
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34619.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hstr-update-34619.patch --]
[-- Type: text/x-diff, Size: 1285 bytes --]

From 89e53adc414baa0ad6af7f9bd998149ae6d20af4 Mon Sep 17 00:00:00 2001
From: Neel <neel@chot.ai>
Date: Sun, 19 Dec 2021 21:54:53 +0000
Subject: [PATCH] hstr: update to 2.5

---
 srcpkgs/hstr/template | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/hstr/template b/srcpkgs/hstr/template
index ee259a9eac03..3f2d95c854ec 100644
--- a/srcpkgs/hstr/template
+++ b/srcpkgs/hstr/template
@@ -1,6 +1,6 @@
 # Template file for 'hstr'
 pkgname=hstr
-version=2.3
+version=2.5
 revision=1
 build_style=gnu-configure
 hostmakedepends="automake pkg-config"
@@ -11,12 +11,9 @@ license="Apache-2.0"
 homepage="https://github.com/dvorka/hstr"
 changelog="https://raw.githubusercontent.com/dvorka/hstr/master/Changelog"
 distfiles="https://github.com/dvorka/hstr/archive/${version}.tar.gz"
-checksum=c7e7408671757b3f4be9c5a59b4e2d56e7a7b601ace2a94eb6b2b61f20ee890b
+checksum=7f5933fc07d55d09d5f7f9a6fbfdfc556d8a7d8575c3890ac1e672adabd2bec4
 
 pre_configure() {
-	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h
-	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr_curses.h
-	aclocal
-	automake --force-missing --add-missing
-	autoconf
+	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h src/include/hstr_curses.h
+	autoreconf -fi
 }

Re: [PR PATCH] [Updated] hstr: update to 2.5

[NeelChotai]

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

There is an updated pull request by NeelChotai against master on the void-packages repository

https://github.com/NeelChotai/void-packages hstr-update
https://github.com/void-linux/void-packages/pull/34619

hstr: update to 2.5
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34619.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hstr-update-34619.patch --]
[-- Type: text/x-diff, Size: 1285 bytes --]

From 23417960a2ef466a910b1ffde8ba9fa58aaeb81d Mon Sep 17 00:00:00 2001
From: Neel <neel@chot.ai>
Date: Sun, 19 Dec 2021 21:54:53 +0000
Subject: [PATCH] hstr: update to 2.5

---
 srcpkgs/hstr/template | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/hstr/template b/srcpkgs/hstr/template
index ee259a9eac03..3f2d95c854ec 100644
--- a/srcpkgs/hstr/template
+++ b/srcpkgs/hstr/template
@@ -1,6 +1,6 @@
 # Template file for 'hstr'
 pkgname=hstr
-version=2.3
+version=2.5
 revision=1
 build_style=gnu-configure
 hostmakedepends="automake pkg-config"
@@ -11,12 +11,9 @@ license="Apache-2.0"
 homepage="https://github.com/dvorka/hstr"
 changelog="https://raw.githubusercontent.com/dvorka/hstr/master/Changelog"
 distfiles="https://github.com/dvorka/hstr/archive/${version}.tar.gz"
-checksum=c7e7408671757b3f4be9c5a59b4e2d56e7a7b601ace2a94eb6b2b61f20ee890b
+checksum=7f5933fc07d55d09d5f7f9a6fbfdfc556d8a7d8575c3890ac1e672adabd2bec4
 
 pre_configure() {
-	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h
-	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr_curses.h
-	aclocal
-	automake --force-missing --add-missing
-	autoconf
+	vsed -i 's|ncursesw/curses.h|curses.h|g' src/include/hstr.h src/include/hstr_curses.h
+	autoreconf -fi
 }

Re: [PR REVIEW] hstr: update to 2.5

[NeelChotai]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New review comment by NeelChotai on void-packages repository

https://github.com/void-linux/void-packages/pull/34619#discussion_r825352740

Comment:
fixed!

Re: [PR PATCH] [Merged]: hstr: update to 2.5

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

There's a merged pull request on the void-packages repository

hstr: update to 2.5
https://github.com/void-linux/void-packages/pull/34619

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->